Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032935Openbravo ERP04. Warehouse managementpublic2016-05-11 17:392018-01-26 10:51
Reporterngarcia 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket41744
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032935: Data is pending to be created in M_STORAGE_PENDING by the Fix Stock process
DescriptionData is pending to be created in M_STORAGE_PENDING by the Fix Stock process. The problem is the m_product_uom_id is passed to the convertUOM function instead of the c_uom_id
Steps To ReproduceAs system admin role:
   Set as Displayed the fields related with second UOM feature:
      Order UOM
      Order Quantity
   Set as Active the tabs used in that feature:
      Product - UOM
      Unit Of Measure - Conversion
   Install the org.openbravo.module.fixstock module (it is not available in the module management window, it is on https://code.openbravo.com/erp/pmods [^] [^] repository)
As group admin role:
   Create a product
   Add a new unit in the UOM tab
   Configure the conversion between both of them
   Add a purchase price to it
   Add a new product
   Do not set a UOM to it
   Add a purchase price to it
   Create a purchase order and add the previously created products
   You should fill the Order Quantity and Order UOM fields to one of them
   Book it
   Create a partial goods receipt from it
   Check there is an entry in the m_storage_pending for that product
   Go to Process Request window and launch the Fix Stock process
   Check there is no entry in the m_storage_pending for these products
Proposed SolutionAttached a possible patch
Additional Information
TagsFix Stock
Relationships
related to defect 0032943 closed markmm82 'Fix Stock QuantityOrder Process' should round the Order quantity of the opening physical inventory to the std precision 
depends on defect 0032934 closed markmm82 Wrong definition of convertUOM function in RestoreStockValue_data.xsql 
related to defect 0032951 closed alostale Fix Stock process rounds the quantities to 6 decimals and it should not 
Attached Filesdiff 32395.diff (27,866) 2016-05-11 18:07
https://issues.openbravo.com/file_download.php?file_id=9394&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-11 17:39ngarciaNew Issue
2016-05-11 17:39ngarciaAssigned To => Triage Finance
2016-05-11 17:39ngarciaOBNetwork customer => Yes
2016-05-11 17:39ngarciaModules => Core
2016-05-11 17:39ngarciaSupport ticket => 32934
2016-05-11 17:39ngarciaResolution time => 1466200800
2016-05-11 17:39ngarciaTriggers an Emergency Pack => No
2016-05-11 17:39ngarciaRelationship addeddepends on 0032934
2016-05-11 17:39ngarciaIssue Monitored: networkb
2016-05-11 17:43ngarciaFile Added: 32935.diff
2016-05-11 18:03aferrazAssigned ToTriage Finance => markmm82
2016-05-11 18:06ngarciaFile Deleted: 32935.diff
2016-05-11 18:07ngarciaFile Added: 32395.diff
2016-05-12 13:20ngarciaSupport ticket32934 => 41744
2016-05-16 13:26aferrazRelationship addedrelated to 0032951
2016-05-16 13:26aferrazRelationship addedrelated to 0032943
2016-05-20 15:13hgbotCheckin
2016-05-20 15:13hgbotNote Added: 0086625
2016-05-20 15:13hgbotStatusnew => resolved
2016-05-20 15:13hgbotResolutionopen => fixed
2016-05-20 15:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.fixstock/rev/408ed751de816784e82cff02effc965d64cbdc99 [^]
2016-05-20 15:13hgbotCheckin
2016-05-20 15:13hgbotNote Added: 0086626
2016-05-20 15:13hgbotCheckin
2016-05-20 15:13hgbotNote Added: 0086628
2016-05-20 15:14aferrazReview Assigned To => aferraz
2016-05-20 15:14aferrazNote Added: 0086630
2016-05-20 15:14aferrazStatusresolved => closed
2018-01-26 10:51ngarciaTag Attached: Fix Stock

Notes
(0086625)
hgbot   
2016-05-20 15:13   
Repository: erp/pmods/org.openbravo.module.fixstock
Changeset: 408ed751de816784e82cff02effc965d64cbdc99
Author: Mark <markmm82 <at> gmail.com>
Date: Sun May 15 19:15:17 2016 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.fixstock/rev/408ed751de816784e82cff02effc965d64cbdc99 [^]

Fixes issue 32934 & Fixes issue 32935: Error in Fix Stock process

Data is created in M_STORAGE_PENDING by the Fix Stock process.
The c_uom_id is passed to the convertUOM function instead of the m_product_uom_id.
Correct definition of convertUOM function in RestoreStockValue_data.xsql.

---
M src/org/openbravo/module/fixstock/RestoreStockValue.java
M src/org/openbravo/module/fixstock/RestoreStockValue_data.xsql
---
(0086626)
hgbot   
2016-05-20 15:13   
Repository: erp/pmods/org.openbravo.module.fixstock
Changeset: ecf2f1a3e01131293400e46bb62f3e243516762d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 20 14:21:07 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.fixstock/rev/ecf2f1a3e01131293400e46bb62f3e243516762d [^]

Related to issue 32935: Code review improvements

---
M src/org/openbravo/module/fixstock/RestoreStockValue.java
---
(0086628)
hgbot   
2016-05-20 15:13   
Repository: erp/pmods/org.openbravo.module.fixstock
Changeset: d3c9a8b3561c70b89f6de33faf318dc04c6165e3
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 20 15:12:58 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.fixstock/rev/d3c9a8b3561c70b89f6de33faf318dc04c6165e3 [^]

Related to issue 32934 & Related to issue 32935: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0086630)
aferraz   
2016-05-20 15:14   
Code review + Testing OK