Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032923Openbravo ERPA. Platformpublic2016-05-11 10:562016-06-17 19:37
Reportercaristu 
Assigned ToNaroaIriarte 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032923: NullPointerException in SelectorFieldPropertyCallout
DescriptionA NullPointerException is thrown in SelectorFieldPropertyCallout after selecting a computed column as a property to be shown as a selector field.

In this case, the callout execution is not completed successfully.
Steps To Reproduce1) As system role, go to [Reference] window
2) Create a new Reference with OBUISEL_Selector Reference as parent reference
3) Navigate to [Defined Selector] tab, create a new record:
  - Name: order
  - Table: Order
  - Template: Selector Template
4) Navigate to [Defined Selector] tab, create a new record:
  - Select a computed column as the property for the field, for example _computedColumns.deliveryStatus. The error mentioned above is thrown in the log.
Proposed SolutionPrevent NullPointerException in line 108 of SelectorFieldPropertyCallout, for example by checking if currentEntity is null before doing currentEntity.getProperty(part)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-11 10:56caristuNew Issue
2016-05-11 10:56caristuAssigned To => platform
2016-05-11 10:56caristuModules => Core
2016-05-11 10:56caristuTriggers an Emergency Pack => No
2016-05-11 10:57caristuSeverityminor => major
2016-05-11 10:57caristuDescription Updatedbug_revision_view_page.php?rev_id=12043#r12043
2016-05-13 10:53NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-05-13 10:53NaroaIriarteStatusnew => acknowledged
2016-05-17 16:31hgbotCheckin
2016-05-17 16:31hgbotNote Added: 0086503
2016-05-17 16:31hgbotStatusacknowledged => resolved
2016-05-17 16:31hgbotResolutionopen => fixed
2016-05-17 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4451654b2b92a21c56a163451b37c569ed57d425 [^]
2016-05-20 08:02alostaleReview Assigned To => alostale
2016-05-20 08:02alostaleNote Added: 0086586
2016-05-20 08:02alostaleStatusresolved => closed
2016-05-20 08:02alostaleFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087541

Notes
(0086503)
hgbot   
2016-05-17 16:31   
Repository: erp/devel/pi
Changeset: 4451654b2b92a21c56a163451b37c569ed57d425
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon May 16 15:57:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4451654b2b92a21c56a163451b37c569ed57d425 [^]

Fixed issue 32923: There was a NPE in the SelectorFieldPropertyCallout

There was a NullpointerException in the SelectorFieldPropertyCallout because
in the printPage method, there was not being taken into account the fact of
having a property of a computed column and the entity was not correctly retrieved.
This have been fixed checking if it is a computed column and generating the entity
correctly if so.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyCallout.java
---
(0086586)
alostale   
2016-05-20 08:02   
code reviewed + tested
(0087541)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test