Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032917Retail ModulesReturn Receiptpublic2016-05-10 15:042016-06-29 17:28
Reporterprakashmurugesan88 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032917: [SERQA 1001] Unable to do payment for Verified Return Service
DescriptionVerified Return Problem:

It is not possible to do payment for verified return service, after it is approved.

Steps To ReproduceIn backoffice:
For Approval preference need to be set:
Set "Enable WEBPOS Service Return" to 'N' for the client.(To go for approval)
Set "Enable WEPPOS Service Return" to 'Y' for the user openbravo. (To Approve)

In the webpos:
- Create a ticket with product and its service and do payment.
- Select verified return choose the ticket that was created in above step.
- Select all the lines of the ticket - Apply
- Approve the pop up.
- Click on Amount - V - Done
- Result: Error Message
"TypeError: Cannot read property 'scale' of undefined at toNumber "

https://drive.google.com/a/openbravo.com/file/d/0B3RBrE5TUxwba2RWVkh5UGl3TWs/view [^]
Proposed SolutionAttached possible solution for the problem. It is needed both patches, one for the retail.posterminal module and the other for the retail.returns module.
Additional Information
TagsSER-QA
Relationships
has duplicate defect 0032931 closed ranjith_qualiantech_com Services added with verified returns may end up with price 0 
Attached Filespatch Issue1001_Retail_POSTerminal.patch (1,200) 2016-05-11 11:00
https://issues.openbravo.com/file_download.php?file_id=9388&type=bug
patch Issue1001_Retail_Return.patch (2,532) 2016-05-11 11:00
https://issues.openbravo.com/file_download.php?file_id=9389&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-10 15:04prakashmurugesan88New Issue
2016-05-10 15:04prakashmurugesan88Assigned To => Retail
2016-05-10 15:04prakashmurugesan88Triggers an Emergency Pack => No
2016-05-11 10:23adrianromeroResolution time => 1463522400
2016-05-11 10:23adrianromeroProposed Solution updated
2016-05-11 10:24adrianromeroTag Attached: SER-QA
2016-05-11 11:00adrianromeroFile Added: Issue1001_Retail_POSTerminal.patch
2016-05-11 11:00adrianromeroFile Added: Issue1001_Retail_Return.patch
2016-05-11 11:01adrianromeroProposed Solution updated
2016-05-11 18:20OrekariaStatusnew => acknowledged
2016-05-11 18:21amayavicenteSummaryUnable to do payment for Verified Return Service => [SERQA 1001] Unable to do payment for Verified Return Service
2016-05-11 18:22amayavicenteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12061#r12061
2016-05-11 18:23amayavicenteSeverityminor => major
2016-05-16 18:32mario_castelloAssigned ToRetail => mario_castello
2016-05-16 18:32mario_castelloStatusacknowledged => scheduled
2016-05-17 15:06ranjith_qualiantech_comRelationship addedhas duplicate 0032931
2016-05-18 16:03adrianromeroAssigned Tomario_castello => prakashmurugesan88
2016-05-18 17:23hgbotCheckin
2016-05-18 17:23hgbotNote Added: 0086559
2016-05-19 10:28OrekariaAssigned Toprakashmurugesan88 => mario_castello
2016-05-19 10:31OrekariaAssigned Tomario_castello => prakashmurugesan88
2016-05-23 14:08ranjith_qualiantech_comRelationship addedrelated to 0032826
2016-05-23 14:09ranjith_qualiantech_comRelationship deletedrelated to 0032826
2016-05-30 12:57hgbotCheckin
2016-05-30 12:57hgbotNote Added: 0086804
2016-05-30 12:57hgbotCheckin
2016-05-30 12:57hgbotNote Added: 0086805
2016-05-30 12:57hgbotStatusscheduled => resolved
2016-05-30 12:57hgbotResolutionopen => fixed
2016-05-30 12:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2145ab2910b3ce31a3c322301d31f212bc2dbe6b [^]
2016-05-30 12:59hgbotCheckin
2016-05-30 12:59hgbotNote Added: 0086806
2016-05-30 12:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2145ab2910b3ce31a3c322301d31f212bc2dbe6b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3affbc290050ac48bc9f14386651ed69182ded04 [^]
2016-05-30 13:46adrianromeroReview Assigned To => Orekaria
2016-06-13 09:47aaroncaleroNote Added: 0087189
2016-06-14 12:25dmitry_mezentsevNote Added: 0087248
2016-06-21 12:00adrianromeroStatusresolved => new
2016-06-21 12:00adrianromeroResolutionfixed => open
2016-06-21 12:00adrianromeroStatusnew => scheduled
2016-06-22 12:42hgbotCheckin
2016-06-22 12:42hgbotNote Added: 0087788
2016-06-22 12:42hgbotStatusscheduled => resolved
2016-06-22 12:42hgbotResolutionopen => fixed
2016-06-22 12:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3affbc290050ac48bc9f14386651ed69182ded04 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99184f886e59421be46ac7e9aa751b0418459155 [^]
2016-06-24 11:53OrekariaNote Added: 0087888
2016-06-24 11:53OrekariaStatusresolved => new
2016-06-24 11:53OrekariaResolutionfixed => open
2016-06-24 11:53OrekariaStatusnew => scheduled
2016-06-24 11:55OrekariaNote Edited: 0087888bug_revision_view_page.php?bugnote_id=0087888#r12488
2016-06-24 11:55OrekariaNote Edited: 0087888bug_revision_view_page.php?bugnote_id=0087888#r12489
2016-06-29 11:33hgbotCheckin
2016-06-29 11:33hgbotNote Added: 0088072
2016-06-29 11:33hgbotStatusscheduled => resolved
2016-06-29 11:33hgbotResolutionopen => fixed
2016-06-29 11:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99184f886e59421be46ac7e9aa751b0418459155 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ab2c8baea281a18b40552f3f738a35e6dde93df2 [^]
2016-06-29 11:34hgbotCheckin
2016-06-29 11:34hgbotNote Added: 0088073
2016-06-29 11:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ab2c8baea281a18b40552f3f738a35e6dde93df2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcd7bad59a18a184aa0303cdf4d01623190b8757 [^]
2016-06-29 17:28OrekariaStatusresolved => closed
2016-06-29 17:28OrekariaFixed in Version => RR16Q3

Notes
(0086559)
hgbot   
2016-05-18 17:23   
Repository: tools/automation/pi-mobile
Changeset: f7000a4c2f984075dafdd16a83f4af798067ab33
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed May 18 09:22:47 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f7000a4c2f984075dafdd16a83f4af798067ab33 [^]

Related to issue 32917: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32917_VerifiedReturnsAndServiceApproval.java
---
(0086804)
hgbot   
2016-05-30 12:57   
Repository: tools/automation/pi-mobile
Changeset: 1b7ef90a99623f222cf75d820b5be01087fe38f1
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri May 27 12:05:56 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1b7ef90a99623f222cf75d820b5be01087fe38f1 [^]

Verifies Issue 32917: Verified Return Service Approval

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32917_VerifiedReturnsAndServiceApproval.java
---
(0086805)
hgbot   
2016-05-30 12:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2145ab2910b3ce31a3c322301d31f212bc2dbe6b
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri May 27 15:53:56 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2145ab2910b3ce31a3c322301d31f212bc2dbe6b [^]

Fixes Issue 32917: Verified Return Service Approval

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086806)
hgbot   
2016-05-30 12:59   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 3affbc290050ac48bc9f14386651ed69182ded04
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri May 27 15:53:41 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/3affbc290050ac48bc9f14386651ed69182ded04 [^]

Fixes Issue 32917: Verified Return Service Approval

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087189)
aaroncalero   
2016-06-13 09:47   
The commit done in posterminal leaves the POS stuck in the Loading screen when adding a service on a Return ticket (flagged as "To Be Returned")
(0087248)
dmitry_mezentsev   
2016-06-14 12:25   
Not closed for 15 days!
(0087788)
hgbot   
2016-06-22 12:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 99184f886e59421be46ac7e9aa751b0418459155
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Jun 22 16:11:56 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99184f886e59421be46ac7e9aa751b0418459155 [^]

Fixed Issue 32917: Fixed Return Service Issue

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0087888)
Orekaria   
2016-06-24 11:53   
(edited on: 2016-06-24 11:55)
Fix and test are working, but

OB.UTIL.showLoading should be used only in very few situations. Please remove them or talk Retail team and explain what you are trying to solve.

Regards
Rafa
(0088072)
hgbot   
2016-06-29 11:33   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: ab2c8baea281a18b40552f3f738a35e6dde93df2
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Jun 27 15:02:16 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ab2c8baea281a18b40552f3f738a35e6dde93df2 [^]

Fixes Issue 32917: Fixed Return Service Issue

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0088073)
hgbot   
2016-06-29 11:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bcd7bad59a18a184aa0303cdf4d01623190b8757
Author: Prakash M <prakash <at> qualiantech.com>
Date: Mon Jun 27 15:20:27 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcd7bad59a18a184aa0303cdf4d01623190b8757 [^]

Fixed Issue 32917: Fixed Return Service Issue

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---