Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032916Openbravo ERP07. Sales managementpublic2016-05-10 12:592016-05-23 13:59
Reporterpsanjuan 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionProfessional Appliance
Product Version 
Target Version3.0PR16Q2Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2016-01-13
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/cac91026199d [^]
Triggers an Emergency PackNo
Summary0032916: Wrong payment status as well payment in details when partially paying a Reversed Sales Invoice
DescriptionWrong payment status as well payment details when partially paying a Reversed Sales Invoice
Steps To Reproduce- Go to Sales Invoice window. Create a new one for F&B España, Alimentos BP.
- Change document type to "Reversed Sales Invoice".
- Save it

- Go to lines and create a new one.
** Product = Agua sin Gas 1
** Invoiced Quantity = -500
- Complete it. (If there is any credit available, do NOT use it).

- Press Add Payment.
- Change Actual Payment amount to -500.00
- Make sure only the reversed sales invoice just created is selected. Change its amount from -925.65 to -500.00 (see Issue 32914_Image 1).
- Press Done

- Realize that Payment Complete status of the invoice has turned into Yes (which is not correct).

- Go to Payment Plan tab and check neither received amount, outstanding amount are correct.

- Navigate to the payment in created and realize that not only the total reversed sales invoice amount has been paid, but also some credit amount has been generated. (see Issue32914_Image2)

Take note that same error is happening in purchase.
Proposed SolutionPayment Complete status should not turn into Yes because the reverse sales invoice has been partially paid.

Payment Plan should be updated properly

Payment In created should be the correct one base on actual payment entered.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032914 closed aferraz Wrong payment status as well payment in details when partially paying a Reversed Sales Invoice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-10 14:19aferrazTypedefect => backport
2016-05-10 14:19aferrazTarget Version => 3.0PR16Q2
2016-05-10 14:19aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-05-23 10:07aferrazAssigned ToAtulOpenbravo => aferraz
2016-05-23 13:43hgbotCheckin
2016-05-23 13:43hgbotNote Added: 0086651
2016-05-23 13:43hgbotStatusscheduled => resolved
2016-05-23 13:43hgbotResolutionopen => fixed
2016-05-23 13:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/4d626559c58861630878ffafd67e9b0380166625 [^]
2016-05-23 13:43hgbotCheckin
2016-05-23 13:43hgbotNote Added: 0086652
2016-05-23 13:44vmromanosReview Assigned To => vmromanos
2016-05-23 13:44vmromanosNote Added: 0086655
2016-05-23 13:44vmromanosStatusresolved => closed
2016-05-23 13:59vmromanosSeveritycritical => major

Notes
(0086651)
hgbot   
2016-05-23 13:43   
Repository: erp/backports/3.0PR16Q2
Changeset: 4d626559c58861630878ffafd67e9b0380166625
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu May 19 15:15:02 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/4d626559c58861630878ffafd67e9b0380166625 [^]

Fixes issue 32916: Fix properly issue 31457

Change getOrderedPaymentScheduleDetails method in AddPaymentActionHandler class to order by absolute value of FIN_PaymentScheduleDetail.PROPERTY_AMOUNT property.
Change also the manage negative amounts check to recalculate remainingAmount if it is lower than outstandingAmount in case remainingAmount is negative.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0086652)
hgbot   
2016-05-23 13:43   
Repository: erp/backports/3.0PR16Q2
Changeset: d74e284a07d013ae4bea15ac44578a4285a503c6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon May 23 13:43:19 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/d74e284a07d013ae4bea15ac44578a4285a503c6 [^]

Related to issue 32916: Update copyright year

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0086655)
vmromanos   
2016-05-23 13:44   
Code review OK