Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032898Retail ModulesReturn Receiptpublic2016-05-06 23:022016-05-17 17:17
ReporterOsmany 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/d7e8be70a587 [^]
Triggers an Emergency PackNo
Summary0032898: [SERQA 1045] Verified Return not using original customer
DescriptionWhen you select a Ticket of a client to do a verified return the new ticket is created with anonymous customer instead of original's one.

This issue happens only when is activated 'Enable Remote for Customer' Preference
Steps To ReproduceIn ERP Backend:
- Preference: Enable Remote for Customer - value Y

Log into WebPOS
- Click on verified returns
- Select a ticket with a client different of anonymus client
- Realize that the new ticket is created with anonymus ticket
Proposed SolutionAttached two different proposals, one in order.js and the other in modalReturnLines.js. Need to decide what is the better approach.

It seems the proposals attached does not solve the root of the problem and just the consequences. So it is needed to research what is the best solution.
Additional Information
TagsSER-QA
Relationships
depends on backport 0032936RR16Q2 closed mario_castello [SERQA 1045] Verified Return not using original customer 
Attached Filesdiff proposalsolution.diff (816) 2016-05-06 23:02
https://issues.openbravo.com/file_download.php?file_id=9368&type=bug
diff 32898ReturnLines.diff (1,129) 2016-05-09 10:23
https://issues.openbravo.com/file_download.php?file_id=9372&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-06 23:02OsmanyNew Issue
2016-05-06 23:02OsmanyAssigned To => Retail
2016-05-06 23:03OsmanyFile Added: proposalsolution.diff
2016-05-06 23:03OsmanyOBNetwork customer => No
2016-05-06 23:03OsmanyTriggers an Emergency Pack => No
2016-05-09 10:23adrianromeroFile Added: 32898ReturnLines.diff
2016-05-09 10:24adrianromeroProposed Solution updated
2016-05-09 10:25adrianromeroOBNetwork customerNo => Yes
2016-05-09 10:25adrianromeroResolution time => 1463349600
2016-05-09 10:25adrianromeroTag Attached: SER-QA
2016-05-09 17:06OsmanyRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/d7e8be70a587 [^]
2016-05-10 10:30OrekariaResolution time1463349600 => 1463695200
2016-05-10 10:30OrekariaStatusnew => acknowledged
2016-05-10 10:31OrekariaSummaryVerified Return not changes the customer => Verified Return not using original customer
2016-05-10 15:38mario_castelloAssigned ToRetail => mario_castello
2016-05-10 15:38mario_castelloStatusacknowledged => scheduled
2016-05-10 18:10adrianromeroProposed Solution updated
2016-05-11 18:04amayavicenteSummaryVerified Return not using original customer => [SERQA 1045] Verified Return not using original customer
2016-05-11 18:06OrekariaStatusscheduled => feedback
2016-05-11 18:06OrekariaStatusfeedback => scheduled
2016-05-12 16:38hgbotCheckin
2016-05-12 16:38hgbotNote Added: 0086421
2016-05-12 18:55hgbotCheckin
2016-05-12 18:55hgbotNote Added: 0086430
2016-05-12 18:55hgbotStatusscheduled => resolved
2016-05-12 18:55hgbotResolutionopen => fixed
2016-05-12 18:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/e5eebca33a4b939ad3168a1c80a20ad203146c8a [^]
2016-05-12 19:05mario_castelloNote Edited: 0086430bug_revision_view_page.php?bugnote_id=0086430#r12089
2016-05-17 17:17guilleaerReview Assigned To => guilleaer
2016-05-17 17:17guilleaerStatusresolved => closed
2016-05-17 17:17guilleaerFixed in Version => RR16Q3

Notes
(0086421)
hgbot   
2016-05-12 16:38   
Repository: tools/automation/pi-mobile
Changeset: f7c88b365d47527098534b5b6a96037d2133f707
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu May 12 08:38:35 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f7c88b365d47527098534b5b6a96037d2133f707 [^]

Related to issue 32898: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32898_VerifiedReturnsAndRemoteCustomer.java
---
(0086430)
hgbot   
2016-05-12 18:55   
(edited on: 2016-05-12 19:05)
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: e5eebca33a4b939ad3168a1c80a20ad203146c8a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue May 10 11:53:36 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/e5eebca33a4b939ad3168a1c80a20ad203146c8a [^]

Fixed issue 32898: Deleted unnecessary code in verified returns lines.

It is not necessary to execute removeTemporaly and saveTemporaly for customer in the verified returns process.
This funcionality has been implemented on setBPandBPLoc function in order.js.

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---