Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032873Retail ModulesWeb POSpublic2016-05-05 12:372016-06-17 14:39
ReporterVictorVillar 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032873: [SER QA 1058] The Enter key in an external keyboard is not working
DescriptionThe Enter key in an external keyboard is not working
Steps To ReproduceLog in in the Terminal.
  Select a product.
  Edit the Line and click in Quantity.
  Press 8 number and press the Enter key in the external keyboard.

Realise that the only thing that you are doing s add more 8.

The enter key in the key board is not working as the Enter in the keypad
Proposed Solution
Additional Information
TagsSER-QA
Relationships
related to defect 0033095 closed jorge-garcia [SERQA 1193] Duplicated input on the POS keyboard with External Input enabled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-05 12:37VictorVillarNew Issue
2016-05-05 12:37VictorVillarAssigned To => Retail
2016-05-05 12:37VictorVillarResolution time => 1463608800
2016-05-05 12:37VictorVillarTriggers an Emergency Pack => No
2016-05-05 12:37VictorVillarTag Attached: SER-QA
2016-05-05 15:59OrekariaStatusnew => acknowledged
2016-05-30 11:55VictorVillarResolution time1463608800 => 1465509600
2016-05-30 13:13jorge-garciaStatusacknowledged => scheduled
2016-05-30 13:13jorge-garciaAssigned ToRetail => jorge-garcia
2016-06-07 15:23hgbotCheckin
2016-06-07 15:23hgbotNote Added: 0087063
2016-06-07 15:23hgbotStatusscheduled => resolved
2016-06-07 15:23hgbotResolutionopen => fixed
2016-06-07 15:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/89ae499ba5628736457fd187babef831b3ae0069 [^]
2016-06-07 15:23hgbotCheckin
2016-06-07 15:23hgbotNote Added: 0087064
2016-06-07 15:24hgbotCheckin
2016-06-07 15:24hgbotNote Added: 0087065
2016-06-09 17:40marvintmNote Added: 0087143
2016-06-09 17:40marvintmStatusresolved => new
2016-06-09 17:40marvintmResolutionfixed => open
2016-06-09 17:40marvintmStatusnew => scheduled
2016-06-10 11:40VictorVillarRelationship addedrelated to 0033095
2016-06-14 12:04hgbotCheckin
2016-06-14 12:04hgbotNote Added: 0087246
2016-06-14 12:05jorge-garciaStatusscheduled => resolved
2016-06-14 12:05jorge-garciaFixed in Version => RR16Q3
2016-06-14 12:05jorge-garciaResolutionopen => fixed
2016-06-17 14:39marvintmReview Assigned To => marvintm
2016-06-17 14:39marvintmStatusresolved => closed

Notes
(0087063)
hgbot   
2016-06-07 15:23   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 89ae499ba5628736457fd187babef831b3ae0069
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 30 16:58:36 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/89ae499ba5628736457fd187babef831b3ae0069 [^]

Fixed issue 32873: [SER QA 1058] The Enter key in an external keyboard is
not working

All external inputs (external keyboard, barcode scanner, etc) are disabled if
the check of Use External Input is unchecked in the backend.

In some windows of WebPOS, even if the Use External Input is checked, the
use of external inputs are forbidden.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0087064)
hgbot   
2016-06-07 15:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4caf2476203604e2f0064b5a3361c0e67ba0b517
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jun 06 17:18:31 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4caf2476203604e2f0064b5a3361c0e67ba0b517 [^]

Related to issue 32873: [SER QA 1058] The Enter key in an external keyboard is
not working

Re-enable to use the external input in two windiow:
* Payment window.
* Receipt Discounts window.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0087065)
hgbot   
2016-06-07 15:24   
Repository: tools/automation/pi-mobile
Changeset: 2d1c9b21dbf7f57a79790fd9cde1e80458f7019a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 31 11:20:28 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2d1c9b21dbf7f57a79790fd9cde1e80458f7019a [^]

Related to issue 32873: [SER QA 1058] The Enter key in an external keyboard is
not working

Some changes requires to be changed due to this fix.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multiselection/DelKeyDownMultipleLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I23951_Max20KeyStrokes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I30162_MissingKeyStrokesOnEdit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I30168_BackspaceShouldNotNavigateBack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32878_CheckDeleteKeyOnReceipt.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/externalInput/ExternalInputForbiddenInPaymentWindow.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/payButton/I27506_PayButtonEnablingDisabling.java
---
(0087143)
marvintm   
2016-06-09 17:40   
The ENTER key works correctly, and the restriction to use the external keyboard only if the configuration is set is also correct. However, currently there is a message which is shown when the keyboard is disabled, and key presses are done.

The message itself is hardcoded in the code, and this is wrong. However, instead of moving it to a message entry, I would prefer to just remove it, as I think it's not needed, and only creates confusion.
(0087246)
hgbot   
2016-06-14 12:04   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0e433c5b483651e761e830b2957a641d44955fd8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jun 14 08:53:32 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e433c5b483651e761e830b2957a641d44955fd8 [^]

Related to issue 32873: [SER QA 1058] The Enter key in an external keyboard is
not working

Delete warning messages.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---