Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032844ModulesMass Invoicingpublic2016-05-03 18:522016-08-26 14:44
Reporterngarcia 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0032844: Wrong total net and gross amounts when generating an invoice with the Mass Invoicing process
DescriptionWrong total net and gross amounts when generating an invoice with the Mass Invoicing process
Steps To ReproduceAs group admin role:
   Create an Invoice Template
   Add a Invoice Template Line
   Open the Mass Invoicing form and select the previously created template
   Select the products to use in the invoices and click Next
   Click Generate and OK
   Go to Sales Invoice window and check the Total Net Amount and Total Gross Amount are not correct
Proposed SolutionCheck if setting the SummedLineAmount to 0 (instead of adding the line net amount to it) in the setInvoicePropertiesAdminMode function of InvoicePropertySetter class solves the problem
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032428 closed markmm82 Openbravo ERP Wrong Tax Amount and Total Gross Amount in orders created by the Copy Record process if price list includes taxes 
related to defect 0032472 closed markmm82 Modules Purchase Invoices with Total Gross Amount of 0 created from Procurement Contract Billing Process 
caused by feature request 0028366 closed adrianromero Openbravo ERP Add new functionality to calculate taxes per product BOM 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-03 18:52ngarciaNew Issue
2016-05-03 18:52ngarciaAssigned To => Triage Finance
2016-05-03 18:52ngarciaResolution time => 1465855200
2016-05-03 18:52ngarciaIssue Monitored: networkb
2016-05-03 18:53ngarciaRelationship addedcaused by 0028366
2016-05-04 10:04aferrazRelationship addedrelated to 0032428
2016-05-04 10:04aferrazRelationship addedrelated to 0032472
2016-05-04 13:32ngarciaProposed Solution updated
2016-05-04 16:31jfrancesIssue Monitored: jfrances
2016-05-05 09:29aferrazAssigned ToTriage Finance => markmm82
2016-05-05 19:36markmm82Statusnew => scheduled
2016-05-05 19:37markmm82Note Added: 0086223
2016-05-06 16:02hgbotCheckin
2016-05-06 16:02hgbotNote Added: 0086279
2016-05-06 16:02hgbotStatusscheduled => resolved
2016-05-06 16:02hgbotResolutionopen => fixed
2016-05-06 16:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/b0bb4dae12b5b416c8d8947ee84694786e687f41 [^]
2016-05-06 16:02hgbotCheckin
2016-05-06 16:02hgbotNote Added: 0086280
2016-05-06 16:12aferrazReview Assigned To => aferraz
2016-05-06 16:12aferrazNote Added: 0086282
2016-05-06 16:12aferrazStatusresolved => closed
2016-05-09 13:38aferrazFile Added: 32844.txt
2016-05-09 13:39aferrazFile Deleted: 32844.txt
2016-05-09 13:42aferrazFile Added: 32844.sql
2016-05-09 13:43aferrazNote Added: 0086312
2016-08-26 14:25aferrazFile Deleted: 32844.sql
2016-08-26 14:25aferrazNote Deleted: 0086312

Notes
(0086223)
markmm82   
2016-05-05 19:37   
Test Plan:
As group admin role:
   Create an Invoice Template
    Organization: España - Región Norte
    Document type: AR Invoice
    Price List: Tarifa de ventas
    Payment method: Transferencia
    Payment Terms: 30 days
   Add a Invoice Template Line
    Product: Cerveza Ale 0,5 L
   Open the Mass Invoicing form
    Organization: España - Región Norte
    Invoice Date: Today
    Business Partner: Any
    Template: and select the previously created template
   Select the products to use in the invoices.
    Select Cerveza Ale 0,5 L
    Quantity: 10
    Click Next
   Notice in the grid the price and total was automatic calculated:
    Product: Cerveza Ale 0,5 L
    Quantity: 10
    Price: 2.04
    Total: 20.40
   Click Generate and OK
   Notice that a new Invoice was generated (for instance 1000187) with a total 20.40 and a Grand Total of 24.68.
   Go to Sales Invoice window and select the previously created invoice.
       Check the Total Net Amount and Total Gross Amount are correct!
(0086279)
hgbot   
2016-05-06 16:02   
Repository: erp/pmods/org.openbravo.document.massinvoicing
Changeset: b0bb4dae12b5b416c8d8947ee84694786e687f41
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 06 15:56:30 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/b0bb4dae12b5b416c8d8947ee84694786e687f41 [^]

Fixes issue 32844: Fixed amounts when generating an invoice with Mass Invoicing

Fixed using the proposal solution in the issue description:
Setting the SummedLineAmount to 0 (instead of adding the line net amount to it) in the setInvoicePropertiesAdminMode function of InvoicePropertySetter class solves the problem.

---
M src/org/openbravo/document/massinvoicing/InvoicePropertySetter.java
---
(0086280)
hgbot   
2016-05-06 16:02   
Repository: erp/pmods/org.openbravo.document.massinvoicing
Changeset: 2b65dd6a70611f3dfb893d2e1007f456a542872d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri May 06 16:01:48 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/2b65dd6a70611f3dfb893d2e1007f456a542872d [^]

Related to issue 32844: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0086282)
aferraz   
2016-05-06 16:12   
Code review + Testing OK