Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0032840 | Modules | Multi-Dimensional Profit And Loss | public | 2016-05-03 14:17 | 2016-05-20 13:28 |
|
| Reporter | ngarcia | |
| Assigned To | AtulOpenbravo | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | aferraz |
| Support ticket | |
| OBNetwork customer | OBPS |
| Regression introduced in release | |
|
| Summary | 0032840: Generate Profit and Loss Fact Acct process creates records in obdpl_fact_acct_pl although there are no accounts defined in cube |
| Description | Generate Profit and Loss Fact Acct process creates records in obdpl_fact_acct_pl although there are no accounts defined in cube. The problem happens when the accountsFilter parameter is empty in the populatePAndLFactAcctTable function of the GenerateProfitAndLossFactAcctTable class. The account filter is not applied in the insert function then. |
| Steps To Reproduce | As system admin role:
Generate the Cube from 'DPL - P&L Template'
As group admin role:
Do not configure the Profit and Loss Accounts in 'Cube Definition - ... - Cube Report Dimension Element' tab
Schedule the Generate Profit and Loss Fact Acct background process
Go to OB Analytics window, select the DPL cube and add Account dimension in Columns and debitAmount measure in Rows
Check values are shown and they should not (the report should be empty as only the values for the accounts defined in the Cube Report Dimension Element should be shown) |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | design defect | 0032008 | | closed | Triage Omni OMS | Generate Profit And Loss Fact Acct should be incremental | | related to | defect | 0033020 | | closed | Sanjota | Process "Generate Profit and Loss Fact Act" fails in a cube with more than 1000 accounts |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-05-03 14:17 | ngarcia | New Issue | |
| 2016-05-03 14:17 | ngarcia | Assigned To | => Triage Finance |
| 2016-05-03 14:17 | ngarcia | Resolution time | => 1465509600 |
| 2016-05-03 14:17 | ngarcia | OBNetwork customer | => Yes |
| 2016-05-03 14:17 | ngarcia | Relationship added | related to 0032008 |
| 2016-05-09 11:08 | aferraz | Assigned To | Triage Finance => AtulOpenbravo |
| 2016-05-13 15:20 | AtulOpenbravo | Assigned To | AtulOpenbravo => ngarcia |
| 2016-05-13 15:20 | AtulOpenbravo | Status | new => feedback |
| 2016-05-13 16:59 | ngarcia | Status | feedback => new |
| 2016-05-13 16:59 | ngarcia | Assigned To | ngarcia => AtulOpenbravo |
| 2016-05-13 17:00 | ngarcia | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=12118#r12118 |
| 2016-05-17 11:32 | ngarcia | Issue Monitored: networkb | |
| 2016-05-17 15:42 | AtulOpenbravo | Status | new => scheduled |
| 2016-05-17 15:42 | AtulOpenbravo | Note Added: 0086500 | |
| 2016-05-17 15:45 | AtulOpenbravo | Note Edited: 0086500 | bug_revision_view_page.php?bugnote_id=0086500#r12138 |
| 2016-05-20 13:26 | hgbot | Checkin | |
| 2016-05-20 13:26 | hgbot | Note Added: 0086611 | |
| 2016-05-20 13:26 | hgbot | Status | scheduled => resolved |
| 2016-05-20 13:26 | hgbot | Resolution | open => fixed |
| 2016-05-20 13:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.financial.dimensionalpandlreport/rev/768b92293823bcddeb7ececb7fbe1fd723632c24 [^] |
| 2016-05-20 13:26 | hgbot | Checkin | |
| 2016-05-20 13:26 | hgbot | Note Added: 0086612 | |
| 2016-05-20 13:26 | hgbot | Checkin | |
| 2016-05-20 13:26 | hgbot | Note Added: 0086613 | |
| 2016-05-20 13:28 | aferraz | Review Assigned To | => aferraz |
| 2016-05-20 13:28 | aferraz | Note Added: 0086614 | |
| 2016-05-20 13:28 | aferraz | Status | resolved => closed |
| 2016-05-23 11:27 | aferraz | Relationship added | related to 0033020 |
|
Notes |
|
|
(0086500)
|
|
AtulOpenbravo
|
2016-05-17 15:42
(edited on: 2016-05-17 15:45) |
|
Test Plan A
- As system admin role:
Generate the Cube from 'DPL - P&L Template'
- As group admin role:
- Do not configure the Profit and Loss Accounts in 'Cube Definition - ... - Cube Report Dimension Element' tab
- Schedule the Generate Profit and Loss Fact Acct background process
- Check through database there are no records in the obanaly_cube_rep_dim_elem table. This is correct as we don't define them:
select count(*)
from obanaly_cube_rep_dim_elem
No records found.
- Check through database there are no record in the obdpl_fact_acct_pl table.
select count(*)
from obdpl_fact_acct_pl
No records found.
Test Plan B
- As system admin role:
Generate the Cube from 'DPL - P&L Template'
- As group admin role:
- Configure the Profit and Loss Accounts in
- Cube Definition = "DPL - P&L - F&B International Group US_A_US Dollar"
- Cube Report = "Multi-Dimensional Profit And Loss Process"
- Cube Report Dimension = "account - "
- Cube Report Dimension Elements
- Add 4005 Revenue, Show as Member and Children
- Add 4990 Total Revnue, Show as Member
- Schedule the Generate Profit and Loss Fact Acct background process.
- Check through database there are record in the obdpl_fact_acct_pl table.
select * from obdpl_fact_acct_pl
- Check following query
select distinct account_id
from obdpl_fact_acct_pl
2 records found for Revenue and Total Revenue Elements.
|
|
|
|
(0086611)
|
|
hgbot
|
|
2016-05-20 13:26
|
|
Repository: erp/pmods/org.openbravo.financial.dimensionalpandlreport
Changeset: 768b92293823bcddeb7ececb7fbe1fd723632c24
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 17 17:58:16 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.financial.dimensionalpandlreport/rev/768b92293823bcddeb7ececb7fbe1fd723632c24 [^]
Fixes issue 32840: Generate PL FactAcct process creates unnecessary records
Generate Profit and Loss Fact Acct process creates records in obdpl_fact_acct_pl although there are no accounts defined in cube
Check accountsfilter is empty or not prior to insert query
---
M src/org/openbravo/financial/dimensionalpandlreport/GenerateProfitAndLossFactAcctTable.java
---
|
|
|
|
(0086612)
|
|
hgbot
|
|
2016-05-20 13:26
|
|
|
|
|
(0086613)
|
|
hgbot
|
|
2016-05-20 13:26
|
|
|
|
|
|
|