Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032833Openbravo ERPA. Platformpublic2016-05-03 09:532016-06-17 19:37
Reportercaristu 
Assigned Toinigosanchez 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-04-21
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/diff/28d29f254c34/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java [^]
Triggers an Emergency PackNo
Summary0032833: Tree view is not working properly
DescriptionTree view is not working properly. When trying to set a category as child of another one, the following error is displayed in the log:

ERROR org.openbravo.service.datasource.DataSourceServlet - With your current role and settings, you cannot view this information
org.openbravo.base.exception.OBException: With your current role and settings, you cannot view this information
    at org.openbravo.service.datasource.TreeDatasourceService.checkEditDatasourceAccess(TreeDatasourceService.java:144)
    at org.openbravo.service.datasource.DataSourceServlet.doPut(DataSourceServlet.java:845)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:640)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:431)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:88)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:59)
    at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:148)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
....
Steps To Reproduce1) As F&B Group Admin, go to the [Product Category] window
2) Create a new category, and mark it as "Summary Level"
3) Try to move a category under the new category we have just created
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 00327283.0PR16Q3 closed inigosanchez Standard datasources should check entity access. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-03 09:53caristuNew Issue
2016-05-03 09:53caristuAssigned To => platform
2016-05-03 09:53caristuOBNetwork customer => No
2016-05-03 09:53caristuModules => Core
2016-05-03 09:53caristuTriggers an Emergency Pack => No
2016-05-03 09:56caristuRegression level => Pre packaging ( pi )
2016-05-03 09:56caristuRegression date => 2016-04-21
2016-05-03 09:56caristuRegression introduced in release => pi
2016-05-03 09:56caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/diff/28d29f254c34/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java [^]
2016-05-03 10:02alostaleRelationship addedcaused by 0032728
2016-05-03 10:03alostaleStatusnew => scheduled
2016-05-03 10:03alostaleAssigned Toplatform => inigosanchez
2016-05-05 09:42hgbotCheckin
2016-05-05 09:42hgbotNote Added: 0086199
2016-05-05 09:42hgbotStatusscheduled => resolved
2016-05-05 09:42hgbotResolutionopen => fixed
2016-05-05 09:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9db5d62f97acf30a86fc3f62bf4637a73666734b [^]
2016-05-05 10:28hgbotCheckin
2016-05-05 10:28hgbotNote Added: 0086205
2016-05-05 10:28inigosanchezReview Assigned To => alostale
2016-05-06 08:28alostaleNote Added: 0086231
2016-05-06 08:28alostaleStatusresolved => closed
2016-05-06 08:28alostaleFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087516
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087520

Notes
(0086199)
hgbot   
2016-05-05 09:42   
Repository: erp/devel/pi
Changeset: 9db5d62f97acf30a86fc3f62bf4637a73666734b
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu May 05 09:40:37 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9db5d62f97acf30a86fc3f62bf4637a73666734b [^]

Fixed issue 32833: Tree view is not working properly

When a node in tree view is moved, entity used to check
security access is null. This exception is shown:
OBSecurityException - Entity null is not readable by the user 100
The problem was that getEntity() method can't retrieves an entity.

Now it have been resolved by getting entity from table
id (referencedTableId).

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0086205)
hgbot   
2016-05-05 10:28   
Repository: erp/devel/pi
Changeset: b8e072f27fec379dae25a1bfce15876f47706ed9
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu May 05 10:24:40 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b8e072f27fec379dae25a1bfce15876f47706ed9 [^]

Related with issue 32833: Added a test case

It has been added a test case to cover a movement of a node
in a tree view. It has been simulated doing an update request.

---
M src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
---
(0086231)
alostale   
2016-05-06 08:28   
code reviewed

tested:
- with admin role
- with a role having access to only Product Category window
(0087516)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087520)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test