Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032831Retail ModulesDiscounts and Promotionspublic2016-05-03 08:492016-06-06 12:45
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032831: Consistency: Split discounts with non grouped products
DescriptionIf a non grouped product participates in a promotions, all promotions should be splitted.
Steps To ReproduceGo to the WEB POS
Add a GPS product. Check that a promotion of GPS_10_per is applied
Add another unit of GPS Product. Check that the promotion has been merged in the new line.
Go to the menu, and select Receipt discount option.
Apply to all lines a discount disc_5_var_per-5%. The promotions have been splitted, including the automated ones.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0036873 closed Retail BuyXGiftY products is not working in some scenarios with non grouped products 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-03 08:49jorge-garciaNew Issue
2016-05-03 08:49jorge-garciaAssigned To => jorge-garcia
2016-05-03 08:49jorge-garciaOBNetwork customer => No
2016-05-03 08:49jorge-garciaTriggers an Emergency Pack => No
2016-05-03 08:50jorge-garciaStatusnew => acknowledged
2016-05-03 09:11hgbotCheckin
2016-05-03 09:11hgbotNote Added: 0086144
2016-05-03 09:11hgbotStatusacknowledged => resolved
2016-05-03 09:11hgbotResolutionopen => fixed
2016-05-03 09:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a61130f8524d2351cc6c4eac7674e9fe59cb8032 [^]
2016-05-03 09:14hgbotCheckin
2016-05-03 09:14hgbotNote Added: 0086145
2016-06-01 10:37dmitry_mezentsevNote Added: 0086883
2016-06-06 12:45marvintmReview Assigned To => marvintm
2016-06-06 12:45marvintmStatusresolved => closed
2017-09-18 11:31jorge-garciaRelationship addedcauses 0036873

Notes
(0086144)
hgbot   
2016-05-03 09:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a61130f8524d2351cc6c4eac7674e9fe59cb8032
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 03 09:10:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a61130f8524d2351cc6c4eac7674e9fe59cb8032 [^]

Fixed issue 32831: Consistency: Split discounts with non grouped products

The discount engine calculates the promotions of the receipt merging all
product, without taking in consideration the check of the Grouped
product.

The solution is to don't merge the promotions of non grouped products and
calculate all promotions to apply in the receipt checking if the involved
products are non grouped products.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086145)
hgbot   
2016-05-03 09:14   
Repository: tools/automation/pi-mobile
Changeset: cbe85571760fd44834a94a1d18864a79e2c6b0c1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 03 09:05:46 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/cbe85571760fd44834a94a1d18864a79e2c6b0c1 [^]

Verifies issue 32831: Consistency: Split discounts with non grouped products

Added test SplitDiscountsForNonGroupedProducts.

---
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/discountsandpromotions/SplitDiscountsForNonGroupedProducts.java
---
(0086883)
dmitry_mezentsev   
2016-06-01 10:37   
Not closed for 29 days!!!
Please react ASAP.