Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032823Retail ModulesWeb POSpublic2016-04-20 15:342016-05-17 19:24
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1.2Fixed in VersionRR16Q1.2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-27
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
Triggers an Emergency PackNo
Summary0032823: Overall performance loss after clicking on receipt lines several times
DescriptionDuring the normal use of Web POS, after clicking on receipt lines several times, the overall performance of webpos operations slowly decreases.
The problem is that every time a line of the receipt is clicked, an event handler is being attached to the receipt line collection.
The performance problem comes from
Steps To ReproduceVerify on the following file https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/8f965cacdfb0/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js#l467 [^] that an event handler is being added on every tap() execution.
Add a console.log expression on the receiptLineSelected function on pointofsale.js.
Refresh the webpos, create a new ticket and add a line.
Verify that the first time the line is clicked, the log expression is printed once.
Verify that the second time the line is clicked, the log expression is printed twice.
Every time the line is clicked, the amount of log lines printed increases.
Proposed SolutionThe event handler that is added on toolbar-right.js should be added just once to prevent multiple executions of receiptLineSelected().
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032734 closed ranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
Attached Filespatch issue 32823 source posterminal 5595.patch (7,235) 2016-05-02 15:00
https://issues.openbravo.com/file_download.php?file_id=9349&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-02 12:15marvintmTypedefect => backport
2016-05-02 12:15marvintmTarget Version => RR16Q1.2
2016-05-02 15:00ranjith_qualiantech_comFile Added: issue 32823 source posterminal 5595.patch
2016-05-02 19:07hgbotCheckin
2016-05-02 19:07hgbotNote Added: 0086139
2016-05-02 19:07hgbotStatusscheduled => resolved
2016-05-02 19:07hgbotResolutionopen => fixed
2016-05-02 19:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1.2/org.openbravo.retail.posterminal/rev/bace6ebf408a8f096dc2bbd27a67b2c9902596a6 [^]
2016-05-17 19:24marvintmReview Assigned To => marvintm
2016-05-17 19:24marvintmStatusresolved => closed
2016-05-17 19:24marvintmFixed in Version => RR16Q1.2

Notes
(0086139)
hgbot   
2016-05-02 19:07   
Repository: retail/backports/3.0RR16Q1.2/org.openbravo.retail.posterminal
Changeset: bace6ebf408a8f096dc2bbd27a67b2c9902596a6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 02 22:35:46 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.2/org.openbravo.retail.posterminal/rev/bace6ebf408a8f096dc2bbd27a67b2c9902596a6 [^]

Fixes issue 32823 : Removed multi receipt line selection event

Added condition to display Toolbar buttons(+, -, quantity) on receipt line selection events

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---