Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032822Retail ModulesWeb POSpublic2016-04-20 15:342016-05-23 19:31
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2Fixed in VersionRR16Q2 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-27
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3305a61a5f7 [^]
Triggers an Emergency PackNo
Summary0032822: Overall performance loss after clicking on receipt lines several times
DescriptionDuring the normal use of Web POS, after clicking on receipt lines several times, the overall performance of webpos operations slowly decreases.
The problem is that every time a line of the receipt is clicked, an event handler is being attached to the receipt line collection.
The performance problem comes from
Steps To ReproduceVerify on the following file https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/annotate/8f965cacdfb0/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js#l467 [^] that an event handler is being added on every tap() execution.
Add a console.log expression on the receiptLineSelected function on pointofsale.js.
Refresh the webpos, create a new ticket and add a line.
Verify that the first time the line is clicked, the log expression is printed once.
Verify that the second time the line is clicked, the log expression is printed twice.
Every time the line is clicked, the amount of log lines printed increases.
Proposed SolutionThe event handler that is added on toolbar-right.js should be added just once to prevent multiple executions of receiptLineSelected().
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032734 closed ranjith_qualiantech_com Overall performance loss after clicking on receipt lines several times 
Attached Filespatch issue 32822 source posterminal 6250.patch (8,547) 2016-05-02 14:59
https://issues.openbravo.com/file_download.php?file_id=9347&type=bug
patch issue 32822 source mobile.core 2025.patch (2,373) 2016-05-02 15:00
https://issues.openbravo.com/file_download.php?file_id=9348&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-02 12:15marvintmTypedefect => backport
2016-05-02 12:15marvintmTarget Version => RR16Q2
2016-05-02 14:59ranjith_qualiantech_comFile Added: issue 32822 source posterminal 6250.patch
2016-05-02 15:00ranjith_qualiantech_comFile Added: issue 32822 source mobile.core 2025.patch
2016-05-02 18:56hgbotCheckin
2016-05-02 18:56hgbotNote Added: 0086137
2016-05-02 18:57hgbotCheckin
2016-05-02 18:57hgbotNote Added: 0086138
2016-05-02 18:57hgbotStatusscheduled => resolved
2016-05-02 18:57hgbotResolutionopen => fixed
2016-05-02 18:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/91fbb47d4873d68a924300e2cde207ebee599211 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/7d9222ca164073c657778102fad17c0176583f57 [^]
2016-05-23 19:31OrekariaReview Assigned To => Orekaria
2016-05-23 19:31OrekariaStatusresolved => closed
2016-05-23 19:31OrekariaFixed in Version => RR16Q2

Notes
(0086137)
hgbot   
2016-05-02 18:56   
Repository: retail/backports/3.0RR16Q2/org.openbravo.mobile.core
Changeset: 6bfa2a861958e503bf2688c37895b6585fb93cbe
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 02 22:25:16 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.mobile.core/rev/6bfa2a861958e503bf2688c37895b6585fb93cbe [^]

Related to issue 32822 : Removing Duplicate code in receipt line selection

Receipt line selection event has been added in posterminal editline.js

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
---
(0086138)
hgbot   
2016-05-02 18:57   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 7d9222ca164073c657778102fad17c0176583f57
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 02 22:14:02 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/7d9222ca164073c657778102fad17c0176583f57 [^]

Fixes issue 32822 : Removed multi receipt line selection event

Added condition to display Toolbar buttons(+, -, quantity) on receipt line selection events

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---