Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0032811Openbravo ERPA. Platformpublic2016-04-28 16:512016-06-17 19:37
lorenzofidalgo 
alostale 
immediateminoralways
closedfixed 
5
pi 
pi 
caristu
Google Chrome
Core
Automated tests
2016-04-18
pi
http://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
No
0032811: "Payment Method" filter is not set automatically in "Payment In" window || "Add Details" process but it must be set
It is not set by default "Payment Method" filter in "Add Details" process. That filter must be set with the same value than in the "Payment in" previously saved record.
I have tested this issue is reproducible in pi but it is working properly in main.
0-Login ERP as Openbravo//openbravo.
1-Using "F&B International Group Admin" role, go to "Payment In" window.
2-Create a new record in form view using the following data:
---
Received From: "Alimentos y Supermercados, S.A".
Payment Method: "Cheque".
Amount: "10.00".
---
Save that record.
3-Click "Add Details" process.
4-DEFECT: Realise it is not applied "Payment Method" filter but it must be applied by default in "Add Payment" process the same "Payment Method" filter than in the previously saved record.
No tags attached.
caused by feature request 0029771 closed naiaramartinez different attachment method infrastructure 
png PaymentMethodIsNotShownInPI.png (106,388) 2016-04-28 16:51
https://issues.openbravo.com/file_download.php?file_id=9335&type=bug
png

png FilterIsShownInMain.png (107,137) 2016-04-28 16:57
https://issues.openbravo.com/file_download.php?file_id=9336&type=bug
png
Issue History
2016-04-28 16:51lorenzofidalgoNew Issue
2016-04-28 16:51lorenzofidalgoAssigned To => gorkaion
2016-04-28 16:51lorenzofidalgoFile Added: PaymentMethodIsNotShownInPI.png
2016-04-28 16:51lorenzofidalgoWeb browser => Google Chrome
2016-04-28 16:51lorenzofidalgoModules => Core
2016-04-28 16:51lorenzofidalgoRegression level => Automated tests
2016-04-28 16:51lorenzofidalgoRegression introduced in release => pi
2016-04-28 16:51lorenzofidalgoTriggers an Emergency Pack => No
2016-04-28 16:55lorenzofidalgoWeb browserGoogle Chrome => Google Chrome
2016-04-28 16:55lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11900#r11900
2016-04-28 16:57lorenzofidalgoFile Added: FilterIsShownInMain.png
2016-04-29 07:58alostaleAssigned Togorkaion => alostale
2016-04-29 08:15alostaleReview Assigned To => caristu
2016-04-29 08:15alostaleWeb browserGoogle Chrome => Google Chrome
2016-04-29 08:15alostaleRegression date => 2016-04-18
2016-04-29 08:15alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/82f27ac1b1497b3a82646b140ab1b6e048f2b766 [^]
2016-04-29 08:16alostaleRelationship addedcaused by 0029771
2016-04-29 08:20hgbotCheckin
2016-04-29 08:20hgbotNote Added: 0086069
2016-04-29 08:20hgbotCheckin
2016-04-29 08:20hgbotNote Added: 0086070
2016-04-29 08:20hgbotStatusnew => resolved
2016-04-29 08:20hgbotResolutionopen => fixed
2016-04-29 08:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/47ec70154e1f7551d122e1fe92c487b2473e6c85 [^]
2016-04-29 08:55alostaleNote Added: 0086071
2016-04-29 15:34caristuNote Added: 0086088
2016-04-29 15:34caristuStatusresolved => closed
2016-04-29 15:34caristuFixed in Version => pi
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087500
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087501

Notes
(0086069)
hgbot   
2016-04-29 08:20   
Repository: erp/devel/pi
Changeset: 40651550f0f46a630f2d79301987833824bf9bd8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 29 08:14:20 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/40651550f0f46a630f2d79301987833824bf9bd8 [^]

related to bug 32811: show log when exception in setting filter expression

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpression.java
---
(0086070)
hgbot   
2016-04-29 08:20   
Repository: erp/devel/pi
Changeset: 47ec70154e1f7551d122e1fe92c487b2473e6c85
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 29 08:20:03 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/47ec70154e1f7551d122e1fe92c487b2473e6c85 [^]

fixed bug 32811: "Payment Method" filter is not set automatically in Add Details

  When openeing Add Details process from Payment In window, Payment Method should
  be filtered by default according the method selected in the window. This filter
  was missing.

  The problem was due a refactor, now parameters are fixed at the begining of the
  method, this fix returns a new object instead of the original one, if new params
  are to be added, they need to be done in the new object rather than in the orginal
  one

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java
---
(0086071)
alostale   
2016-04-29 08:55   
Case already automated in: https://ci.openbravo.com/view/qa/job/qa-pi-aprinreg-pgsql/227/ [^]
(0086088)
caristu   
2016-04-29 15:34   
Verified: default filter on Payment Method appears

Fixed on on pi@47ec70154e1f
(0087500)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087501)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test