Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032809Openbravo ERPY. DBSourceManagerpublic2016-04-28 14:082016-05-09 18:33
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032809: ensure proper rev.id info in dbsourcemanager.jar
DescriptionWhen dbsourcemanager.jar is generated a rev.id file is included containing mercurial's revision id for current changeset in order to make easier tracking between committed jar and actual sources.

There are cases when this info is not correct/accurate:
* If mercurial is not installed
* When there are uncommitted changes
* When build.jar task is used instead of jar, it doesn't include rev.id file

In all these cases the task shouldn't complete to guarantee a proper rev.id.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0034368 acknowledged Triage Platform Base ant jar should fail if mercurial detects unknown java files 
blocks feature request 0036471 closed alostale allow to bypass local changes build prevention 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-28 14:08alostaleNew Issue
2016-04-28 14:08alostaleAssigned To => platform
2016-04-28 14:08alostaleModules => Core
2016-04-28 14:08alostaleTriggers an Emergency Pack => No
2016-04-28 14:08alostaleAssigned Toplatform => alostale
2016-04-28 14:08alostaleReview Assigned To => AugustoMauch
2016-04-28 14:10hgbotCheckin
2016-04-28 14:10hgbotNote Added: 0086055
2016-04-28 14:10hgbotStatusnew => resolved
2016-04-28 14:10hgbotResolutionopen => fixed
2016-04-28 14:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/dc2cd045e1fd5077594f7dea250a05f9383d2d36 [^]
2016-05-09 18:33AugustoMauchNote Added: 0086326
2016-05-09 18:33AugustoMauchStatusresolved => closed
2016-05-09 18:33AugustoMauchFixed in Version => 3.0PR16Q3
2016-11-02 17:54AugustoMauchRelationship addedrelated to 0034368
2017-07-12 11:21alostaleRelationship addedblocks 0036471

Notes
(0086055)
hgbot   
2016-04-28 14:10   
Repository: erp/devel/dbsm-main
Changeset: dc2cd045e1fd5077594f7dea250a05f9383d2d36
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 28 14:09:39 2016 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/dc2cd045e1fd5077594f7dea250a05f9383d2d36 [^]

fixes 32809: ensure proper rev.id info in dbsourcemanager.jar

  Include always rev.id info in generated jar:
    - If there is no mercurial, fail
    - If there are local changes, fail
    - build.jar now includes rev.id file

---
M build.xml
---
(0086326)
AugustoMauch   
2016-05-09 18:33   
Code reviewed and verified in [1]@dc2cd045e1fd

[1] https://code.openbravo.com/erp/devel/dbsm-main [^]