Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032780Openbravo ERP07. Sales managementpublic2016-04-14 14:222016-04-26 17:27
Reporterngarcia 
Assigned Toplatform 
PriorityimmediateSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q1 
Target Version3.0PR16Q1.1Fixed in Version3.0PR16Q1.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032780: Wrong Total Gross Amount, Total Net Amount and Tax information is obtained in order and invoices
DescriptionWrong Total Gross Amount, Total Net Amount and Tax information is obtained in order and invoices. Before 3.0PR15Q4 the problem could be solved by reactivating and processing the document. After the following commit

https://issues.openbravo.com/view.php?id=28366 [^]

the only option is to delete the whole document (header and lines)
Steps To Reproduce0. Login as group admin role
1. Create a Sales Order
2. Add a line to it and click on Book button
3. Before booking it keep the mouse in the New toolbar button
4. Press enter and at the same time click on the New button sometimes
    -> ERROR 1: Check the new header is created with the values of the old record in the status bar fields
            * Status: Booked
            * Total Amounts: The values in previous document
6. Fill in mandatory fields in header
7. Save header. See different behavior depending on the version:
   7.1. 3.0PR15Q4-3.0PR16Q1
     -> ERROR 2: status bar values:
          * Status: Draft (OK)
          * Total Amounts: Previous values are kept (ERROR)
   7.2. >=3.0PR16Q2
      -> OK: status bar values are reset:
          * Status: Draft
          * Total Amounts: 0


Error 7.2 is caused because in the save request numeric values are sending an outdated textualValue property, this property was removed in 16Q2 by fix for 0031901.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032668 closed alostale Wrong Total Gross Amount, Total Net Amount and Tax information is obtained in order and invoices 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-26 09:50alostaleTypedefect => backport
2016-04-26 09:50alostaleTarget Version => 3.0PR16Q1.2
2016-04-26 10:50alostaleTarget Version3.0PR16Q1.2 => 3.0PR16Q1.1
2016-04-26 11:04alostaleReview Assigned To => caristu
2016-04-26 11:43priyamIssue Monitored: priyam
2016-04-26 15:55hgbotCheckin
2016-04-26 15:55hgbotNote Added: 0085991
2016-04-26 15:55hgbotCheckin
2016-04-26 15:55hgbotNote Added: 0085992
2016-04-26 15:55hgbotStatusscheduled => resolved
2016-04-26 15:55hgbotResolutionopen => fixed
2016-04-26 15:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1.1/rev/29fa7f43f9da7ebc8f10269b9ee5754a4dd991d7 [^]
2016-04-26 17:27caristuNote Added: 0085998
2016-04-26 17:27caristuStatusresolved => closed
2016-04-26 17:27caristuFixed in Version => 3.0PR16Q1.1

Notes
(0085991)
hgbot   
2016-04-26 15:55   
Repository: erp/backports/3.0PR16Q1.1
Changeset: ebfbe10490c0bc4e876b3d66524fc926850fc97b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Apr 26 10:50:48 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.1/rev/ebfbe10490c0bc4e876b3d66524fc926850fc97b [^]

related to bug 32780: wrong values displayed in status bar on record creation

  When a new record is created just after processing a previous one, status bar
  displayed valued of the previous record instead of being in New mode.

  Fixed by forcing status bar reset on FIC response for NEW.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0085992)
hgbot   
2016-04-26 15:55   
Repository: erp/backports/3.0PR16Q1.1
Changeset: 29fa7f43f9da7ebc8f10269b9ee5754a4dd991d7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Apr 26 10:54:46 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.1/rev/29fa7f43f9da7ebc8f10269b9ee5754a4dd991d7 [^]

fixed bug 32780: wrong amounts on new record just after processing another one

  When a new record was created (ie. for Order or Invoice) just after completing
  a previous one, status bar values could get not updated. In case of numeric values
  they preserved an obsolete textual value, which makes to update to previous value
  when saving, even if the status bar reflects the new state.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0085998)
caristu   
2016-04-26 17:27   
Code review + testing OK, after following the steps:
- The status bar is in new status
- The new header is created with the new values (old values from previous order are not kept)