Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032769Openbravo ERPA. Platformpublic2016-04-22 14:022016-06-17 19:37
Reportermrecasens 
Assigned Toinigosanchez 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032769: «Yes / No» values in «Payment In» and «Payment Out» export to CSV
DescriptionThere's a demand regarding boolean values in «Payment In» and «Payment Out» forms.
In the backoffice they appear as Yes / No.
When exported to CSV, they are seen as boolean values (True / False) or as the cllient sofware that eventually opens the CSV may want to interpret them.
Steps To ReproduceOpen Payment In window in back office
Click on "Export to spreadsheet" button
Check that "Is porcessed", "Is dummy" are seen as true / false values.
Proposed SolutionProposed solution is to create a new preference:
* If not set (default), you get the current behaviour
* IF set, bolean type values will be exported translated to the sessions language, i.e., Yes / No
Additional Information
TagsSER-QA
Relationships
Attached Filespng image (16).png (112,209) 2016-04-22 14:06
https://issues.openbravo.com/file_download.php?file_id=9313&type=bug
png

png image (17).png (49,603) 2016-04-22 14:06
https://issues.openbravo.com/file_download.php?file_id=9314&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-04-22 14:02mrecasensNew Issue
2016-04-22 14:02mrecasensAssigned To => Triage Finance
2016-04-22 14:02mrecasensModules => Core
2016-04-22 14:02mrecasensTriggers an Emergency Pack => No
2016-04-22 14:04mrecasensNote Added: 0085898
2016-04-22 14:06mrecasensFile Added: image (16).png
2016-04-22 14:06mrecasensFile Added: image (17).png
2016-04-22 14:06mrecasensTag Attached: SER-QA
2016-05-02 17:11amayavicenteAssigned ToTriage Finance => alostale
2016-05-02 17:11amayavicentePriorityurgent => high
2016-05-02 17:11amayavicenteSeveritymajor => minor
2016-05-02 17:11amayavicenteCategoryF. Localization => A. Platform
2016-05-02 17:11amayavicenteTypedefect => feature request
2016-05-03 07:46alostaleTarget Version => 3.0PR16Q3
2016-05-03 07:46alostaleStatusnew => scheduled
2016-05-03 07:46alostaleAssigned Toalostale => inigosanchez
2016-05-10 13:44inigosanchezNote Added: 0086351
2016-05-10 14:06hgbotCheckin
2016-05-10 14:06hgbotNote Added: 0086353
2016-05-10 14:06hgbotStatusscheduled => resolved
2016-05-10 14:06hgbotResolutionopen => fixed
2016-05-10 14:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/96ed0a3a9e301ce8112d9fec1c1909a2092566a4 [^]
2016-05-10 14:07inigosanchezReview Assigned To => alostale
2016-05-11 11:47inigosanchezIssue Monitored: caristu
2016-05-11 11:47inigosanchezReview Assigned Toalostale => caristu
2016-05-12 18:13caristuNote Added: 0086428
2016-05-12 18:13caristuStatusresolved => new
2016-05-12 18:13caristuResolutionfixed => open
2016-05-15 21:28inigosanchezStatusnew => scheduled
2016-05-15 21:30hgbotCheckin
2016-05-15 21:30hgbotNote Added: 0086450
2016-05-16 08:51inigosanchezStatusscheduled => resolved
2016-05-16 08:51inigosanchezFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/96ed0a3a9e301ce8112d9fec1c1909a2092566a4 [^] => https://code.openbravo.com/erp/devel/pi/rev/9f91486010893c5fcb7d435bf69391037d0d3064 [^]
2016-05-16 08:51inigosanchezResolutionopen => fixed
2016-05-16 10:37caristuNote Added: 0086457
2016-05-16 10:37caristuStatusresolved => closed
2016-05-16 10:37caristuFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087530
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087539

Notes
(0085898)
mrecasens   
2016-04-22 14:04   
In proposed solution, when the preference is set, results should be "Sí / No" if language is set to Spanish, "Oui / Non" in French, etc.
(0086351)
inigosanchez   
2016-05-10 13:44   
Manual testing plan. "Localization pack Spain (España)" module is installed. (Spanish langguage is actived)

* Export to CSV a window (Assets) with Yes/No column:
> Preference Y - W:Empty > "Sí/NO" values are exported.
> Preference Y - W:Assets > "Sí/NO" values are exported.
> Preference Y - W:Order > "True/False" values are exported.
> Preference N > "True/False" values are exported.
> Preference Undefined > "True/False" values are exported.

* Export to CSV a HQL Widget with Yes/No column:
> Preference Y - W:Assets > "True/False" values are exported.
> Preference Y - W:Empty > "Sí/No" values are exported.
> Preference N > "True/False" values are exported.
> Preference Undefined > "True/False" values are exported.
(0086353)
hgbot   
2016-05-10 14:06   
Repository: erp/devel/pi
Changeset: 96ed0a3a9e301ce8112d9fec1c1909a2092566a4
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue May 10 14:05:21 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/96ed0a3a9e301ce8112d9fec1c1909a2092566a4 [^]

Fixed issue 32769: YesNo reference should be translatable in export to CSV

A new preference 'AllowExportCSV_YesNoTranslated' has been created to allow
than boolean type values will be exported translated to the sessions language,
i.e., Sí/No, instead of current behaviour, i.e., True/False. If not set (default)
this new preference, you get the current behaviour.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0086428)
caristu   
2016-05-12 18:13   
Reopened in order to apply code review changes.
(0086450)
hgbot   
2016-05-15 21:30   
Repository: erp/devel/pi
Changeset: 9f91486010893c5fcb7d435bf69391037d0d3064
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Sun May 15 21:28:20 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9f91486010893c5fcb7d435bf69391037d0d3064 [^]

Related with issue 32769: Codereview improvements.

---
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0086457)
caristu   
2016-05-16 10:37   
Code review + testing OK.

Updated wiki page: http://wiki.openbravo.com/wiki/Preference#Preferences_Definition [^]
(0087530)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087539)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test