Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032718Retail ModulesWeb POSpublic2016-04-19 17:582016-05-30 10:02
Reporteradrianromero 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032718: Using the barcode scanner, the selection of services can be bypassed without pressing *Continue*
DescriptionIf you scan several products including one with a mandatory service, the check (clicking on "Continue" to confirm we do not want the service) is bypassed.

It should not be possible to scan the next product if we didn´t click previously on "continue"
Steps To Reproduce* Open the web POS
* Add a product with mandatory services associated to the receipt. Verify the list of mandatory services is displayed and the "Continue" button
* Use the scanner to add a different product or type the barcode of a different product followed by "Enter"

Verify the product is added. The services selection has been bypassed without pressing "Continue". This is wrong.
Proposed SolutionThe attached patch implements does not allow to scan new products if the list of mandatory services is displayed.
Additional Information
TagsSER-QA
Relationships
related to defect 0032913 closed mario_castello Test I32718_DisabledEnterEventinServiceSelector is failing in try-retail 
Attached Filesdiff 903.diff (942) 2016-04-19 18:00
https://issues.openbravo.com/file_download.php?file_id=9284&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-04-19 17:58adrianromeroNew Issue
2016-04-19 17:58adrianromeroAssigned To => Retail
2016-04-19 17:58adrianromeroOBNetwork customer => Yes
2016-04-19 17:58adrianromeroTriggers an Emergency Pack => No
2016-04-19 17:58adrianromeroTag Attached: SER-QA
2016-04-19 17:59adrianromeroProposed Solution updated
2016-04-19 18:00adrianromeroFile Added: 903.diff
2016-04-19 18:56OrekariaStatusnew => acknowledged
2016-04-25 12:36adrianromeroResolution time => 1462140000
2016-05-04 17:17jorge-garciaStatusacknowledged => scheduled
2016-05-04 17:17jorge-garciaAssigned ToRetail => jorge-garcia
2016-05-10 10:39jorge-garciaRelationship addedrelated to 0032913
2016-05-10 10:42hgbotCheckin
2016-05-10 10:42hgbotNote Added: 0086338
2016-05-10 10:42hgbotStatusscheduled => resolved
2016-05-10 10:42hgbotResolutionopen => fixed
2016-05-10 10:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/69275dc71ec47ed99a27e26c71fa058f7fa54e9a [^]
2016-05-10 10:43hgbotCheckin
2016-05-10 10:43hgbotNote Added: 0086339
2016-05-16 13:32marvintmNote Added: 0086465
2016-05-16 13:32marvintmStatusresolved => new
2016-05-16 13:32marvintmResolutionfixed => open
2016-05-16 13:32marvintmStatusnew => scheduled
2016-05-25 09:04hgbotCheckin
2016-05-25 09:04hgbotNote Added: 0086716
2016-05-25 09:04hgbotStatusscheduled => resolved
2016-05-25 09:04hgbotResolutionopen => fixed
2016-05-25 09:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/69275dc71ec47ed99a27e26c71fa058f7fa54e9a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3217d3a864f644225ac8cd9f6f23176bbf07280 [^]
2016-05-30 10:02marvintmReview Assigned To => marvintm
2016-05-30 10:02marvintmStatusresolved => closed

Notes
(0086338)
hgbot   
2016-05-10 10:42   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 69275dc71ec47ed99a27e26c71fa058f7fa54e9a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu May 05 11:04:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/69275dc71ec47ed99a27e26c71fa058f7fa54e9a [^]

Fixed issue 32718: Using the barcode scanner, the selection of services can
be bypassed without pressing *Continue*

A new condition has been added to manage the Enter event in the Service
selection tab.

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0086339)
hgbot   
2016-05-10 10:43   
Repository: tools/automation/pi-mobile
Changeset: 563a8a20b7fd350cf0de99370ddb7dfe7514f734
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 10 10:42:02 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/563a8a20b7fd350cf0de99370ddb7dfe7514f734 [^]

Verifies issue 32718: Using the barcode scanner, the selection of services can
be bypassed without pressing *Continue*

Added test I32718_DisabledEnterEventinServiceSelector.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/externalInput/I32718_DisabledEnterEventinServiceSelector.java
---
(0086465)
marvintm   
2016-05-16 13:32   
There are two problems with this fix:
- It affects only the iOS flow
- It creates a reference from mobile.core module to an attribute from the Web POS

The solution should be different: instead of detecting the event in ob-keyboard, another event should be used to disable the scanner when this window is opened, and enable it when it's closed.
(0086716)
hgbot   
2016-05-25 09:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d3217d3a864f644225ac8cd9f6f23176bbf07280
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 16 15:50:09 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d3217d3a864f644225ac8cd9f6f23176bbf07280 [^]

Fixed issue 32718: Using the barcode scanner, the selection of services can
be bypassed without pressing *Continue*

The solution is to disable the barcode scanner in that tab and enable it
afterwards.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---