Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0032709Openbravo ERP07. Sales managementpublic2016-04-19 12:462017-09-28 15:44
yogaskarnik 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
pi 
3.0PR16Q3 
aferraz
Core
No
0032709: Sales Invoice - Invoice Term=Immediate does not create link to Good Shipment in Sales Invoice
Sales Invoice - Invoice Term=Immediate does not create link to Good Shipment in Sales Invoice
1.Login to erp_pi_pgsql
2.Create a Sales Order with Invoice Term=Immediate
3.Navigate to Create Shipment from Orders
4.Filter the existing Sales Order created and click on Process button to create goods shipment
5.Navigate to Create Invoice from Orders
6.Filter the existing Sales Order created and click on Process button to create sales invoice
7.Observe that the Sales Invoice Line is not associated to the the Goods Shipment Line (This link is there for other Sales Invoice Terms)

NOTE: This is causing the Sales Invoice Dimensional Report to show 0 cost for invoices
No tags attached.
related to defect 0024355 closed AtulOpenbravo "Good Shipment Line" field information is not filled when creating POS Order with Invoice Terms=Immediate 
related to defect 0032670 closed collazoandy4 "Good Shipment Line" field information is not filled in Sales Invoice Line when processing On Credit Order 
related to defect 0028685pi closed reinaldoguerra Goods shipment and invoice relationship not created when launching "Create shipments from orders" form. 
related to design defect 0036971 new Triage Omni OMS Different behaviour in Create lines From or Create Invoices From Orders processes if invoice terms are Immediate 
related to defect 0032938 closed AtulOpenbravo It is necessary a script to add the 1-1 relation between sales invoice line and goods shipment line 
related to design defect 0033042 new Triage Omni OMS Partially shipped Goods Shipment Line is linked to completely invoiced Sales Invoice Line 
Issue History
2016-04-19 12:46yogaskarnikNew Issue
2016-04-19 12:46yogaskarnikAssigned To => Triage Finance
2016-04-19 12:46yogaskarnikModules => Core
2016-04-19 12:46yogaskarnikResolution time => 1463349600
2016-04-19 12:46yogaskarnikTriggers an Emergency Pack => No
2016-04-21 11:13aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-05-05 07:38AtulOpenbravoStatusnew => scheduled
2016-05-05 11:07ngarciaIssue Monitored: ngarcia
2016-05-05 20:09AtulOpenbravoNote Added: 0086225
2016-05-06 06:12AtulOpenbravoNote Edited: 0086225bug_revision_view_page.php?bugnote_id=0086225#r11987
2016-05-09 11:38psanjuanNote Added: 0086303
2016-05-09 13:02psanjuanNote Edited: 0086225bug_revision_view_page.php?bugnote_id=0086225#r12022
2016-05-09 13:03psanjuanNote Edited: 0086225bug_revision_view_page.php?bugnote_id=0086225#r12023
2016-05-09 13:06psanjuanNote Edited: 0086225bug_revision_view_page.php?bugnote_id=0086225#r12024
2016-05-09 13:07psanjuanNote Edited: 0086225bug_revision_view_page.php?bugnote_id=0086225#r12025
2016-05-09 13:18psanjuanNote Added: 0086310
2016-05-09 13:19psanjuanNote Edited: 0086310bug_revision_view_page.php?bugnote_id=0086310#r12027
2016-05-09 13:28psanjuanNote Edited: 0086310bug_revision_view_page.php?bugnote_id=0086310#r12028
2016-05-09 13:35psanjuanNote Edited: 0086310bug_revision_view_page.php?bugnote_id=0086310#r12029
2016-05-09 13:40psanjuanNote Added: 0086311
2016-05-11 13:16aferrazRelationship addedrelated to 0024355
2016-05-11 13:16aferrazRelationship addedrelated to 0032670
2016-05-11 13:16aferrazRelationship addedrelated to 0028685
2016-05-11 13:56aferrazSeveritymajor => minor
2016-05-11 13:57aferrazNote Added: 0086377
2016-05-11 13:58aferrazFile Added: 32709.diff
2016-05-12 10:01ngarciaRelationship addedblocks 0032938
2016-05-12 10:01ngarciaRelationship deletedblocks 0032938
2016-05-12 10:02ngarciaRelationship addedrelated to 0032938
2016-05-23 12:33maitePrioritynormal => urgent
2016-05-23 12:33maiteSeverityminor => major
2016-05-23 12:33maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12200#r12200
2016-05-23 20:11hgbotCheckin
2016-05-23 20:11hgbotNote Added: 0086688
2016-05-23 20:11hgbotStatusscheduled => resolved
2016-05-23 20:11hgbotResolutionopen => fixed
2016-05-23 20:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8cbfd762b584f2107aef10ec5d7c1e3f727f6f28 [^]
2016-05-23 20:11aferrazFile Deleted: 32709.diff
2016-05-23 20:11aferrazNote Deleted: 0086377
2016-05-23 20:12aferrazReview Assigned To => aferraz
2016-05-23 20:12aferrazNote Added: 0086689
2016-05-23 20:12aferrazStatusresolved => closed
2016-05-23 20:12aferrazFixed in Version => 3.0PR16Q3
2016-05-23 20:12aferrazNote Edited: 0086689bug_revision_view_page.php?bugnote_id=0086689#r12215
2016-05-25 09:01AtulOpenbravoRelationship addedrelated to 0033042
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087558
2017-09-28 15:44ngarciaRelationship addedrelated to 0036971

Notes
(0086225)
AtulOpenbravo   
2016-05-05 20:09   
(edited on: 2016-05-09 13:07)
Test Plan A
- Login as F&B International Group Admin
- Create a Sales Order with Invoice Term=Immediate. Add one line for any product.
- Navigate to Create Shipment from Orders.
- Filter existing Sales Order created and click on Process button to create goods shipment.
- Navigate to Create Invoice from Orders
- Filter existing Sales Order created, Invoice Date = Today's Date and click on Process button to create sales invoice.
- Check that the Sales Invoice Line is associated with the Goods Shipment Line.

Repeat same test as above for a sales order including more than one line. Check that each invoice line is related to the corresponding goods shipment line.

Repeat same test as above by using "After Delivery" Invoice Terms.

Test Plan B

- Create new POS Order for any BP ensuring that Invoice Terms=Immediate.
- Add any line and process. Shipment and Invoice are automatically created
- Navigate to Sales Invoice Line and verify that, in More Information section, "Good Shipment Line" information is properly shown.

Repeat same test as above for a POS order including more than one line. Check that each invoice line is related to the corresponding goods shipment line.

Repeat same test as above by using "After Delivery" Invoice Terms.

(0086303)
psanjuan   
2016-05-09 11:38   
Issue verified.
(0086310)
psanjuan   
2016-05-09 13:18   
(edited on: 2016-05-09 13:35)
Test plan above verified.


Additional test:

Test Plan C

- Login as F&B International Group Admin.

- Create a Sales Order for F&B España org, BP Alimentos.
Add two lines for more than one unit of any product:
* Agua sin Gas 1L -> 10 units
* Bebida Energética 0.5L-> 11 units.
- Book the order.

- Navigate to Goods Shipment and create a new one for BP Alimentos by using "Create Lines From" select the two order lines of the sales order created above. Enter a storage bin location. Press OK.

- go to lines and edit the Quantity as below:
* Agua sin Gas 1L -> 5 units
* Bebida Energética 0.5L-> 3 units.
- Complete the Shipment.

- Navigate to Create Invoices from Order, select above Order, Invoice Date = Today's Date, Process it.

- Check that Sales Invoice is created with 2 lines and below quantity (full quantity):
* Agua sin Gas 1L -> 10 units
* Bebida Energética 0.5L-> 11 units.
- Check that for each line of the invoice, "Goods Shipment Line" is empty.

- Navigate to Create Shipment from Order, select above Order and process it.

- Check that a Shipment has been created for the remaining quantity:

* Agua sin Gas 1L -> 5 units
* Bebida Energética 0.5L-> 8 units.

- Navigate once more to the Sales Invoice, check for each line that "Goods Shipment Line" field is empty as there are more than one goods shipment related for the line.

Test Plan D.

- Go to sales order window and create a new one for BP Alimentos, Invoice Terms = Inmediate. Add two lines. Book the order
- Go to Goods Shipment window and create a new one. Ship first order line completely by using Create Lines From. Complete shipment.
- Go to Create shipments from orders, select the order and process. Verify that a new goods shipment has been created with the second order line.
- Go to Create Invoices from orders and select the order, enter today's date as invoice date and process.
- Go to sales invoice window and search by the new invoice created. Check that each invoice line is related to the corresponding goods shipment.

Repeat same test as above for Invoice Terms = After Delivery. Check that two invoices are created, the lines of those invoices are related to the corresponding goods shipment.

Test Plan E.

- Go to sales order window and create a new order for BP Alimentos. Add two lines of any product, more than 1 unit. Book the order. Invoice Terms = Inmediate.
- Go to Goods Shipment window and receipt part of the first order line previously created by using Create lines from option. Complete the shipment.
- Go to Create Shipments from orders and select the order. Process.
- Go to the new shipment created and check that this shipment includes remaining part of first order line and full quantity of second order line.
- Go to Create Invoices from orders, select the order, enter an invoice date and process.
- Go to the sales invoice created, check that "Goods Shipment Line" field is empty for the first line (as there are more than one shipment related) and filled in for the second invoice line (as there is only one shipment related).

Repeat same test as above for Invoice Terms = After Delivery.

(0086311)
psanjuan   
2016-05-09 13:40   
Test Plan above verified.

Issue can be code reviewed and closed.
(0086688)
hgbot   
2016-05-23 20:11   
Repository: erp/devel/pi
Changeset: 8cbfd762b584f2107aef10ec5d7c1e3f727f6f28
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu May 05 23:32:13 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8cbfd762b584f2107aef10ec5d7c1e3f727f6f28 [^]

Fixes issue 32709: Create link to Good Shipment in Create Invoice from Orders

Fully shipped lines linked with invoice lines not only in case of POS Order but in any case

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0086689)
aferraz   
2016-05-23 20:12   
Code review OK

(0087558)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test