Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032705Openbravo ERPB. User interfacepublic2016-04-19 10:252016-06-17 19:37
Reportergorkaion 
Assigned Togorkaion 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-04-18
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/579d01b25a3b [^]
Triggers an Emergency PackNo
Summary0032705: attachment button in toolbar is not updated
DescriptionOn form view editing a record with attachments.

When navigating to the next record using the "Go to next record" button the status of the attachment button is not updated if the new loaded record does not have attachments.
Steps To Reproduce1. Go to Product Window.
2. Edit a product and add a new attachment.
3. Check that the attachment button of the toolbar changes to the "show attachments"
4. Click on "Go to next record"
5. Check that the button is still in "show attachments" mode.
6. Open the attachment section.
7. Check that there isn't any attachment and the toolbar button is properly updated.
Proposed Solutionfix javascript issue when processing FIC return.
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0029771 closed naiaramartinez different attachment method infrastructure 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-19 10:25gorkaionNew Issue
2016-04-19 10:25gorkaionAssigned To => gorkaion
2016-04-19 10:25gorkaionModules => Core
2016-04-19 10:25gorkaionRegression level => Pre packaging ( pi )
2016-04-19 10:25gorkaionRegression date => 2016-04-18
2016-04-19 10:25gorkaionRegression introduced in release => pi
2016-04-19 10:25gorkaionRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/579d01b25a3b [^]
2016-04-19 10:25gorkaionTriggers an Emergency Pack => No
2016-04-19 10:29hgbotCheckin
2016-04-19 10:29hgbotNote Added: 0085738
2016-04-19 10:29hgbotStatusnew => resolved
2016-04-19 10:29hgbotResolutionopen => fixed
2016-04-19 10:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/095c84839a3e113ba83b3369fc06d2ec1d8041ee [^]
2016-04-19 10:31gorkaionReview Assigned To => alostale
2016-04-19 10:32alostaleRelationship addedcaused by 0029771
2016-04-22 09:33alostaleNote Added: 0085873
2016-04-22 09:33alostaleStatusresolved => closed
2016-04-22 09:33alostaleFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087465

Notes
(0085738)
hgbot   
2016-04-19 10:29   
Repository: erp/devel/pi
Changeset: 095c84839a3e113ba83b3369fc06d2ec1d8041ee
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Apr 19 10:28:30 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/095c84839a3e113ba83b3369fc06d2ec1d8041ee [^]

Fixed issue 32705.check that attachmentCount is a number

Change the if clause to check that attachmentCount is a number instead of just
if (data.attachmentCount) {}.
In this case when count is 0 the if clause should return true but JavaScript
considers 0 as false.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0085873)
alostale   
2016-04-22 09:33   
code reviewed

tested in form and grid view
(0087465)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test