Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032700Retail ModulesWeb POSpublic2016-04-19 09:072016-06-07 17:52
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2Fixed in VersionRR16Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2015-12-15
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed7f8734ef3bb2cd7eb6b310facea36835c6d9cb [^]
Triggers an Emergency PackNo
Summary0032700: Firm quotation doesn't work when creating a order from a quotation
DescriptionFirm quotation doesn't work when creating a order from a quotation.
Steps To Reproduce1 - Login in the WEBPOS
 1.1 - Go to the menu and click on Create Quotation
 1.2 - Go to the search tap and serach Crampons 10 points.
 1.3 - Add three units of that product and check a discount price_adjust_chrampons_30_eur is applied.
 1.4 - Go to the menu and click on Receipt discounts. Apply a disc_fixed_5_euro discount to the line.
 1.5 - Check both discounts are applied, one of -5€ and the other one -24.69
 1.6 - Click the pay button and check the quotation status is Under Evaluation
 1.7 - Close the ticket and search the Quotation from the menu
 1.8 - Go to the menu and click on the Create Sales Order. A popup is shown:
   1.8.1 - If Firm Quotation is checked, when the Create Order button is clicked, promotions don't have to change. See attached image[1].
   1.8.2 - If Firm Quotation is uncheked, when the Create Order button is clicked, promotions and prices must be updated (only automatic promotions for the products must be shown). See attached image[2].
Proposed SolutionA diff is attached with the propose solution.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032699 closed shivum039 Firm quotation doesn't work when creating a order from a quotation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-19 09:10jorge-garciaTypedefect => backport
2016-04-19 09:10jorge-garciaTarget Version => RR16Q2
2016-04-28 20:12hgbotCheckin
2016-04-28 20:12hgbotNote Added: 0086062
2016-04-28 20:12hgbotStatusscheduled => resolved
2016-04-28 20:12hgbotResolutionopen => fixed
2016-04-28 20:12hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/1b6a0f06be28fefc7874fdc75963d0b4a92b09e5 [^]
2016-05-24 18:53OrekariaNote Added: 0086715
2016-05-24 18:53OrekariaStatusresolved => new
2016-05-24 18:53OrekariaResolutionfixed => open
2016-05-31 13:38hgbotCheckin
2016-05-31 13:38hgbotNote Added: 0086859
2016-05-31 13:39jorge-garciaStatusnew => scheduled
2016-05-31 13:39jorge-garciaAssigned ToRetail => jorge-garcia
2016-05-31 13:39jorge-garciaStatusscheduled => resolved
2016-05-31 13:39jorge-garciaResolutionopen => fixed
2016-06-07 17:52guilleaerReview Assigned To => guilleaer
2016-06-07 17:52guilleaerStatusresolved => closed
2016-06-07 17:52guilleaerFixed in Version => RR16Q2

Notes
(0086062)
hgbot   
2016-04-28 20:12   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 1b6a0f06be28fefc7874fdc75963d0b4a92b09e5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Apr 28 20:12:03 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/1b6a0f06be28fefc7874fdc75963d0b4a92b09e5 [^]

Fixed issue 32700. Verify Firm Quotation Imbalanced Cases Resolved

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086715)
Orekaria   
2016-05-24 18:53   
I can see it failing in step 1.8.2, when firm quotation is unchecked. The receipt loses all discounts
(0086859)
hgbot   
2016-05-31 13:38   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 13bffbdc06626e7d68f81fce75cfe77733e03b0e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 31 13:38:32 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/13bffbdc06626e7d68f81fce75cfe77733e03b0e [^]

Related to issue 32700: Verify Firm Quotation Imbalanced Cases Resolved

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---