Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032697Openbravo ERP07. Sales managementpublic2016-04-18 10:142016-04-19 09:01
Reporterumartirena 
Assigned ToTriage Omni OMS 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032697: Product Services Code Review
DescriptionProduct Services Code Review.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032687 closed Triage Omni OMS Product Services Code Review 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-18 18:28umartirenaTypedefect => backport
2016-04-18 18:28umartirenaTarget Version => 3.0PR16Q2
2016-04-18 18:52hgbotCheckin
2016-04-18 18:52hgbotNote Added: 0085718
2016-04-18 18:52hgbotStatusscheduled => resolved
2016-04-18 18:52hgbotResolutionopen => fixed
2016-04-18 18:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/956cd99a19371b1c12f94fc92b5b62e481af27fa [^]
2016-04-19 09:01vmromanosReview Assigned To => vmromanos
2016-04-19 09:01vmromanosNote Added: 0085728
2016-04-19 09:01vmromanosStatusresolved => closed

Notes
(0085718)
hgbot   
2016-04-18 18:52   
Repository: erp/backports/3.0PR16Q2
Changeset: 956cd99a19371b1c12f94fc92b5b62e481af27fa
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Apr 18 18:51:42 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/956cd99a19371b1c12f94fc92b5b62e481af27fa [^]

Fixes issue 32697: Applied Product Services Code Review

---
M src-db/database/model/functions/C_GET_SERVICE_AMOUNT.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-test/src/org/openbravo/test/services/ServicesTest.java
M src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java
M src/org/openbravo/erpCommon/info/ServiceProductPricePrecisionFilterExpression.java
M src/org/openbravo/event/ServiceOrderLineEventHandler.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
---
(0085728)
vmromanos   
2016-04-19 09:01   
Code review OK