0032692: [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0032692

Retail Modules

Web POS

public

2016-04-15 10:03

2016-04-22 16:06

Reporter

umartirena

Assigned To

Retail

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q1.1

Fixed in Version

RR16Q1.1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2015-12-15

Regression introduced in release

RR16Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed7f8734ef3bb2cd7eb6b310facea36835c6d9cb [^]

Triggers an Emergency Pack

Summary

0032692: [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend

Description

Discounts are not properly obtained when loading a ticket with discounts from the backend. A ticket with a line with certain discounts is synchronized to the backend, and when retrieving it the values of the discounts are not properly displayed.

Steps To Reproduce

In Web POS:
- A a line with a ticket for product "Crampons 10 point", qty: 3
- A "price_adjust_chrampons_30_eur" discount is automatically applied, amount: -29.70.
- Go to "receipt discounts" menu entry and apply "disc_5_var_euro - 5 EUR" discount. A discount is applied in the line of amount -5. The previous discount is updated to amount -24.69.
- Pay and complete the ticket.
- Go to "Receipts" menu entry and search the ticket.
- The amount of "price_adjust_chrampons_30_eur" discount is now again -29.70, and this is wrong (even the total gross of the ticket is ok, because the promotion data in client side is wrong), it should be -24.69.

Proposed Solution

The best way of action is to set at order's line level the flag skipApplyPromotions to true in the newPaidReceipt function.

After that, it's mandatory to try the flows of layaways, receipts, quotations and other possible flows that retrieve an order from the backend.

Keep in mind that in the create order from quotation flow, if the Firm Quotation field is unchecked, this flag must be change to false to recalculate the promotion and prices of the order's lines. This scenario, could be reproducible in another flows.

Additional Information