Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032687Openbravo ERP07. Sales managementpublic2016-04-18 10:142016-06-17 19:37
Reporterumartirena 
Assigned ToTriage Omni OMS 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032687: Product Services Code Review
DescriptionProduct Services Code Review.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00326973.0PR16Q2 closed Triage Omni OMS Product Services Code Review 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-18 10:14umartirenaNew Issue
2016-04-18 10:14umartirenaAssigned To => Triage Finance
2016-04-18 10:14umartirenaOBNetwork customer => No
2016-04-18 10:14umartirenaModules => Core
2016-04-18 10:14umartirenaTriggers an Emergency Pack => No
2016-04-18 18:28umartirenaStatusnew => scheduled
2016-04-18 18:47hgbotCheckin
2016-04-18 18:47hgbotNote Added: 0085717
2016-04-18 18:47hgbotStatusscheduled => resolved
2016-04-18 18:47hgbotResolutionopen => fixed
2016-04-18 18:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/de209c96bd10822afb2469398a8100be291702ad [^]
2016-04-19 09:01vmromanosReview Assigned To => vmromanos
2016-04-19 09:01vmromanosNote Added: 0085729
2016-04-19 09:01vmromanosStatusresolved => closed
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087464

Notes
(0085717)
hgbot   
2016-04-18 18:47   
Repository: erp/devel/pi
Changeset: de209c96bd10822afb2469398a8100be291702ad
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Apr 18 10:14:52 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/de209c96bd10822afb2469398a8100be291702ad [^]

Fixes issue 32687: Applied Product Services Code Review

---
M src-db/database/model/functions/C_GET_SERVICE_AMOUNT.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-test/src/org/openbravo/test/services/ServicesTest.java
M src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java
M src/org/openbravo/erpCommon/info/ServiceProductPricePrecisionFilterExpression.java
M src/org/openbravo/event/ServiceOrderLineEventHandler.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
---
(0085729)
vmromanos   
2016-04-19 09:01   
Code review OK
(0087464)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test