Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032674Retail ModulesWeb POSpublic2016-04-15 10:032016-04-28 10:13
Reporterumartirena 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-12-15
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed7f8734ef3bb2cd7eb6b310facea36835c6d9cb [^]
Triggers an Emergency PackNo
Summary0032674: [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend
DescriptionDiscounts are not properly obtained when loading a ticket with discounts from the backend. A ticket with a line with certain discounts is synchronized to the backend, and when retrieving it the values of the discounts are not properly displayed.
Steps To ReproduceIn Web POS:
 - A a line with a ticket for product "Crampons 10 point", qty: 3
 - A "price_adjust_chrampons_30_eur" discount is automatically applied, amount: -29.70.
 - Go to "receipt discounts" menu entry and apply "disc_5_var_euro - 5 EUR" discount. A discount is applied in the line of amount -5. The previous discount is updated to amount -24.69.
 - Pay and complete the ticket.
 - Go to "Receipts" menu entry and search the ticket.
 - The amount of "price_adjust_chrampons_30_eur" discount is now again -29.70, and this is wrong (even the total gross of the ticket is ok, because the promotion data in client side is wrong), it should be -24.69.
Proposed SolutionThe best way of action is to set at order's line level the flag skipApplyPromotions to true in the newPaidReceipt function.

After that, it's mandatory to try the flows of layaways, receipts, quotations and other possible flows that retrieve an order from the backend.

Keep in mind that in the create order from quotation flow, if the Firm Quotation field is unchecked, this flag must be change to false to recalculate the promotion and prices of the order's lines. This scenario, could be reproducible in another flows.
Additional Information
TagsSER-QA
Relationships
depends on backport 0032691RR16Q2 closed Retail [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend 
depends on backport 0032692RR16Q1.1 closed Retail [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend 
related to defect 0032699 closed shivum039 Firm quotation doesn't work when creating a order from a quotation 
causes defect 0033036 closed ranjith_qualiantech_com Quotation Amount is not calculated after reactivation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-15 10:03umartirenaNew Issue
2016-04-15 10:03umartirenaAssigned To => Retail
2016-04-15 10:03umartirenaTriggers an Emergency Pack => No
2016-04-15 11:11OrekariaStatusnew => acknowledged
2016-04-15 11:14umartirenaResolution time => 1461880800
2016-04-18 12:57VictorVillarTag Attached: SER-QA
2016-04-18 12:58VictorVillarSummaryDiscounts are not properly obtained when loading a ticket with discounts from the backend => [SER-QA 911] Discounts are not properly obtained when loading a ticket with discounts from the backend
2016-04-18 15:49jorge-garciaRegression level => Production - QA Approved
2016-04-18 15:49jorge-garciaRegression date => 2015-12-15
2016-04-18 15:49jorge-garciaRegression introduced in release => RR16Q1
2016-04-18 15:49jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed7f8734ef3bb2cd7eb6b310facea36835c6d9cb [^]
2016-04-18 16:09jorge-garciaProposed Solution updated
2016-04-18 16:10jorge-garciaStatusacknowledged => scheduled
2016-04-18 16:11ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-04-19 09:11jorge-garciaRelationship addedrelated to 0032699
2016-04-21 04:36hgbotCheckin
2016-04-21 04:36hgbotNote Added: 0085805
2016-04-21 04:36hgbotCheckin
2016-04-21 04:36hgbotNote Added: 0085806
2016-04-21 04:36hgbotCheckin
2016-04-21 04:36hgbotNote Added: 0085807
2016-04-21 04:36hgbotStatusscheduled => resolved
2016-04-21 04:36hgbotResolutionopen => fixed
2016-04-21 04:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea3697a0359b1589f8f5ca9fd604ee5b686ad23b [^]
2016-04-22 13:20hgbotCheckin
2016-04-22 13:20hgbotNote Added: 0085892
2016-04-28 10:13marvintmReview Assigned To => marvintm
2016-04-28 10:13marvintmStatusresolved => closed
2016-04-28 10:13marvintmFixed in Version => RR16Q3
2016-06-07 12:40OrekariaRelationship addedcauses 0033036

Notes
(0085805)
hgbot   
2016-04-21 04:36   
Repository: tools/automation/pi-mobile
Changeset: 6c416a6bd49676ee4e815cdd05cbd536efba95e1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 21 08:04:12 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c416a6bd49676ee4e815cdd05cbd536efba95e1 [^]

Verifies issue 32674 : Added automated test 'I32674_VerifyDiscountOnReloadTicket'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I32674_VerifyDiscountOnReloadTicket.java
---
(0085806)
hgbot   
2016-04-21 04:36   
Repository: tools/automation/pi-mobile
Changeset: 6c416a6bd49676ee4e815cdd05cbd536efba95e1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 21 08:04:12 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c416a6bd49676ee4e815cdd05cbd536efba95e1 [^]

Verifies issue 32674 : Added automated test 'I32674_VerifyDiscountOnReloadTicket'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I32674_VerifyDiscountOnReloadTicket.java
---
(0085807)
hgbot   
2016-04-21 04:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ea3697a0359b1589f8f5ca9fd604ee5b686ad23b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 21 08:05:28 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea3697a0359b1589f8f5ca9fd604ee5b686ad23b [^]

Fixes issue 32674 : Prevent apply promotion while loading ticket from backend

Prevent Calculating promotion while loading ticket from backend

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0085892)
hgbot   
2016-04-22 13:20   
Repository: retail/backports/3.0RR16Q1.1/org.openbravo.retail.posterminal
Changeset: 7240b50a9a89981a815830b6ef4522329b30cc83
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 17:23:12 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.1/org.openbravo.retail.posterminal/rev/7240b50a9a89981a815830b6ef4522329b30cc83 [^]

Fixed issue 32692: [SER-QA 911] Discounts are not properly obtained when loading
a ticket with discounts from the backend

Backport for the issue 32674.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---