Openbravo Issue Tracking System - Retail Modules
View Issue Details
0032664Retail ModulesWeb POSpublic2016-04-04 12:572016-06-09 11:58
malsasua 
ranjith_qualiantech_com 
highmajorsometimes
closedfixed 
20Community Appliance
 
RR16Q2RR16Q2 
guilleaer
No
0032664: order by is missing in ProductCharacteristicValue model
In the query executed to load the model ProductCharacteristicValue, is missing a order by criteria.

When this model has got more than 35.000 records, two or more requests are done to backend to retrieve the data (in batchs of 35.000 records).
In some cases, the second request is returning records included in the first request.

It is important that it should be checked in all models, not only ProductCharacteristicValue
it has been reproduced in postgres 9.3.4

in one instance with more than 35.000 product characteristic value:
. do login

error is returned:
OG.Dal.insertData: model insert 'ProductCharacteristicValue': SQLError: code: 6, message: could not execute statement duet to a constraint failure (19 UNIQUE constaint failed: m_proudct_ch_value.m_product_ch_value_id);
No tags attached.
blocks defect 0032580 closed ranjith_qualiantech_com order by is missing in ProductCharacteristicValue model 
Issue History
2016-04-14 11:29OrekariaTypedefect => backport
2016-04-14 11:29OrekariaTarget Version => RR16Q2
2016-04-19 08:17hgbotCheckin
2016-04-19 08:17hgbotNote Added: 0085721
2016-04-19 08:17hgbotStatusscheduled => resolved
2016-04-19 08:17hgbotResolutionopen => fixed
2016-04-19 08:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12d6c5a3c4a5b1880577e143d0e91b4b83aa2834 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/5fcdb09a9b8ce8fd5a593314b572132b619854de [^]
2016-05-17 17:21guilleaerReview Assigned To => guilleaer
2016-05-17 17:21guilleaerStatusresolved => closed
2016-05-17 17:21guilleaerFixed in Version => RR16Q2
2016-06-09 11:58hgbotCheckin
2016-06-09 11:58hgbotNote Added: 0087112

Notes
(0085721)
hgbot   
2016-04-19 08:17   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 5fcdb09a9b8ce8fd5a593314b572132b619854de
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Apr 18 15:09:42 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/5fcdb09a9b8ce8fd5a593314b572132b619854de [^]

Fixes issue 32664 : Added missing order by clause to models

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterBusinessPartner.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterBusinessPartnerGroup.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProduct.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProductCategory.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterRole.java
M src/org/openbravo/retail/posterminal/master/OfferPriceList.java
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductBOM.java
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRule.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRangePrices.java
M src/org/openbravo/retail/posterminal/master/TaxCategoryBOM.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
M src/org/openbravo/retail/posterminal/master/TaxZoneProperties.java
M src/org/openbravo/retail/posterminal/term/ApprovalReason.java
M src/org/openbravo/retail/posterminal/term/CashCloseReport.java
---
(0087112)
hgbot   
2016-06-09 11:58   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 355930417eee1bf7a61df0369e4a31c9292c5d39
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 09 11:58:35 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/355930417eee1bf7a61df0369e4a31c9292c5d39 [^]

Related to issue 32664. Remove wrong order by from main PriceList query

---
M src/org/openbravo/retail/posterminal/master/PriceList.java
---