Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0032663 | Openbravo ERP | A. Platform | public | 2016-04-14 10:11 | 2016-06-17 19:38 |
|
Reporter | alostale | |
Assigned To | alostale | |
Priority | normal | Severity | trivial | Reproducibility | random |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR16Q3 | |
Merge Request Status | |
Review Assigned To | caristu |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0032663: request to AlertActionHandler while switching role logs error |
Description | Recently, int-gui job is sometimes run as unstable.
The cause of this instabilities is errors in openbravo.log [1].
This situation occurs in case there is a request to AlertActionHandler in parallel while switching role if previous role was in a different client/organization than the ones granted to the default role assigned to current user. This occurs if currrent session's settings (role/client/org) have been partially removed when alert request is processed, in this case it is trying to apply default user's client-org with current role which might not match.
---
[1] see https://ci.openbravo.com/job/int-gui-pgsql/1522/artifact/SANDBOX/tomcat-logs/int-gui-pgsql.log [^]
2016-04-13 16:11:06,954 [TP-Processor8] ERROR org.openbravo.base.secureApp.LoginUtils - Login organization is not in role organizations list
2016-04-13 16:11:06,977 [TP-Processor8] ERROR org.openbravo.base.secureApp.LoginUtils - Login client is not in role clients list
|
Steps To Reproduce | 0. Apply attached diff. It delays backend processing of role switching. So at least one alert request is received during this period.
1. Login as Openbravo. Ensure the following settings are marked as default, if they are not mark them and switch to that role:
* Role: F&B group admin
* Org: España Norte
2. Switch role to:
* Role: QA Testing Admin
* Org: Main
3. Wait till alert request and check in log:
ERROR org.openbravo.base.secureApp.LoginUtils - Login organization is not in role organizations list. Role: 4028E6C72959682B01295A071429011E, Org: E443A31992CB4635AFCAEABE7183CE85
|
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | |
Attached Files | sleep-login.diff (716) 2016-06-01 08:26 https://issues.openbravo.com/file_download.php?file_id=9462&type=bug |
|
Issue History |
Date Modified | Username | Field | Change |
2016-04-14 10:11 | alostale | New Issue | |
2016-04-14 10:11 | alostale | Assigned To | => platform |
2016-04-14 10:11 | alostale | Modules | => Core |
2016-04-14 10:11 | alostale | Triggers an Emergency Pack | => No |
2016-04-14 10:16 | hgbot | Checkin | |
2016-04-14 10:16 | hgbot | Note Added: 0085630 | |
2016-05-06 08:56 | alostale | Assigned To | platform => lorenzofidalgo |
2016-05-17 10:17 | lorenzofidalgo | Status | new => acknowledged |
2016-05-17 10:18 | lorenzofidalgo | Note Added: 0086491 | |
2016-05-25 17:03 | hgbot | Checkin | |
2016-05-25 17:03 | hgbot | Note Added: 0086750 | |
2016-06-01 08:03 | alostale | Assigned To | lorenzofidalgo => alostale |
2016-06-01 08:03 | alostale | Summary | instabilities in int-gui job => request to AlertActionHandler while switching role logs error |
2016-06-01 08:03 | alostale | Description Updated | bug_revision_view_page.php?rev_id=12274#r12274 |
2016-06-01 08:21 | alostale | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=12276#r12276 |
2016-06-01 08:26 | alostale | File Added: sleep-login.diff | |
2016-06-01 09:26 | hgbot | Checkin | |
2016-06-01 09:26 | hgbot | Note Added: 0086871 | |
2016-06-01 09:26 | hgbot | Status | acknowledged => resolved |
2016-06-01 09:26 | hgbot | Resolution | open => fixed |
2016-06-01 09:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ab794c23a5560882cedc3a7960f0558f8513104f [^] |
2016-06-01 09:26 | alostale | Review Assigned To | => caristu |
2016-06-02 10:15 | caristu | Note Added: 0086905 | |
2016-06-02 10:15 | caristu | Status | resolved => closed |
2016-06-02 10:15 | caristu | Fixed in Version | => 3.0PR16Q3 |
2016-06-17 19:36 | hudsonbot | Checkin | |
2016-06-17 19:36 | hudsonbot | Note Added: 0087448 | |
2016-06-17 19:37 | hudsonbot | Checkin | |
2016-06-17 19:37 | hudsonbot | Note Added: 0087571 | |
2016-06-17 19:38 | hudsonbot | Checkin | |
2016-06-17 19:38 | hudsonbot | Note Added: 0087583 | |
Notes |
|
(0085630)
|
hgbot
|
2016-04-14 10:16
|
|
Repository: erp/devel/pi
Changeset: 4f9959e58bd3fee1a5fa7f9ad1cc27590ded47f5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 14 10:16:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4f9959e58bd3fee1a5fa7f9ad1cc27590ded47f5 [^]
related to bug 32663: instabilities in int-gui job
Added extra log when trying to log with incorrect client/org
---
M src/org/openbravo/base/secureApp/LoginUtils.java
---
|
|
|
|
|
|
(0086750)
|
hgbot
|
2016-05-25 17:03
|
|
Repository: erp/devel/pi
Changeset: 7820fcf679e382e5ddfac8c741e641f30e31e746
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed May 25 17:03:16 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7820fcf679e382e5ddfac8c741e641f30e31e746 [^]
related to issue 32663: instabilities in int-gui job
Added stack trace when error about invalid client/org is logged
---
M src/org/openbravo/base/secureApp/LoginUtils.java
---
|
|
|
(0086871)
|
hgbot
|
2016-06-01 09:26
|
|
Repository: erp/devel/pi
Changeset: ab794c23a5560882cedc3a7960f0558f8513104f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jun 01 09:24:38 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ab794c23a5560882cedc3a7960f0558f8513104f [^]
fixed bug 32663: request to AlertActionHandler while switching role logs error
Under certain circumstances, it was possible to send alert handler requests while
in process of switching to a different role. This requests might be processes
with a partially created session, logging error messages in openbravo.log.
This has been fixed by preventing to send these requests from client, while
logging in is being processed.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-manager.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-user-profile-widget.js
---
|
|
|
|
Verified in pi@ab794c23a556 |
|
|
|
|
|
|
|
|
|
|