Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0032654 | Openbravo ERP | Z. Others | public | 2016-04-12 13:49 | 2016-06-17 19:37 |
|
| Reporter | maite | |
| Assigned To | markmm82 | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR16Q3 | Fixed in Version | 3.0PR16Q3 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | |
| Web browser | |
| Modules | Advanced Payables and Receivables Mngmt |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0032654: Unhomogeneus behavior in Transaction's organization accounting dimension depending of process used to add transaction |
| Description | Value for Organization in Transaction's dimension section is different depending on process used to add transaction |
| Steps To Reproduce | 1. Access "Cuenta de Banco" financial account, create new Bank Statement and add line with amount in=5. Process bank statement
2. Run "match statement" process, click + to add new transaction. Set "España Norte" in organization field in dimensions section and press + to add new payment. Set "alimentos y supermercados" business partner and select invoice. Press Done
3. Realize that payment document has been created and organization has "ESpaña norte" value before finish process. Press Done and OK
4. In transactions tab, realize that Organization value is "España" instead of "España norte"
5. Access sales invoice "1000175" (which is the same paid in previous step) and run "Add Payment process". Set any amount and "Process Received Payment(s) and Deposit"
6. Access "Cuenta de banco" financial account to review this new transaction and realize that organization value is "españa norte" |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0032759 | 3.0PR16Q3 | closed | alostale | Wrong on change function called in process definition |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-04-12 13:49 | maite | New Issue | |
| 2016-04-12 13:49 | maite | Assigned To | => Triage Finance |
| 2016-04-12 13:49 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2016-04-12 13:49 | maite | Triggers an Emergency Pack | => No |
| 2016-04-12 13:50 | maite | Resolution time | => 1463349600 |
| 2016-04-12 13:50 | maite | Target Version | => 3.0PR16Q3 |
| 2016-04-12 13:50 | maite | Issue Monitored: networkb | |
| 2016-04-12 19:22 | aferraz | Assigned To | Triage Finance => markmm82 |
| 2016-04-13 17:17 | aferraz | Note Added: 0085626 | |
| 2016-04-13 17:21 | aferraz | Note Edited: 0085626 | bug_revision_view_page.php?bugnote_id=0085626#r11773 |
| 2016-04-14 15:21 | markmm82 | Status | new => scheduled |
| 2016-04-14 15:21 | markmm82 | Note Added: 0085635 | |
| 2016-04-15 09:58 | jfrances | Issue Monitored: jfrances | |
| 2016-04-21 18:02 | aferraz | Relationship added | related to 0032759 |
| 2016-04-21 19:28 | hgbot | Checkin | |
| 2016-04-21 19:28 | hgbot | Note Added: 0085849 | |
| 2016-04-21 19:28 | hgbot | Status | scheduled => resolved |
| 2016-04-21 19:28 | hgbot | Resolution | open => fixed |
| 2016-04-21 19:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c33cf2dc04adb78711dcafcc0dc4efed95000e05 [^] |
| 2016-04-21 19:28 | hgbot | Checkin | |
| 2016-04-21 19:28 | hgbot | Note Added: 0085850 | |
| 2016-04-21 19:29 | aferraz | Review Assigned To | => aferraz |
| 2016-04-21 19:29 | aferraz | Note Added: 0085853 | |
| 2016-04-21 19:29 | aferraz | Status | resolved => closed |
| 2016-04-21 19:29 | aferraz | Fixed in Version | => 3.0PR16Q3 |
| 2016-04-22 10:01 | hgbot | Checkin | |
| 2016-04-22 10:01 | hgbot | Note Added: 0085876 | |
| 2016-06-17 19:37 | hudsonbot | Checkin | |
| 2016-06-17 19:37 | hudsonbot | Note Added: 0087478 | |
| 2016-06-17 19:37 | hudsonbot | Checkin | |
| 2016-06-17 19:37 | hudsonbot | Note Added: 0087479 | |
| 2016-06-17 19:37 | hudsonbot | Checkin | |
| 2016-06-17 19:37 | hudsonbot | Note Added: 0087484 | |
|
Notes |
|
|
(0085626)
|
|
aferraz
|
2016-04-13 17:17
(edited on: 2016-04-13 17:21) |
|
Seems that Organization field is not working properly in Add new transaction process definition. It should be used to:
- Filter payments in Payment selector (drop down or magnifying glass) in Add new transaction process definition.
- Filter in Add Payment grids when opening from Payment selector in Add new transaction process definition.
- Creating new payments in Add Payment when opening from Payment selector in Add new transaction process definition.
- Creating new financial account transactions in Add new transaction process definition.
All this flows work fine in Financial Account Transaction tab but not in Add new transaction process definition and it should.
|
|
|
|
|
Test plan:
1. Access "Cuenta de Banco" financial account, create new Bank Statement and add line with amount in=5. Save and Process bank statement
2. Run "match statement" process, click + to add new transaction.
Set "España Norte" in organization field in dimensions section.
Press + to add new payment.
-Set "alimentos y supermercados" business partner and select invoice.
-Press Done
3. Realize that payment document has been created and organization has "España norte" value before finish process. Press Done and OK
4. In transactions tab, realize that Organization value is "España norte"
5. Access sales invoice "1000175" (which is the same paid in previous step) and run "Add Payment process". Set any amount and "Process Received Payment(s) and Deposit"
6. Access "Cuenta de banco" financial account to review this new transaction and realize that organization value is "España norte". |
|
|
|
(0085849)
|
|
hgbot
|
|
2016-04-21 19:28
|
|
Repository: erp/devel/pi
Changeset: c33cf2dc04adb78711dcafcc0dc4efed95000e05
Author: Mark <m.molina <at> nectus.com>
Date: Thu Apr 14 14:27:30 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/c33cf2dc04adb78711dcafcc0dc4efed95000e05 [^]
Fixes issue 32654: Unhomogeneus behavior in Transaction organization dimension.
To avoid that the value for Organization in Transaction's dimension section be different depending on process used to add transaction, if the Add payment action is excecuted from it, always will be used as organization the ad_org_id field selected in the caller window (Add transaction window).
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
|
|
|
|
(0085850)
|
|
hgbot
|
|
2016-04-21 19:28
|
|
Repository: erp/devel/pi
Changeset: 6ae46b081f60b8f73047b73c7076155f459c7a1e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 21 15:03:45 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6ae46b081f60b8f73047b73c7076155f459c7a1e [^]
Related to issue 32654: Code review improvements
Some changes have been done in Add Transaction process definition related to organization field in order to have the same behaviour as in Financial Account Transaction tab.
- Filter payments in Payment selector (drop down or magnifying glass) in Add new transaction process definition:
Add new parameter called ad_org_id_process to save process definition's current organization value, and filter by it in the hql where clause of the payment selector.
- Filter in Add Payment grids when opening from Payment selector in Add new transaction process definition.
Check for ad_org_id parameter before checking for inpadOrgId parameter in TransactionAddPaymentDefaultValues.
- Creating new payments in Add Payment when opening from Payment selector in Add new transaction process definition:
Check for ad_org_id parameter before checking for inpadOrgId parameter in AddPaymentActionHandler.
- Creating new financial account transactions in Add new transaction process definition:
Process definition's current organization value will be taken instead of selected payment organization.
- Avoid changing organization once you have selected a payment:
Update read only logic of accounting dimensions to disable them when we have already selected a payment.
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
---
|
|
|
|
|
|
|
|
(0085876)
|
|
hgbot
|
|
2016-04-22 10:01
|
|
Repository: erp/devel/pi
Changeset: 8e9276563a5de5f9979b9108edd7de82cbf685b6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Apr 22 09:58:56 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8e9276563a5de5f9979b9108edd7de82cbf685b6 [^]
Related to issue 32654: Create new ad_element for ad_org_id_process parameter
---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|