Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032618Retail ModulesDiscounts and Promotionspublic2016-04-04 16:472016-05-10 15:57
Reporteraaroncalero 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032618: Lines are not grouped when 'return line' is involved
DescriptionLines are not grouped when 'return line' is involved
Steps To ReproduceLogin in web pos and create an empty ticket
Add an avalanche transceiver, go to the edit tab, and click on return line.
Add another avalanche transceiver (a new line will be created).
Select the first line, go to the edit tab and click on return line again.

Error: Now the ticket will have two lines with one unit of avalanche transceiver

Proposed SolutionGroup lines when there are 2 or more products when
1- they have the same sign in the quantity, and
2- their amounts have not been edited
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0032639 closed mario_castello Lines are not grouped 
blocks defect 0032585 closed jorge-garcia [SERQA 873] Discretionary discounts are not working with ungrouped lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-07 13:05OrekariaTypedefect => backport
2016-04-07 13:05OrekariaTarget Version => RR16Q4
2016-04-07 13:05OrekariaStatusscheduled => acknowledged
2016-04-07 13:35OrekariaTypebackport => defect
2016-04-07 13:35OrekariaSummary[SERQA 872] Discretionary discounts are not working with ungrouped lines => Lines are not grouped when 'return line' is involved
2016-04-07 13:35OrekariaDescription Updatedbug_revision_view_page.php?rev_id=11697#r11697
2016-04-07 13:35OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11699#r11699
2016-04-07 13:35OrekariaProposed Solution updated
2016-04-20 16:52lorenzofidalgoRelationship addedhas duplicate 0032639
2016-04-20 16:53lorenzofidalgoAssigned ToRetail => mario_castello
2016-04-21 10:53lorenzofidalgoNote Added: 0085818
2016-04-21 16:26OrekariaTarget VersionRR16Q4 =>
2016-04-21 16:26OrekariaStatusacknowledged => scheduled
2016-05-06 10:58jorge-garciaNote Added: 0086251
2016-05-06 10:58jorge-garciaNote Edited: 0086251bug_revision_view_page.php?bugnote_id=0086251#r11989
2016-05-06 11:01jorge-garciaStatusscheduled => resolved
2016-05-06 11:01jorge-garciaFixed in Version => RR16Q3
2016-05-06 11:01jorge-garciaResolutionopen => fixed
2016-05-06 11:04marvintmReview Assigned To => marvintm
2016-05-06 11:04marvintmStatusresolved => closed
2016-05-10 15:57hgbotCheckin
2016-05-10 15:57hgbotNote Added: 0086356

Notes
(0085818)
lorenzofidalgo   
2016-04-21 10:53   
Warning: This fix must be considered as risky.
On the one hand, to fix this, it could be considered to check all properties and check they match. It could bring a performance problem.
On the other hand, it could be considered to check only some properties like amount, it would not be correct due to some properties like delivery must also be considered.
Double check this fix.
(0086251)
jorge-garcia   
2016-05-06 10:58   
Fixed by this changeset[1]

[1]https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e734cd9ef63f7e33cae9b1ca9e77b4481385b9a [^]
(0086356)
hgbot   
2016-05-10 15:57   
Repository: tools/automation/pi-mobile
Changeset: b14b45e0c267650b2bc3b68fc129fafa8413de20
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue May 10 07:56:06 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b14b45e0c267650b2bc3b68fc129fafa8413de20 [^]

Verifies issue 32618: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32618_ReturnsAndGroupProduct.java
---