Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032601Retail ModulesWeb POSpublic2016-04-05 13:172016-04-26 13:12
Reporteragete 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032601: [SERQA 870] Issue when adding a price adjustment discount to two lines with the same product
DescriptionIssue when adding a price adjustment discount to two lines with the same product the discount is just shown on one line but applied over the total of the lines.
Steps To ReproduceCreate a new receipt and select the product Minilintern solar dynamo (no discount is applied automatically in a returned line)
Click on the button return line
Search again for the product Minilintern solar dynamo and add it to the receipt (a discount of 5% has been applied)
Click again on the previous line, the negative one and click on the button Return line
Error--> Check the discount 5% is indicated just in the line where it was initially and the amount to discount has considered the total amount
of both lines.
For the user, it is extrange to see the discount just in one line when it is applied in both
The printing report shows the information as it is in the receipt, so it is also extrange how it is shown
Proposed SolutionShow the discount information on every line where it applies
Additional Information
TagsSER-QA
Relationships
depends on feature request 0032638 feedback Retail Overhaul how lines are reorganized when discounts are applied 
related to defect 0032585 closed jorge-garcia [SERQA 873] Discretionary discounts are not working with ungrouped lines 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-05 13:17ageteNew Issue
2016-04-05 13:17ageteAssigned To => Retail
2016-04-05 13:17ageteResolution time => 1461103200
2016-04-05 13:17ageteTriggers an Emergency Pack => No
2016-04-06 18:22OrekariaStatusnew => acknowledged
2016-04-11 10:03OrekariaStatusacknowledged => scheduled
2016-04-11 10:03OrekariaStatusscheduled => feedback
2016-04-11 10:17OrekariaRelationship addeddepends on 0032638
2016-04-20 11:05jorge-garciaStatusfeedback => scheduled
2016-04-20 11:05jorge-garciaAssigned ToRetail => jorge-garcia
2016-04-20 11:06jorge-garciaRelationship addedrelated to 0032585
2016-04-21 12:07VictorVillarTag Attached: SER-QA
2016-04-21 13:34hgbotCheckin
2016-04-21 13:34hgbotNote Added: 0085828
2016-04-21 13:34hgbotStatusscheduled => resolved
2016-04-21 13:34hgbotResolutionopen => fixed
2016-04-21 13:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e734cd9ef63f7e33cae9b1ca9e77b4481385b9a [^]
2016-04-21 13:35hgbotCheckin
2016-04-21 13:35hgbotNote Added: 0085832
2016-04-26 13:12migueldejuanaReview Assigned To => migueldejuana
2016-04-26 13:12migueldejuanaNote Added: 0085983
2016-04-26 13:12migueldejuanaStatusresolved => closed

Notes
(0085828)
hgbot   
2016-04-21 13:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2e734cd9ef63f7e33cae9b1ca9e77b4481385b9a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Apr 20 10:53:16 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e734cd9ef63f7e33cae9b1ca9e77b4481385b9a [^]

Fixed issue 32601: [SERQA 870] Issue when adding a price adjustment discount
to two lines with the same product

This problem happens with both manual and automatic promotions and grouped
products.

The solution is to merge the lines when the returned line revert it's status to
a positive quantity.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0085832)
hgbot   
2016-04-21 13:35   
Repository: tools/automation/pi-mobile
Changeset: 80f337a862e9bcf02b429ef2fb672d4f734e4e86
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 13:31:40 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/80f337a862e9bcf02b429ef2fb672d4f734e4e86 [^]

Verifies issue 32601: [SERQA 870] Issue when adding a price adjustment discount
to two lines with the same product

Added test I32601_ReturnLineAndApplyPromotion.

---
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/discountsandpromotions/I32601_ReturnLineAndApplyPromotion.java
---
(0085983)
migueldejuana   
2016-04-26 13:12   
Tested and reviewed a003f89753a6