Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032596Retail ModulesWeb POSpublic2016-04-05 12:332016-04-28 10:25
Reporterpaul_guiot 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032596: [SERQA 871] Discount allocation by article: Inconsistency
DescriptionThe problem occurs with the display of the discount allocation based on the promotion. The final amount is always correct.

The problem happens only on the details of the articles. Depending the way we introduce the articles, we have a different behaviour. Whatever the calculation behind, we should always have the same discount allocation for a pack.
Steps To ReproduceIn the backend, Go to the Discount and promotion:
- Chek that the Promotion “Camping Pack” exists with the two following articles:
o Down sleeping bag 500
o Expedition tent 4 season 2 person
- Make sure to deactivate the promotions “Price adjustment” to avoid any inconsistencies in the test (To be sure that only the Camping Pack will be applied)

In the Webpos, Go to the VBS-1 with the user vallblanca:
- Create a ticket with the pack: Camping Pack
o Click on “Search”;
o Categories: Pack. Search. Select Camping Pack
- Select in the ticket the 2nd article and add 1 Qty

Error: The allocation discount by articles has been modified. The pack and its price detailed could be separated from the rest of the ticket to keep the same original ratio of discount(?)
Proposed Solution
Additional Information
TagsSER-QA
Relationships
depends on feature request 0032638 feedback Retail Overhaul how lines are reorganized when discounts are applied 
blocks defect 0032828 closed jorge-garcia [SERQA 871] Discount allocation by article inconsistent when quantity in empty is the definition of a pack 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-05 12:33paul_guiotNew Issue
2016-04-05 12:33paul_guiotAssigned To => Retail
2016-04-05 12:33paul_guiotResolution time => 1460671200
2016-04-05 12:33paul_guiotTriggers an Emergency Pack => No
2016-04-05 12:35paul_guiotNote Added: 0085437
2016-04-05 13:41ageteTag Attached: SER-QA
2016-04-06 18:23OrekariaStatusnew => acknowledged
2016-04-11 10:03OrekariaStatusacknowledged => scheduled
2016-04-11 10:03OrekariaStatusscheduled => feedback
2016-04-11 10:17OrekariaRelationship addeddepends on 0032638
2016-04-20 11:05jorge-garciaStatusfeedback => scheduled
2016-04-20 11:05jorge-garciaAssigned ToRetail => jorge-garcia
2016-04-21 13:33hgbotCheckin
2016-04-21 13:33hgbotNote Added: 0085827
2016-04-21 13:33hgbotStatusscheduled => resolved
2016-04-21 13:33hgbotResolutionopen => fixed
2016-04-21 13:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/144278fbba86ccfaaf75372d52fff132f99c1605 [^]
2016-04-21 13:34hgbotCheckin
2016-04-21 13:34hgbotNote Added: 0085830
2016-04-28 10:25marvintmReview Assigned To => marvintm
2016-04-28 10:25marvintmStatusresolved => closed
2016-04-28 10:25marvintmFixed in Version => RR16Q3
2016-05-02 18:37amayavicenteRelationship addedblocks 0032828

Notes
(0085437)
paul_guiot   
2016-04-05 12:35   
[SERQA]
(0085827)
hgbot   
2016-04-21 13:33   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 144278fbba86ccfaaf75372d52fff132f99c1605
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Apr 20 10:48:45 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/144278fbba86ccfaaf75372d52fff132f99c1605 [^]

Fixed issue 32596: [SERQA 871] Discount allocation by article: Inconsistency

The calculation of the proportional part of each line that participates in the
promotions was calculated with the total quantity of the line.

The solution is to use the quantity used to create the promotion, instead of the
total quantity of the lines.

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0085830)
hgbot   
2016-04-21 13:34   
Repository: tools/automation/pi-mobile
Changeset: fb2935ce0e8b0fd893d2b7040a526aba420b4bcb
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 13:30:17 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb2935ce0e8b0fd893d2b7040a526aba420b4bcb [^]

Verifies issue 32596: [SERQA 871] Discount allocation by article: Inconsistency

Test I32596_AddProductNotCreateNewPack has been added.

Some changes are require for the test I28120_SameProductInTwoPacks to reflect
the changes in the rule.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28120_SameProductInTwoPacks.java
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/discountsandpromotions/I32596_AddProductNotCreateNewPack.java
---