Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032580Retail ModulesWeb POSpublic2016-04-04 12:572016-05-17 09:33
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032580: order by is missing in ProductCharacteristicValue model
DescriptionIn the query executed to load the model ProductCharacteristicValue, is missing a order by criteria.

When this model has got more than 35.000 records, two or more requests are done to backend to retrieve the data (in batchs of 35.000 records).
In some cases, the second request is returning records included in the first request.

It is important that it should be checked in all models, not only ProductCharacteristicValue
Steps To Reproduceit has been reproduced in postgres 9.3.4

in one instance with more than 35.000 product characteristic value:
. do login

error is returned:
OG.Dal.insertData: model insert 'ProductCharacteristicValue': SQLError: code: 6, message: could not execute statement duet to a constraint failure (19 UNIQUE constaint failed: m_proudct_ch_value.m_product_ch_value_id);
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032664RR16Q2 closed ranjith_qualiantech_com order by is missing in ProductCharacteristicValue model 
depends on backport 0032665RR16Q1.1 closed ranjith_qualiantech_com order by is missing in ProductCharacteristicValue model 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-04 12:57malsasuaNew Issue
2016-04-04 12:57malsasuaAssigned To => Retail
2016-04-04 12:57malsasuaOBNetwork customer => Yes
2016-04-04 12:57malsasuaResolution time => 1463608800
2016-04-04 12:57malsasuaTriggers an Emergency Pack => No
2016-04-04 13:52OrekariaStatusnew => acknowledged
2016-04-06 15:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-04-06 15:19ranjith_qualiantech_comStatusacknowledged => scheduled
2016-04-07 10:49hgbotCheckin
2016-04-07 10:49hgbotNote Added: 0085477
2016-04-07 10:49hgbotStatusscheduled => resolved
2016-04-07 10:49hgbotResolutionopen => fixed
2016-04-07 10:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12d6c5a3c4a5b1880577e143d0e91b4b83aa2834 [^]
2016-04-13 17:11OrekariaStatusresolved => new
2016-04-13 17:11OrekariaResolutionfixed => open
2016-04-14 11:29OrekariaStatusnew => scheduled
2016-04-14 11:29OrekariaStatusscheduled => resolved
2016-04-14 11:29OrekariaResolutionopen => fixed
2016-04-20 12:05ranjith_qualiantech_comNote Added: 0085774
2016-04-20 12:05ranjith_qualiantech_comStatusresolved => new
2016-04-20 12:05ranjith_qualiantech_comResolutionfixed => open
2016-04-20 12:05ranjith_qualiantech_comStatusnew => scheduled
2016-04-28 07:49hgbotCheckin
2016-04-28 07:49hgbotNote Added: 0086036
2016-04-28 07:49hgbotStatusscheduled => resolved
2016-04-28 07:49hgbotResolutionopen => fixed
2016-04-28 07:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12d6c5a3c4a5b1880577e143d0e91b4b83aa2834 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8e430de95b267732a649d1207414f352870f4644 [^]
2016-05-17 09:33migueldejuanaNote Added: 0086485
2016-05-17 09:33migueldejuanaReview Assigned To => migueldejuana
2016-05-17 09:33migueldejuanaStatusresolved => closed

Notes
(0085477)
hgbot   
2016-04-07 10:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12d6c5a3c4a5b1880577e143d0e91b4b83aa2834
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 07 14:18:24 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12d6c5a3c4a5b1880577e143d0e91b4b83aa2834 [^]

Fixes issue 32580 : Adding Order by clause in ProductCharacteristicValue

---
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
---
(0085774)
ranjith_qualiantech_com   
2016-04-20 12:05   
Order by has to be added in other models which are missed in posterminal module
(0086036)
hgbot   
2016-04-28 07:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8e430de95b267732a649d1207414f352870f4644
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 28 11:16:18 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8e430de95b267732a649d1207414f352870f4644 [^]

Fixes issue 32580 : Added missing order by clause to models

---
M src/org/openbravo/retail/posterminal/master/DiscountFilterBusinessPartner.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterBusinessPartnerGroup.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProduct.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterProductCategory.java
M src/org/openbravo/retail/posterminal/master/DiscountFilterRole.java
M src/org/openbravo/retail/posterminal/master/OfferPriceList.java
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductBOM.java
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRule.java
M src/org/openbravo/retail/posterminal/master/ServicePriceRuleRangePrices.java
M src/org/openbravo/retail/posterminal/master/TaxCategoryBOM.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
M src/org/openbravo/retail/posterminal/master/TaxZoneProperties.java
M src/org/openbravo/retail/posterminal/term/ApprovalReason.java
M src/org/openbravo/retail/posterminal/term/CashCloseReport.java
---
(0086485)
migueldejuana   
2016-05-17 09:33   
Tested and reviewed in ec98fed2ca51