Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032536Openbravo ERP09. Financial managementpublic2016-03-22 18:582016-06-17 19:36
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket41123
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032536: Not all defined organizations for a role available in Balance Sheet and PL Structure window
DescriptionProblem is that "GeneralAccountingReports.java" is using "orglist" column of ad_role table to check list of organizations. This column is defined as VARCHAR(2000) so in case a role has access to a large number of organizations this length is not enough
Steps To ReproduceIn an environment with 125 orgs defined, in case a role has access to all of them then length is not enough. I can provide environment where problem can be reviewed
Proposed SolutionorgList variable in GeneralAccountingReports.java should be calculated using DAL instead of checking this column:

String[] orgList = OBContext.getOBContext().getRole().getOrganizationList().split(",");
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-22 18:58maiteNew Issue
2016-03-22 18:58maiteAssigned To => Triage Finance
2016-03-22 18:58maiteOBNetwork customer => Yes
2016-03-22 18:58maiteModules => Core
2016-03-22 18:58maiteSupport ticket => 41123
2016-03-22 18:58maiteResolution time => 1459288800
2016-03-22 18:58maiteTriggers an Emergency Pack => No
2016-03-22 18:59maiteIssue Monitored: networkb
2016-04-01 14:07AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2016-04-01 14:07AtulOpenbravoStatusnew => scheduled
2016-04-04 10:10aferrazRelationship deleteddepends on 0032574
2016-04-04 10:11aferrazTarget Version3.0PR16Q2 =>
2016-04-05 13:12psanjuanNote Added: 0085440
2016-04-05 19:08hgbotCheckin
2016-04-05 19:08hgbotNote Added: 0085456
2016-04-05 19:08hgbotStatusscheduled => resolved
2016-04-05 19:08hgbotResolutionopen => fixed
2016-04-05 19:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3889670232a08143997596a504a696b12d0d86f4 [^]
2016-04-05 19:08hgbotCheckin
2016-04-05 19:08hgbotNote Added: 0085457
2016-04-05 19:08aferrazReview Assigned To => aferraz
2016-04-05 19:08aferrazNote Added: 0085458
2016-04-05 19:08aferrazStatusresolved => closed
2016-04-05 19:08aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:36hudsonbotCheckin
2016-06-17 19:36hudsonbotNote Added: 0087429
2016-06-17 19:36hudsonbotCheckin
2016-06-17 19:36hudsonbotNote Added: 0087430

Notes
(0085440)
psanjuan   
2016-04-05 13:12   
Issue verified and reviewed.

Organizations are being shown properly in customer environment.

Fix ready to be code reviewed and closed.

Please check also what Maite pointed out in the issue. Check if "orglist" column is being used by other report to retrieve organization tree. If that is the case we should open another issue and also fix it.
(0085456)
hgbot   
2016-04-05 19:08   
Repository: erp/devel/pi
Changeset: 3889670232a08143997596a504a696b12d0d86f4
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Apr 04 10:41:45 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/3889670232a08143997596a504a696b12d0d86f4 [^]

Fixes Issue 32536: Organizations not available in BalanceSheet and PL Structure

Organization list is fetched using query instead of column orglist

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0085457)
hgbot   
2016-04-05 19:08   
Repository: erp/devel/pi
Changeset: 5c55a5c4df1bf12ddca9372604c8f3596867130b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 05 17:33:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5c55a5c4df1bf12ddca9372604c8f3596867130b [^]

Related to issue 32536: Code review improvements

Avoid using orglist column also in SL_ProductPrice_PriceListVersion class.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_ProductPrice_PriceListVersion.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0085458)
aferraz   
2016-04-05 19:08   
Code review OK
(0087429)
hudsonbot   
2016-06-17 19:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087430)
hudsonbot   
2016-06-17 19:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test