Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0032536 | Openbravo ERP | 09. Financial management | public | 2016-03-22 18:58 | 2016-06-17 19:36 |
|
| Reporter | maite | |
| Assigned To | AtulOpenbravo | |
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR16Q3 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0032536: Not all defined organizations for a role available in Balance Sheet and PL Structure window |
| Description | Problem is that "GeneralAccountingReports.java" is using "orglist" column of ad_role table to check list of organizations. This column is defined as VARCHAR(2000) so in case a role has access to a large number of organizations this length is not enough |
| Steps To Reproduce | In an environment with 125 orgs defined, in case a role has access to all of them then length is not enough. I can provide environment where problem can be reviewed |
| Proposed Solution | orgList variable in GeneralAccountingReports.java should be calculated using DAL instead of checking this column:
String[] orgList = OBContext.getOBContext().getRole().getOrganizationList().split(","); |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-03-22 18:58 | maite | New Issue | |
| 2016-03-22 18:58 | maite | Assigned To | => Triage Finance |
| 2016-03-22 18:58 | maite | Modules | => Core |
| 2016-03-22 18:58 | maite | Resolution time | => 1459288800 |
| 2016-03-22 18:58 | maite | Triggers an Emergency Pack | => No |
| 2016-03-22 18:59 | maite | Issue Monitored: networkb | |
| 2016-04-01 14:07 | AtulOpenbravo | Assigned To | Triage Finance => AtulOpenbravo |
| 2016-04-01 14:07 | AtulOpenbravo | Status | new => scheduled |
| 2016-04-04 10:10 | aferraz | Relationship deleted | depends on 0032574 |
| 2016-04-04 10:11 | aferraz | Target Version | 3.0PR16Q2 => |
| 2016-04-05 13:12 | psanjuan | Note Added: 0085440 | |
| 2016-04-05 19:08 | hgbot | Checkin | |
| 2016-04-05 19:08 | hgbot | Note Added: 0085456 | |
| 2016-04-05 19:08 | hgbot | Status | scheduled => resolved |
| 2016-04-05 19:08 | hgbot | Resolution | open => fixed |
| 2016-04-05 19:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3889670232a08143997596a504a696b12d0d86f4 [^] |
| 2016-04-05 19:08 | hgbot | Checkin | |
| 2016-04-05 19:08 | hgbot | Note Added: 0085457 | |
| 2016-04-05 19:08 | aferraz | Review Assigned To | => aferraz |
| 2016-04-05 19:08 | aferraz | Note Added: 0085458 | |
| 2016-04-05 19:08 | aferraz | Status | resolved => closed |
| 2016-04-05 19:08 | aferraz | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-17 19:36 | hudsonbot | Checkin | |
| 2016-06-17 19:36 | hudsonbot | Note Added: 0087429 | |
| 2016-06-17 19:36 | hudsonbot | Checkin | |
| 2016-06-17 19:36 | hudsonbot | Note Added: 0087430 | |
|
Notes |
|
|
|
Issue verified and reviewed.
Organizations are being shown properly in customer environment.
Fix ready to be code reviewed and closed.
Please check also what Maite pointed out in the issue. Check if "orglist" column is being used by other report to retrieve organization tree. If that is the case we should open another issue and also fix it. |
|
|
|
(0085456)
|
|
hgbot
|
|
2016-04-05 19:08
|
|
Repository: erp/devel/pi
Changeset: 3889670232a08143997596a504a696b12d0d86f4
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Apr 04 10:41:45 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/3889670232a08143997596a504a696b12d0d86f4 [^]
Fixes Issue 32536: Organizations not available in BalanceSheet and PL Structure
Organization list is fetched using query instead of column orglist
---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
|
|
|
|
(0085457)
|
|
hgbot
|
|
2016-04-05 19:08
|
|
Repository: erp/devel/pi
Changeset: 5c55a5c4df1bf12ddca9372604c8f3596867130b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Apr 05 17:33:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5c55a5c4df1bf12ddca9372604c8f3596867130b [^]
Related to issue 32536: Code review improvements
Avoid using orglist column also in SL_ProductPrice_PriceListVersion class.
---
M src/org/openbravo/erpCommon/ad_callouts/SL_ProductPrice_PriceListVersion.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|