Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032495Openbravo ERPA. Platformpublic2016-03-16 17:292016-08-11 18:40
ReporterJONHM 
Assigned ToNaroaIriarte 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket42522
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032495: Process creating multiple product lines while pressing several times "OK" button
DescriptionProcess "Create Lines From" is creating multiple product lines while pressing several times "OK" button in environments with slow internet connections. This action creates data inconsistency.
Steps To Reproduce** First of all create a slow environment to work (In Chrome Developer Tools, choose GPRS as Network throttling)
1) Enter a new line in "Purchase Invoice" window
2) Create lines from another one
3) Select some line and press several times "OK" button before the process ends
- The result is having multiple lines of the same product
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027797main closed AtulOpenbravo Create from shipment window does not let you to click in OK if you have tried before to click it without filling mandatory field 
Attached Files? issue32495.export (1,996) 2016-06-28 15:28
https://issues.openbravo.com/file_download.php?file_id=9593&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-16 17:29JONHMNew Issue
2016-03-16 17:29JONHMAssigned To => platform
2016-03-16 17:29JONHMOBNetwork customer => Yes
2016-03-16 17:29JONHMModules => Core
2016-03-16 17:29JONHMSupport ticket => 40986
2016-03-16 17:29JONHMResolution time => 1460325600
2016-03-16 17:29JONHMTriggers an Emergency Pack => No
2016-03-18 11:11alostaleStatusnew => acknowledged
2016-03-22 10:20alostaleTarget Version3.0PR16Q2 =>
2016-04-06 10:31alostaleStatusacknowledged => scheduled
2016-04-06 10:31alostaleAssigned Toplatform => NaroaIriarte
2016-04-11 12:33NaroaIriarteNote Added: 0085564
2016-04-11 12:33NaroaIriarteAssigned ToNaroaIriarte => JONHM
2016-04-11 12:33NaroaIriarteStatusscheduled => feedback
2016-06-21 10:09JONHMAssigned ToJONHM => NaroaIriarte
2016-06-21 10:14JONHMSupport ticket40986 => 42522
2016-06-21 10:14JONHMResolution time1460325600 => 1469397600
2016-06-21 10:14JONHMSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12437#r12437
2016-06-21 10:15JONHMNote Added: 0087706
2016-06-21 10:15JONHMSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12438#r12438
2016-06-27 12:31JONHMStatusfeedback => new
2016-06-27 13:11NaroaIriarteStatusnew => scheduled
2016-06-28 15:28NaroaIriarteFile Added: issue32495.export
2016-06-28 15:29NaroaIriarteNote Added: 0088050
2016-06-28 18:57caristuTarget Version => 3.0PR16Q4
2016-07-04 12:38hgbotCheckin
2016-07-04 12:38hgbotNote Added: 0088173
2016-07-04 12:38hgbotStatusscheduled => resolved
2016-07-04 12:38hgbotResolutionopen => fixed
2016-07-04 12:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/328f7e776b68c363727df63279c08f3f0c545dbf [^]
2016-07-07 09:17NaroaIriarteReview Assigned To => alostale
2016-07-08 09:19alostaleNote Added: 0088320
2016-07-08 09:19alostaleStatusresolved => closed
2016-07-08 09:19alostaleFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088986
2018-11-06 17:13rafarodaRelationship addedrelated to 0027797

Notes
(0085564)
NaroaIriarte   
2016-04-11 12:33   
I have not been able to reproduce this issue.
(0087706)
JONHM   
2016-06-21 10:15   
Steps to reproduce have been updated
(0088050)
NaroaIriarte   
2016-06-28 15:29   
The fix is attached to the issue.
(0088173)
hgbot   
2016-07-04 12:38   
Repository: erp/devel/pi
Changeset: 328f7e776b68c363727df63279c08f3f0c545dbf
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Jun 28 13:22:34 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/328f7e776b68c363727df63279c08f3f0c545dbf [^]

Fixed issue 32495: The "Create Lines From" process is fixed.

The "Create Lines From" process was creating multiple product lines when the
OK button was pressed several times. This could be reproducuble in environments
with slow internet connections in those environments the OK button could be clicked
a lot of times. This was not correct, the OK button should be disabled after pressing
it the first time.
The "submitThisPage" function of the "CreateFrom_Invoice.html" has been changed. Now,
in this function the buttons clicked are disabled and thanks to this, the OK button is
unable to be clicked again after the first time.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice.html
---
(0088320)
alostale   
2016-07-08 09:19   
code reviewed + tested
(0088986)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test