Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032486Retail ModulesWeb POSpublic2016-03-15 18:272016-03-30 10:15
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032486: Stabilization: SynchronizationHelper should wrap the asynchronous calls since the Done button is tapped till receipt is closed
DescriptionStabilization: SynchronizationHelper should wrap the asynchronous calls since the Done button is tapped till receipt is closed
Steps To ReproduceIn the ob-synchronization.js file
Set the verbose value to true

Create a sale, start the paying process, stop when the done button is shown

Go to the console, clean the log

Tap the Done button

Verify that the SynchronizationHelper enters a 'synchronized' state before the receipt has been closed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-15 18:27OrekariaNew Issue
2016-03-15 18:27OrekariaAssigned To => Orekaria
2016-03-15 18:27OrekariaTriggers an Emergency Pack => No
2016-03-15 18:28OrekariaStatusnew => scheduled
2016-03-15 18:47OrekariaSummaryStabilization: SynchronizationHelper should wrap the asynchronous calls since the Done button is tapped till receipt is close => Stabilization: SynchronizationHelper should wrap the asynchronous calls since the Done button is tapped till receipt is closed
2016-03-15 18:47OrekariaDescription Updatedbug_revision_view_page.php?rev_id=11454#r11454
2016-03-15 18:56hgbotCheckin
2016-03-15 18:56hgbotNote Added: 0084995
2016-03-15 18:56hgbotStatusscheduled => resolved
2016-03-15 18:56hgbotResolutionopen => fixed
2016-03-15 18:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3cd41b0ee82705f2abefa6e7e01c380599396a3a [^]
2016-03-30 10:15marvintmReview Assigned To => marvintm
2016-03-30 10:15marvintmStatusresolved => closed
2016-03-30 10:15marvintmFixed in Version => RR16Q2

Notes
(0084995)
hgbot   
2016-03-15 18:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3cd41b0ee82705f2abefa6e7e01c380599396a3a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Mar 15 18:46:47 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3cd41b0ee82705f2abefa6e7e01c380599396a3a [^]

Fixes issue 32486: The SynchronizationHelper wraps the calls since the Done button is tapped until the receipt is closed

The problem is that, depending on the performance of the terminal and/or the quick the user is, receipt data can be corrupted because the closing receipt can get data from another new receipt being created

Also there are collateral changes applied:
- the errorCallback in the multiorders flow has been activated
- when paying with credit, the paymentDone event is triggered after the business partner has been updated

Note that:
- existing or new popups not considering this wraps, can cause the application to fail to halt

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalcreditsales.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---