Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032467Retail ModulesBest Deal Casepublic2016-03-14 09:382016-04-28 10:07
Reportermalsasua 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032467: Best Deal Case is removing one line
Descriptionwhen the BDC is executed with one combinations of products, one of the lines is removed
Steps To Reproduce(check private note)
It is reproducible in customer environment.

Add several lines
click in total button
one line is removed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0032490 closed jorge-garcia [SERQA 800] A line in a receipt is deleted when working with best deal case and there are discounts for all lines in the receipt 
related to defect 0032379 closed jorge-garcia If Best Deal Case and Discount by total are installed it is not refreshing the amounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-14 09:38malsasuaNew Issue
2016-03-14 09:38malsasuaAssigned To => Retail
2016-03-14 09:38malsasuaResolution time => 1458082800
2016-03-14 09:38malsasuaTriggers an Emergency Pack => No
2016-03-14 10:04OrekariaStatusnew => acknowledged
2016-03-15 08:44jorge-garciaStatusacknowledged => scheduled
2016-03-15 08:44jorge-garciaAssigned ToRetail => jorge-garcia
2016-03-15 13:41OrekariaRelationship addedrelated to 0032379
2016-03-15 17:59jorge-garciaNote Added: 0084993
2016-03-15 17:59jorge-garciaAssigned Tojorge-garcia => malsasua
2016-03-15 17:59jorge-garciaStatusscheduled => feedback
2016-03-15 18:00jorge-garciaNote Edited: 0084993bug_revision_view_page.php?bugnote_id=0084993#r11452
2016-03-17 15:14jorge-garciaRelationship addedduplicate of 0032490
2016-03-17 15:14jorge-garciaStatusfeedback => scheduled
2016-03-17 15:14jorge-garciaAssigned Tomalsasua => jorge-garcia
2016-03-21 17:54marvintmRelationship replacedhas duplicate 0032490
2016-04-07 16:26hgbotCheckin
2016-04-07 16:26hgbotNote Added: 0085495
2016-04-13 11:35hgbotCheckin
2016-04-13 11:35hgbotNote Added: 0085592
2016-04-13 12:58hgbotCheckin
2016-04-13 12:58hgbotNote Added: 0085603
2016-04-18 10:42marvintmStatusscheduled => resolved
2016-04-18 10:42marvintmResolutionopen => fixed
2016-04-28 10:07marvintmReview Assigned To => marvintm
2016-04-28 10:07marvintmStatusresolved => closed
2016-04-28 10:07marvintmFixed in Version => RR16Q3

Notes
(0084993)
jorge-garcia   
2016-03-15 17:59   
(edited on: 2016-03-15 18:00)
Can't be reproduced with the database from the client at date 14-03-2016.

Waiting response from the client about a possible change in the backend configuration between 12-03-2016 and 14-03-2016.
(0085495)
hgbot   
2016-04-07 16:26   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 469438c9db9088572804fe1a455482e621a5c2e8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Mar 18 08:35:15 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/469438c9db9088572804fe1a455482e621a5c2e8 [^]

Fixe issue 32467: Best Deal Case is removing one line

The problem happens when there a line with a promotion candidates but couldn't
have a applied promotion, and other line has a better promotion to be applied.

The solution is to add those lines with a promotion but not aplicable to the
nonCandidatesProducts array to be added at the end of the calculation.

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0085592)
hgbot   
2016-04-13 11:35   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 33ff7f46d188494b324b4cca3cc2aab3129bf03b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Apr 11 10:20:55 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/33ff7f46d188494b324b4cca3cc2aab3129bf03b [^]

Fixe issue 32467: Best Deal Case is removing one line

The problem happens when there a line with a promotion candidates but couldn't
have a applied promotion, and other line has a better promotion to be applied.

The solution is to add those lines with a promotion but not aplicable to the
nonCandidatesProducts array to be added at the end of the calculation.

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0085603)
hgbot   
2016-04-13 12:58   
Repository: tools/automation/pi-mobile
Changeset: d49ab43f7b3d3e639a6bb553a12f2b8a84868e1b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Mar 30 13:02:23 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d49ab43f7b3d3e639a6bb553a12f2b8a84868e1b [^]

Verifies issue 32467: Best Deal Case is removing one line

Added test I32467_BestDealNotDeletingLines.

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32467_BestDealNotDeletingLines.java
---