Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032466Retail ModulesWeb POSpublic2016-03-11 16:242016-04-22 17:20
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4.6Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032466: When using Void Layaway, it's possible that triggers in the application may be disabled
DescriptionThe Void Layaway process disables the triggers to be able to process the transactions correctly. This in itself is not necessarily wrong.

However, due to the way the database transaction is handled in this case, it is possible that in some circumstances, during an extremely short period of time, the triggers may be disabled for all users.

Steps To ReproduceIt's not really possible at this point to reproduce this problem reliably (as a matter of fact, we haven't seen it happen even once). This issue as of now is mainly theoretical, but possible in theory looking at the code. However, we don't have specific steps to reproduce it.
Proposed SolutionThe database transaction should not be committed before triggers are enabled again.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032464RR16Q2 closed marvintm When using Void Layaway, it's possible that triggers in the application may be disabled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-11 16:24marvintmTypedefect => backport
2016-03-11 16:24marvintmTarget VersionRR16Q2 => RR15Q4.6
2016-04-22 09:16hgbotCheckin
2016-04-22 09:16hgbotNote Added: 0085871
2016-04-22 09:16hgbotStatusscheduled => resolved
2016-04-22 09:16hgbotResolutionopen => fixed
2016-04-22 09:16hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4.6/org.openbravo.retail.posterminal/rev/4d466fd004c81a6f39039b1cf965c5532fc9002d [^]
2016-04-22 13:18migueldejuanaReview Assigned To => migueldejuana
2016-04-22 13:18migueldejuanaNote Added: 0085891
2016-04-22 13:18migueldejuanaStatusresolved => closed
2016-04-22 17:20hgbotCheckin
2016-04-22 17:20hgbotNote Added: 0085908

Notes
(0085871)
hgbot   
2016-04-22 09:16   
Repository: retail/backports/3.0RR15Q4.6/org.openbravo.retail.posterminal
Changeset: 4d466fd004c81a6f39039b1cf965c5532fc9002d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Apr 22 09:15:40 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.6/org.openbravo.retail.posterminal/rev/4d466fd004c81a6f39039b1cf965c5532fc9002d [^]

Fixed issue 32466. Triggers will never be disabled for all users anymore.
The transaction will no longer be committed while the triggers are disabled, so it will no longer be possible for other users to be affected by this.

---
M src/org/openbravo/retail/posterminal/ProcessVoidLayaway.java
---
(0085891)
migueldejuana   
2016-04-22 13:18   
Reviewed in RR15Q4.6
(0085908)
hgbot   
2016-04-22 17:20   
Repository: retail/backports/3.0RR15Q4.6/org.openbravo.retail.posterminal
Changeset: 42af4b54c6e2e3f26bb98ad1d8e35d6ac115675e
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Fri Apr 22 17:19:56 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.6/org.openbravo.retail.posterminal/rev/42af4b54c6e2e3f26bb98ad1d8e35d6ac115675e [^]

Related to issue 32466. Related to issue 32761. Fixed copyright year.

---
M src/org/openbravo/retail/posterminal/ProcessVoidLayaway.java
M src/org/openbravo/retail/posterminal/importprocess/VoidLayawayEntryProcessor.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---