Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032464Retail ModulesWeb POSpublic2016-03-11 16:242016-03-21 18:25
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2Fixed in VersionRR16Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032464: When using Void Layaway, it's possible that triggers in the application may be disabled
DescriptionThe Void Layaway process disables the triggers to be able to process the transactions correctly. This in itself is not necessarily wrong.

However, due to the way the database transaction is handled in this case, it is possible that in some circumstances, during an extremely short period of time, the triggers may be disabled for all users.

Steps To ReproduceIt's not really possible at this point to reproduce this problem reliably (as a matter of fact, we haven't seen it happen even once). This issue as of now is mainly theoretical, but possible in theory looking at the code. However, we don't have specific steps to reproduce it.
Proposed SolutionThe database transaction should not be committed before triggers are enabled again.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031462 closed mario_castello [RR15Q4] The status of a layaway does not change after 'Void this layaway' 
related to defect 0031150 closed marvintm Triggers stay disabled when a layaway is voided with pending payments 
depends on backport 0032465RR16Q1.1 closed marvintm When using Void Layaway, it's possible that triggers in the application may be disabled 
depends on backport 0032466RR15Q4.6 closed marvintm When using Void Layaway, it's possible that triggers in the application may be disabled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-11 16:24marvintmNew Issue
2016-03-11 16:24marvintmAssigned To => marvintm
2016-03-11 16:24marvintmOBNetwork customer => No
2016-03-11 16:24marvintmTriggers an Emergency Pack => No
2016-03-11 16:24marvintmStatusnew => scheduled
2016-03-11 16:27marvintmRelationship addedrelated to 0031462
2016-03-11 16:28marvintmRelationship addedrelated to 0031150
2016-03-11 18:11hgbotCheckin
2016-03-11 18:11hgbotNote Added: 0084924
2016-03-11 18:11hgbotStatusscheduled => resolved
2016-03-11 18:11hgbotResolutionopen => fixed
2016-03-11 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f4f90c7de0e89f5813a9a65e049335b04f40f64 [^]
2016-03-21 18:25guilleaerReview Assigned To => guilleaer
2016-03-21 18:25guilleaerStatusresolved => closed
2016-03-21 18:25guilleaerFixed in Version => RR16Q2

Notes
(0084924)
hgbot   
2016-03-11 18:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3f4f90c7de0e89f5813a9a65e049335b04f40f64
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Fri Mar 11 17:41:33 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f4f90c7de0e89f5813a9a65e049335b04f40f64 [^]

Fixed issue 32464. Triggers will never be disabled for all users anymore.
The transaction will no longer be committed while the triggers are disabled, so it will no longer be possible for other users to be affected by this.

---
M src/org/openbravo/retail/posterminal/ProcessVoidLayaway.java
---