Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032437Openbravo ERP07. Sales managementpublic2016-03-07 16:562016-03-10 20:36
Reporterngarcia 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-07-16
Regression introduced in release3.0PR15Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8860b648abb2 [^]
Triggers an Emergency PackNo
Summary0032437: Wrong Tax Amount and Total Gross Amount in orders created by the Copy Record process if price list includes taxes
DescriptionWrong Tax Amount and Total Gross Amount in orders created by the Copy Record process if price list includes taxes
Steps To ReproduceAs group admin role:
   Create a Sales Price List
   Set it as Price Includes Tax
   Add a version and a product to it
   Create a Sales Order with that price list and product and book it
   Click on the Copy record button of the toolbar and check the Total Gross Amount field of the status bar is wrong
   The tax amount of the tax tab is also wrong
   Book it and check the values do not change
   Repeat the process in the purchase flow and check the problem is also reproducible
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032428 closed markmm82 Wrong Tax Amount and Total Gross Amount in orders created by the Copy Record process if price list includes taxes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-08 18:17aferrazTypedefect => backport
2016-03-08 18:17aferrazTarget Version => 3.0PR16Q1
2016-03-09 18:40markmm82Note Added: 0084852
2016-03-10 20:36hgbotCheckin
2016-03-10 20:36hgbotNote Added: 0084887
2016-03-10 20:36hgbotStatusscheduled => resolved
2016-03-10 20:36hgbotResolutionopen => fixed
2016-03-10 20:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/44e1aca856d34c06c68725cc18c3ca3463401c6a [^]
2016-03-10 20:36hgbotCheckin
2016-03-10 20:36hgbotNote Added: 0084888
2016-03-10 20:36aferrazReview Assigned To => aferraz
2016-03-10 20:36aferrazNote Added: 0084889
2016-03-10 20:36aferrazStatusresolved => closed
2016-03-10 20:36aferrazFixed in Version => 3.0PR16Q1

Notes
(0084852)
markmm82   
2016-03-09 18:40   
Test plan:
As group admin role:
   Create a Sales Price List
   Set it as Price Includes Tax
   Add a version and a product to it
   Create a Sales Order with that price list and product and book it
   Click on the Copy record button of the toolbar and check the Total Gross Amount field of the status bar are the same like the original.
   The tax amount of the tax tab is also right
   Book it and check the values do not change (everything was calculated where cloning, including taxes)
   Repeat the process in the purchase flow and check the problem is also corrected.
(0084887)
hgbot   
2016-03-10 20:36   
Repository: erp/backports/3.0PR16Q1
Changeset: 44e1aca856d34c06c68725cc18c3ca3463401c6a
Author: Mark <m.molina <at> nectus.com>
Date: Wed Mar 09 18:53:24 2016 -0500
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/44e1aca856d34c06c68725cc18c3ca3463401c6a [^]

Fixes issue 32437: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
---
(0084888)
hgbot   
2016-03-10 20:36   
Repository: erp/backports/3.0PR16Q1
Changeset: f5662292ac13119d6ff90bd31dc8be101a647fba
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Mar 10 17:56:11 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/f5662292ac13119d6ff90bd31dc8be101a647fba [^]

Related to issue 32437: Code review improvements

Use BigDecimal.ZERO instead of new BigDecimal(0).

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
---
(0084889)
aferraz   
2016-03-10 20:36   
Code review + Testing OK