Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0032434 | Openbravo ERP | Z. Others | public | 2016-03-08 13:05 | 2016-03-23 21:50 |
|
| Reporter | maite | |
| Assigned To | markmm82 | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR16Q2 | Fixed in Version | 3.0PR16Q2 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | |
| Web browser | |
| Modules | Advanced Payables and Receivables Mngmt |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0032434: Wrong Exchange Rate set in Payment created from "Set New currency" process, when converting existent credit |
| Description | "Set new currency" process offers possibility to define GL Item and automatically create payments described in following article: http://wiki.openbravo.com/wiki/How_to_convert_credit_to_a_different_currency [^]
Payment that generates credit in new currency has wrong Exchange Rate so payment's accounting entry is not properly converted |
| Steps To Reproduce | 0. Access "Cuenta de Banco" financial account and configure "Transferencia" payment method as "Make payments in multiple currencies", Automatic Withdrawn=NO and Upon Payment Use=In Transit Payment Account
1. Register new Payment Out for Bebidas Alegres, set Generated Credit=150 and currency EUR and process. Credit will be generated
2. Register new Payment Out for Bebidas Alegres, set Generated Credit=300 and currency USD and process. Error will be raised, which is correct
3. Access "Bebidas Alegres" business partner and run "Set new currency" process. Set USD currency and select GL Item. Process
4. Access to Payment Out window and realize that 3 payments have been created (according with following information: http://wiki.openbravo.com/wiki/How_to_convert_credit_to_a_different_currency [^])
5. Access payment created in USD currency, which is the one generating credit in new currency and with a negative detail related to gl item and realize that "Exchange Rate" has been set to 1 instead of default's rate (which is 0.917431 for payment's date 08-03-2016)
NOTE: in case you post all involved payments you can see that difference is found in gl item account when balance should be zero
NOTE2: if you manually create identical Payment Out document you can see that proper Exchange Rate is set |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0030077 | 3.0PR15Q4 | closed | aferraz | Customer Balance not working properly with multicurrency credit |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-03-08 13:05 | maite | New Issue | |
| 2016-03-08 13:05 | maite | Assigned To | => Triage Finance |
| 2016-03-08 13:05 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2016-03-08 13:05 | maite | Resolution time | => 1459634400 |
| 2016-03-08 13:05 | maite | Triggers an Emergency Pack | => No |
| 2016-03-08 13:06 | maite | Issue Monitored: networkb | |
| 2016-03-08 13:09 | maite | Relationship added | related to 0030077 |
| 2016-03-09 17:24 | markmm82 | Status | new => scheduled |
| 2016-03-09 17:24 | markmm82 | Assigned To | Triage Finance => markmm82 |
| 2016-03-11 16:23 | markmm82 | Note Added: 0084922 | |
| 2016-03-15 15:21 | psanjuan | Note Added: 0084988 | |
| 2016-03-15 15:23 | psanjuan | Note Edited: 0084988 | bug_revision_view_page.php?bugnote_id=0084988#r11440 |
| 2016-03-15 15:28 | psanjuan | Note Edited: 0084988 | bug_revision_view_page.php?bugnote_id=0084988#r11441 |
| 2016-03-15 15:41 | psanjuan | Note Edited: 0084988 | bug_revision_view_page.php?bugnote_id=0084988#r11444 |
| 2016-03-15 15:44 | psanjuan | Note Edited: 0084988 | bug_revision_view_page.php?bugnote_id=0084988#r11445 |
| 2016-03-16 18:33 | markmm82 | Note Added: 0085017 | |
| 2016-03-17 12:26 | psanjuan | Note Edited: 0084988 | bug_revision_view_page.php?bugnote_id=0084988#r11478 |
| 2016-03-17 12:41 | psanjuan | Note Added: 0085200 | |
| 2016-03-17 12:41 | psanjuan | Note Edited: 0085200 | bug_revision_view_page.php?bugnote_id=0085200#r11480 |
| 2016-03-17 12:52 | psanjuan | Note Edited: 0085200 | bug_revision_view_page.php?bugnote_id=0085200#r11481 |
| 2016-03-22 20:34 | hgbot | Checkin | |
| 2016-03-22 20:34 | hgbot | Note Added: 0085269 | |
| 2016-03-22 20:34 | hgbot | Status | scheduled => resolved |
| 2016-03-22 20:34 | hgbot | Resolution | open => fixed |
| 2016-03-22 20:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/05ebc1f592f51a0c271f0e5f127489bc95750364 [^] |
| 2016-03-22 20:34 | aferraz | Review Assigned To | => aferraz |
| 2016-03-22 20:34 | aferraz | Note Added: 0085270 | |
| 2016-03-22 20:34 | aferraz | Status | resolved => closed |
| 2016-03-22 20:34 | aferraz | Fixed in Version | => 3.0PR16Q2 |
| 2016-03-23 21:50 | hudsonbot | Checkin | |
| 2016-03-23 21:50 | hudsonbot | Note Added: 0085302 | |
|
Notes |
|
|
|
Test Plan:
0. Access "Cuenta de Banco" financial account and configure "Transferencia" payment method as "Make payments in multiple currencies", Automatic Withdrawn=NO and Upon Payment Use=In Transit Payment Account
1. Register new Payment Out for Bebidas Alegres, set Generated Credit=150 and currency EUR and process. Credit will be generated
2. Register new Payment Out for Bebidas Alegres, set Generated Credit=300 and currency USD and process. Error will be raised, which is correct
3. Access "Bebidas Alegres" business partner and run "Set new currency" process. Set USD currency and select GL Item. Process
4. Access to Payment Out window and realize that 3 payments have been created (according with following information: http://wiki.openbravo.com/wiki/How_to_convert_credit_to_a_different_currency [^] [^])
5. Access payment created in USD currency, which is the one generating credit in new currency and with a negative detail related to gl item and realize that "Exchange Rate" has been set to the right exchange rate! |
|
|
|
(0084988)
|
|
psanjuan
|
2016-03-15 15:21
(edited on: 2016-03-17 12:26) |
|
Test Plan to verify the issue:
Create a BP in F&B España named "BP Credito Supplier", select a price list in EUR, for instance Tarifa Bebidas Alegres.
Go to payment out window and register a credit of 150.00 € for this BP. Post it.
Amount Left as credit 150 EUR
Posting for F&B España euro looks like:
DEBIT 150.00 (40700)
CREDIT 150.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1410)
CREDIT 225.00 (1140)
Go to BP window and change the currency of the BP just created to USD by using "Set New currency" process and selecting below options:
Currency = USD
Use default conversion rate = yes
G/L item - select a GL Item for instance named "Currency Conversion".
Press Done.
Go to Payment out window and check that 3 payments have been created:
Payment 1 (ide. 10000471) GL Item : Currency Conversion. Posting looks like:
Posting for F&B España euro looks like:
DEBIT 150.00 (G/L item account)
CREDIT 150.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (G/L item account)
CREDIT 225.00 (1140)
Payment 2 (ie 1000472). Refunded payment 10000471, Amount refunded -150
Posting for F&B España euro looks like:
DEBIT 150.00 (55500)
CREDIT 150.00 (40700)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1140)
CREDIT 225.00 (1410)
Payment 3 in USD. (ie. 10000472) Amount left as credit -225.00 USD
Posting for F&B España euro looks like:
DEBIT 225.00 (40700)
CREDIT 225.00 (G/L item account)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1410)
CREDIT 225.00 (G/L item account)
Final posting for F&B International Group USD is correct:
DEBIT 225.00 (1410) Vendor Prepayment
CREDIT 225.00 (1140) Checking in Transfer
But final posting for F&B España EUR general ledger is not correct:
DEBIT 225.00 (40700)
CREDIT 150.00 (55500)
CREDIT 75.00 (G/l item)
Therefore correct posting of last payment should have been:
DEBIT 150.00 (225.00 USD x 0.66667 tc USD to €) (40700) Vendor Prepayment
CREDIT 150.00 (225.00 USD x 0.66667 tc USD to €) (G/L item account)
Therefore final posting for F&B España EUR is:
DEBIT 150.00 (40700)
CREDIT 150.00 (55500)
|
|
|
|
|
Test Plan:
0. Access "Cuenta de Banco" financial account and configure "Transferencia" payment method as "Make payments in multiple currencies", Automatic Withdrawn=NO and Upon Payment Use=In Transit Payment Account.
1. Check conversion rates between EUR and USD currencies. For instance: EUR - USD: 1.09; USD - EUR: 0.917431.
2. Create a BP in F&B España Región Norte named "BP Credito", select a price list in EUR, for instance Otros Servicios.
3. Go to payment out window and register a credit of 100.00 € for this BP. Post it.
(Payment 1000442) Amount Left as credit 100 EUR
4. Posting for F&B España euro looks like:
DEBIT 100.00 (40700)
CREDIT 100.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.09)
DEBIT 109.00 (1410)
CREDIT 109.00 (1140)
5. Go to BP window and change the currency of the BP just created to USD by using "Set New currency" process and selecting below options:
Currency = USD
Use default conversion rate = yes
G/L item - select a GL Item for instance named "Currency Conversion".
Press Done.
6. Go to Payment out window and check that 3 payments have been created:
Payment 1 (ide. 1000443) GL Item : Currency Conversion. Posting looks like:
Posting for F&B España euro looks like:
DEBIT 100.00 (G/L item account)
CREDIT 100.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.09)
DEBIT 109.00 (G/L item account: 6290 - Salaries)
CREDIT 109.00 (1140)
Payment 2 (ie 1000444). Refunded payment 1000443, Amount refunded -100
Posting for F&B España euro looks like:
DEBIT 100.00 (55500)
CREDIT 100.00 (40700)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.09)
DEBIT 109.00 (1140)
CREDIT 109.00 (1410)
Payment 3 in USD. (ie. 10000472) Amount left as credit 109.00 USD
Posting for F&B España euro looks like:
DEBIT 100.00 (40700)
CREDIT 100.00 (G/L item account: 64000 - Sueldos y salarios)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.09)
DEBIT 109.00 (1410)
CREDIT 109.00 (G/L item account)
All posting are correct! |
|
|
|
(0085200)
|
|
psanjuan
|
2016-03-17 12:41
(edited on: 2016-03-17 12:52) |
|
Test Plan to verify the issue:
Scenario 1 - Vendor currency EUR that changes to USD.
Create a BP in F&B España named "BP Credito Supplier", select a price list in EUR, for instance Tarifa Bebidas Alegres.
Go to payment out window and register a credit of 150.00 € for this BP. Post it.
Amount Left as credit 150 EUR
Posting for F&B España euro looks like:
DEBIT 150.00 (40700)
CREDIT 150.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1410)
CREDIT 225.00 (1140)
Go to BP window and change the currency of the BP just created to USD by using "Set New currency" process and selecting below options:
Currency = USD
Use default conversion rate = yes
G/L item - select a GL Item for instance named "Currency Conversion".
Press Done.
Go to Payment out window and check that 3 payments have been created:
Payment 1 (ide. 10000471) GL Item : Currency Conversion. Posting looks like:
Posting for F&B España euro looks like:
DEBIT 150.00 (G/L item account)
CREDIT 150.00 (55500)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (G/L item account)
CREDIT 225.00 (1140)
Payment 2 (ie 1000472). Refunded payment 10000471, Amount refunded -150
Posting for F&B España euro looks like:
DEBIT 150.00 (55500)
CREDIT 150.00 (40700)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1140)
CREDIT 225.00 (1410)
Payment 3 in USD. (ie. 10000472) Amount left as credit -225.00 USD
Posting for F&B España euro looks like:
DEBIT 150.00 (225.00 USD x 0.66667 tc USD to €) (40700) Vendor Prepayment
CREDIT 150.00 (225.00 USD x 0.66667 tc USD to €) (G/L item account)
Posting for F&B International Group USD looks like: (exchange rate eur - usd = 1.5)
DEBIT 225.00 (1410)
CREDIT 225.00 (G/L item account)
Final posting for F&B International Group USD is correct:
DEBIT 225.00 (1410) Vendor Prepayment
CREDIT 225.00 (1140) Checking in Transfer
Final posting for F&B España EUR is:
DEBIT 150.00 (40700)
CREDIT 150.00 (55500)
Check that current balance of the BP has changed from 150 EUR to 225 USD
Repeat same test for scenarios below:
Scenario 2 - Vendor currency USD that changes to EUR.
Check that current balance of the BP has changed from 225 USD to 150 EUR
Scenario 3 - Customer currency EUR that changes to USD.
Check that current balance of the BP has changed from -150 EUR to 225 USD
Scenario 4 - Customer currency USD that changes to EUR.
Check that current balance of the BP has changed from -225 USD to -150 EUR
|
|
|
|
(0085269)
|
|
hgbot
|
|
2016-03-22 20:34
|
|
Repository: erp/devel/pi
Changeset: 05ebc1f592f51a0c271f0e5f127489bc95750364
Author: Mark <m.molina <at> nectus.com>
Date: Wed Mar 16 13:15:55 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/05ebc1f592f51a0c271f0e5f127489bc95750364 [^]
Fixes issue 32434: Fixed Wrong Exchange Rate set in Payment created from "Set New currency" process.
Payment that generates credit in new currency was calculated with wrong Exchange Rate so payment's accounting
entry was not properly converted, it was fixed updating the transaction tax rate with the correct conversion between currencies.
---
M src/org/openbravo/common/actionhandler/SetNewBPCurrency.java
---
|
|
|
|
|
|
|
|
|
|