Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032429Openbravo ERPA. Platformpublic2016-03-07 18:332016-03-17 10:56
Reporterngarcia 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket41002
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032429: Add error log in the remove function of DefaultJsonDataService class
DescriptionAdd error log in the remove function of DefaultJsonDataService class. Currently the following error is shown in the application if an error is raised during the deleting of a record (for example: NullPointerException in an eventhandler):

Server returned FAILURE with no error message

and the log shows no error
Steps To Reproduce*
Proposed SolutionAdd the log.error(t.getMessage(), t); sentence in the catch section of the remove function:

    } catch (Throwable t) {
      log.error(t.getMessage(), t);
      return JsonUtils.convertExceptionToJson(t);
    }
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-07 18:33ngarciaNew Issue
2016-03-07 18:33ngarciaAssigned To => platform
2016-03-07 18:33ngarciaOBNetwork customer => No
2016-03-07 18:33ngarciaModules => Core
2016-03-07 18:33ngarciaSupport ticket => 41002
2016-03-07 18:33ngarciaTriggers an Emergency Pack => No
2016-03-07 18:44ngarciaIssue Monitored: networkb
2016-03-07 19:18caristuAssigned Toplatform => caristu
2016-03-07 19:19hgbotCheckin
2016-03-07 19:19hgbotNote Added: 0084792
2016-03-07 19:19hgbotStatusnew => resolved
2016-03-07 19:19hgbotResolutionopen => fixed
2016-03-07 19:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c89d61d6ab14a51b3ea8dff0dfaf2c51bd4a9ee4 [^]
2016-03-07 19:20caristuReview Assigned To => alostale
2016-03-08 09:02alostaleNote Added: 0084803
2016-03-08 09:02alostaleStatusresolved => new
2016-03-08 09:02alostaleResolutionfixed => open
2016-03-08 09:37caristuIssue Monitored: alostale
2016-03-08 09:38hgbotCheckin
2016-03-08 09:38hgbotNote Added: 0084807
2016-03-08 09:38caristuStatusnew => scheduled
2016-03-08 09:38caristuStatusscheduled => resolved
2016-03-08 09:38caristuResolutionopen => fixed
2016-03-11 08:24alostaleNote Added: 0084897
2016-03-11 08:24alostaleStatusresolved => closed
2016-03-11 08:24alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085187
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085190

Notes
(0084792)
hgbot   
2016-03-07 19:19   
Repository: erp/devel/pi
Changeset: c89d61d6ab14a51b3ea8dff0dfaf2c51bd4a9ee4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Mar 07 19:15:00 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c89d61d6ab14a51b3ea8dff0dfaf2c51bd4a9ee4 [^]

fixes issue 32429: Added error log in remove method of DefaultJsonDataService

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0084803)
alostale   
2016-03-08 09:02   
reopening after code review because:

1. if condition is unnecessary overcomplicated
2. log should add some context
(0084807)
hgbot   
2016-03-08 09:38   
Repository: erp/devel/pi
Changeset: e9790863827331887dd7d3c7e661dd96334fedb6
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Mar 08 09:36:55 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e9790863827331887dd7d3c7e661dd96334fedb6 [^]

related to issue 32429: code review improvements

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0084897)
alostale   
2016-03-11 08:24   
code reviewed
(0085187)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085190)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test