Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032424Openbravo ERP09. Financial managementpublic2016-03-07 12:472016-06-17 19:36
Reporteryogaskarnik 
Assigned ToAtulOpenbravo 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032424: New Account not created for Business Partner for organization F&B US, Inc. but works with F&B España, S.A
DescriptionNew Account not created for Business Partner for organization F&B US, Inc. but works with F&B España, S.A
Steps To Reproduce*Enable the General Ledgers tab in Organization window:
1.Login as system administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Windows, Tabs and Fields, search for Organization and Enable the General Ledger tab

*Setup for new account creation
1.Login as client administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Organization and select F&B US, Inc.
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=7
Sub Account Length=11

*Business Partner creation
1.Navigate to Business Partner window:
2.Create new record:
search key=test
name=test
3.save the record and observe that the default account is added instead of new business partner account.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0034847 new malsasua Unhomogeneous behavior when business partner is created: customer and employee accounting defaults 
causes defect 0033877 closed AtulOpenbravo Accounting default values not transferred from BP Category to Business Partner if the schema is assigned to a child organization 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-07 12:47yogaskarnikNew Issue
2016-03-07 12:47yogaskarnikAssigned To => Triage Finance
2016-03-07 12:47yogaskarnikModules => Core
2016-03-07 12:47yogaskarnikResolution time => 1457478000
2016-03-07 12:47yogaskarnikTriggers an Emergency Pack => No
2016-03-10 11:49yogaskarnikPrioritynormal => high
2016-03-11 10:53yogaskarnikResolution time1457478000 => 1459980000
2016-04-05 12:08aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-04-12 06:29AtulOpenbravoStatusnew => scheduled
2016-04-13 07:05AtulOpenbravoNote Added: 0085580
2016-04-13 13:12psanjuanNote Edited: 0085580bug_revision_view_page.php?bugnote_id=0085580#r11760
2016-04-13 15:25psanjuanNote Edited: 0085580bug_revision_view_page.php?bugnote_id=0085580#r11767
2016-04-13 15:26psanjuanNote Added: 0085620
2016-04-13 15:36psanjuanNote Added: 0085621
2016-04-13 15:36psanjuanNote Edited: 0085580bug_revision_view_page.php?bugnote_id=0085580#r11768
2016-04-13 15:45psanjuanNote Edited: 0085580bug_revision_view_page.php?bugnote_id=0085580#r11769
2016-04-13 15:47psanjuanNote Added: 0085622
2016-04-13 15:50psanjuanNote Edited: 0085622bug_revision_view_page.php?bugnote_id=0085622#r11771
2016-04-13 19:37aferrazNote Added: 0085629
2016-04-14 10:03aferrazNote Edited: 0085629bug_revision_view_page.php?bugnote_id=0085629#r11775
2016-04-14 19:29hgbotCheckin
2016-04-14 19:29hgbotNote Added: 0085651
2016-04-14 19:29hgbotStatusscheduled => resolved
2016-04-14 19:29hgbotResolutionopen => fixed
2016-04-14 19:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24d0d8ebfed92fd3bcee073b5780eb0afb7d40d9 [^]
2016-04-14 19:29hgbotCheckin
2016-04-14 19:29hgbotNote Added: 0085652
2016-04-14 19:30aferrazReview Assigned To => aferraz
2016-04-14 19:30aferrazNote Added: 0085653
2016-04-14 19:30aferrazStatusresolved => closed
2016-04-14 19:30aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:36hudsonbotCheckin
2016-06-17 19:36hudsonbotNote Added: 0087450
2016-06-17 19:36hudsonbotCheckin
2016-06-17 19:36hudsonbotNote Added: 0087451
2016-09-01 18:46ngarciaRelationship addedcauses 0033877
2017-01-04 10:04aferrazRelationship addedrelated to 0034847

Notes
(0085580)
AtulOpenbravo   
2016-04-13 07:05   
(edited on: 2016-04-13 15:45)
Test Plan for issue verification

* Enable the General Ledgers tab in Organization window:
1.Login as system administrator.
2.Navigate to Windows, Tabs and Fields, search for Organization and Enable the General Ledger tab

* Setup for new account creation
1.Login as F&B International Group Admin
2.Navigate to Organization and select F&B US, Inc.
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=7
Sub Account Length=11
In Document Sequence for Business Partner, set Next Assigned Number = 500

* Go to "General Ledger Configuration", select F&B International Group US/Dollar general ledger. Go to defaults tab and check below accounts are shown within BP section:
** 1130 Accounts Receivable
** 2450 Customer Prepayment

* Business Partner creation
1.Navigate to Business Partner window:
2.Create new record:
org = F&B US Inc
search key=test
name=test
Configure it as a Customer.
3.save the record and go to Customer Accounting tab.
4. Check that customer receivables account added is default one, which is not correct.

Repeat same test as above for product.
(0085620)
psanjuan   
2016-04-13 15:26   
Issue verified.
(0085621)
psanjuan   
2016-04-13 15:36   
Correct behavior explained in this link:

http://wiki.openbravo.com/wiki/ManualDoc:T7580F9AE37704571BB0D3935252CAC5A [^]
(0085622)
psanjuan   
2016-04-13 15:47   
(edited on: 2016-04-13 15:50)
Test Plan

* Enable the General Ledgers tab in Organization window:
1.Login as system administrator.
2.Navigate to Windows, Tabs and Fields, search for Organization and Enable the General Ledger tab

* Setup for new account creation
1.Login as F&B International Group Admin
2.Navigate to Organization and select F&B US, Inc.
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=7
Sub Account Length=11
In Document Sequence for Business Partner, set Next Assigned Number = 500

* Go to "General Ledger Configuration", select F&B International Group US/Dollar general ledger. Go to defaults tab and check below accounts are shown within BP section:
** 1130 Accounts Receivable

* Business Partner creation
1.Navigate to Business Partner window:
2.Create new record:
org = F&B US Inc
search key=test
name=test
Configure it as a Customer.
3.save the record and go to Customer Accounting tab.
4. Check that customer receivables account added is 11300500 and Customer Prepayment account added is 24500500

It is not 100% correct as length entered are not taken into account. Please double check.

Repeat same test as above for product.
(0085629)
aferraz   
2016-04-13 19:37   
(edited on: 2016-04-14 10:03)
Test plan II:

*Enable the General Ledgers tab in Organization window:
1.Login as system administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Windows, Tabs and Fields, search for Organization and Enable the General Ledger tab

*In Document Sequence window, set Next Assigned Number = 500 for DocumentNo_C_BPartner.

*Setup for new account creation for F&B International Group organization:
1.Login as client administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Organization and select F&B International Group
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=4
Sub Account Length=7

*Setup for new account creation for F&B US, Inc. organization:
1.Login as client administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Organization and select F&B US, Inc.
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=4
Sub Account Length=9

*Setup for new account creation for F&B US East Coast organization:
1.Login as client administrator to erp_mp_3.0PR15Q4.4
2.Navigate to Organization and select F&B US East Coast
3.Go to General Ledgers tab and create a new record :
Create New Account for Business Partner=Y
Sequence for Business Partner=DocumentNo_C_BPartner
Account Length=4
Sub Account Length=11

*Business Partner creation
1.Navigate to Business Partner window:
2.Create new record:
org: F&B US, Inc.
search key=test
name=test
3.Check that customer receivables account added is 113000500 and Customer Prepayment account added is 245000500 (Account Length=4 and Sub Account Length=9) which is correct
(0085651)
hgbot   
2016-04-14 19:29   
Repository: erp/devel/pi
Changeset: 24d0d8ebfed92fd3bcee073b5780eb0afb7d40d9
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Apr 13 12:34:12 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/24d0d8ebfed92fd3bcee073b5780eb0afb7d40d9 [^]

Fixes Issue 32424:New Account not created for Business Partner

ORDER BY 1 DESC clause is now changed to DEFAULT that is ascending
order of the level of organization. As unique entry for every
acctschema is allowed. In the descending order case top most organization
setting were used to create entry in accounting tab. In the case mentioned
in the issue, F&B International Group org has level 3 and was first
to be inserted for schema F& International Group USD Account and for this
configuration create new bp account setting did not exists so deafult account
entry was made and though F&B US Inc had setting of new bp account but the
same acctschema could not be repeated in this case.

---
M src-db/database/model/triggers/C_BPARTNER_TRG.xml
---
(0085652)
hgbot   
2016-04-14 19:29   
Repository: erp/devel/pi
Changeset: 51adf3f34dbef5c80a620d1c90c41bb1d50f4853
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 14 18:51:24 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/51adf3f34dbef5c80a620d1c90c41bb1d50f4853 [^]

Related to issue 32424: Code review improvements

Fix another call to AD_IsOrgIncluded where ad_org_id parameter was used instead of ad_client_id.
Retrieve only AD_Org_AcctSchema from business partner organization or from parent organizations, but not from children organizations.
Call to c_validcombination_clone only if first parameter is not null.
In c_validcombination_clone function, return null if first parameter is null.

---
M src-db/database/model/functions/C_VALIDCOMBINATION_CLONE.xml
M src-db/database/model/triggers/C_BPARTNER_TRG.xml
---
(0085653)
aferraz   
2016-04-14 19:30   
Code review + Testing OK
(0087450)
hudsonbot   
2016-06-17 19:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087451)
hudsonbot   
2016-06-17 19:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test