Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032380Retail ModulesWeb POSpublic2016-03-01 12:122016-03-14 13:32
Reporteragete 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032380: [SERQA 757] POS blocked when accesing with an url with //
DescriptionAccessing to the Web POS with the following address (double // before retail....) the login page appears but when accesing it seems to be blocked, no message appears.
https://livebuilds.openbravo.com//retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login [^]
Steps To Reproduce1- Add the following url to the browser:
https://livebuilds.openbravo.com//retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login [^]

2- Select a user and log in

3- realize it gets blocked
Proposed SolutionAdd an error message indicating url is wrong
Additional Information
TagsSER-QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-01 12:12ageteNew Issue
2016-03-01 12:12ageteAssigned To => Retail
2016-03-01 12:12ageteResolution time => 1457996400
2016-03-01 12:12ageteTriggers an Emergency Pack => No
2016-03-01 12:12ageteTag Attached: SER-QA
2016-03-01 15:37OrekariaStatusnew => acknowledged
2016-03-08 15:55jorge-garciaStatusacknowledged => scheduled
2016-03-08 15:55jorge-garciaAssigned ToRetail => jorge-garcia
2016-03-11 12:22hgbotCheckin
2016-03-11 12:22hgbotNote Added: 0084910
2016-03-11 12:22hgbotStatusscheduled => resolved
2016-03-11 12:22hgbotResolutionopen => fixed
2016-03-11 12:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5e59ade8aeecb019bc1f55e437a42922e06c83f5 [^]
2016-03-11 12:23hgbotCheckin
2016-03-11 12:23hgbotNote Added: 0084911
2016-03-11 15:41marvintmReview Assigned To => marvintm
2016-03-11 15:41marvintmStatusresolved => closed
2016-03-11 15:41marvintmFixed in Version => RR16Q2
2016-03-11 21:50OrekariaNote Added: 0084925
2016-03-11 21:50OrekariaStatusclosed => new
2016-03-11 21:50OrekariaResolutionfixed => open
2016-03-11 21:50OrekariaFixed in VersionRR16Q2 =>
2016-03-11 21:51OrekariaStatusnew => scheduled
2016-03-14 12:02hgbotCheckin
2016-03-14 12:02hgbotNote Added: 0084946
2016-03-14 12:03jorge-garciaStatusscheduled => resolved
2016-03-14 12:03jorge-garciaResolutionopen => fixed
2016-03-14 13:32marvintmStatusresolved => closed
2016-03-14 13:32marvintmFixed in Version => RR16Q2

Notes
(0084910)
hgbot   
2016-03-11 12:22   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5e59ade8aeecb019bc1f55e437a42922e06c83f5
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Mar 09 11:46:31 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5e59ade8aeecb019bc1f55e437a42922e06c83f5 [^]

Fixed issue 32380: [SERQA 757] POS blocked when accesing with an url with //

The solution is to parse the URL before do anything in the POS. If the url
suffers any change, the browser navigates to the parsed url and a console
warning is raised.

---
M web/org.openbravo.mobile.core/source/utils/ob-debug.js
---
(0084911)
hgbot   
2016-03-11 12:23   
Repository: tools/automation/pi-mobile
Changeset: 382970e798cdab06b3ef52f8fad3058d581962db
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Mar 11 12:19:18 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/382970e798cdab06b3ef52f8fad3058d581962db [^]

Verifies issue 32380: [SERQA 757] POS blocked when accesing with an url with //

Added test I32380_MalformedPOSUrlParsing.

---
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/system/I32380_MalformedPOSUrlParsing.java
---
(0084925)
Orekaria   
2016-03-11 21:50   
The ob-debug file must contain only debug related things
Move the function to a better place or create its own file
(0084946)
hgbot   
2016-03-14 12:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d4d894a92cc64bfb5817817c14fecb81990c680c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Mar 14 10:07:23 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d4d894a92cc64bfb5817817c14fecb81990c680c [^]

Related to issue 32380: [SERQA 757] POS blocked when accesing with an url with //

The function that checks if the url is correct, has been set in the ob-checks.js

This code is set at the begginning of the generated javascript.

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
M web/org.openbravo.mobile.core/source/utils/ob-debug.js
A web/org.openbravo.mobile.core/source/utils/ob-check.js
---