Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032379Retail ModulesBest Deal Casepublic2016-03-01 12:122018-06-26 11:40
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product VersionRR15Q4.4 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032379: If Best Deal Case and Discount by total are installed it is not refreshing the amounts
DescriptionIf Best Deal Case and Discount by total are installed it is not refreshing the amounts.
Once you click total button and a discount by total is added if yout add more lines of a different product the amount is not updated.
Steps To ReproduceInstall Best Deal Case module
Install discounts by total module
Configure best deal case by checking both checks on Organization window for orf VallBlanca store http://wiki.openbravo.com/wiki/Retail:Promotions_Best_Deal_Case [^]
Create a new Discount by total of needed amount 1000 and a discount of 10
http://wiki.openbravo.com/wiki/Retail:By_Total_Discounts [^]
Log in on VBS-1 terminal
Click on browse
Add 7 Avalanche transceiver (You will see that no discount appears)
Click total button and the discount appears
Click on browse again
Add 2 Headlamp ultralight
You will see that the total amount has not been modified and also the amount of the Headlamp line does not multiply the Qty and the ProductPrice (See the screenshot)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032467 closed jorge-garcia Best Deal Case is removing one line 
related to defect 0032548 acknowledged Retail Best Deal Case and By Total Discount are not working fine 
Attached Filespng Screenshot from 2016-03-01 12:12:06.png (215,447) 2016-03-01 12:13
https://issues.openbravo.com/file_download.php?file_id=9120&type=bug
png

patch issue 32379 Test 5207.patch (8,111) 2016-03-15 15:03
https://issues.openbravo.com/file_download.php?file_id=9165&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-01 12:12guillermogilNew Issue
2016-03-01 12:12guillermogilAssigned To => Retail
2016-03-01 12:12guillermogilOBNetwork customer => Yes
2016-03-01 12:12guillermogilTriggers an Emergency Pack => No
2016-03-01 12:12guillermogilPrioritynormal => high
2016-03-01 12:13guillermogilFile Added: Screenshot from 2016-03-01 12:12:06.png
2016-03-01 16:12OrekariaStatusnew => acknowledged
2016-03-09 13:32ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-03-09 13:33ranjith_qualiantech_comStatusacknowledged => scheduled
2016-03-14 08:44hgbotCheckin
2016-03-14 08:44hgbotNote Added: 0084930
2016-03-14 08:44hgbotStatusscheduled => resolved
2016-03-14 08:44hgbotResolutionopen => fixed
2016-03-14 08:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/ef8d62fbc2e62af1e5f9fe0de81544f3e4af0b8d [^]
2016-03-14 09:58ranjith_qualiantech_comNote Added: 0084937
2016-03-14 09:58ranjith_qualiantech_comStatusresolved => new
2016-03-14 09:58ranjith_qualiantech_comResolutionfixed => open
2016-03-14 09:58ranjith_qualiantech_comStatusnew => scheduled
2016-03-15 13:41OrekariaRelationship addedrelated to 0032467
2016-03-15 13:43ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => jorge-garcia
2016-03-15 15:03ranjith_qualiantech_comFile Added: issue 32379 Test 5207.patch
2016-03-29 15:16jorge-garciaRelationship addedrelated to 0032548
2016-04-05 10:31maiteResolution time => 1460671200
2016-04-07 16:26hgbotCheckin
2016-04-07 16:26hgbotNote Added: 0085496
2016-04-07 16:26hgbotStatusscheduled => resolved
2016-04-07 16:26hgbotResolutionopen => fixed
2016-04-07 16:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/ef8d62fbc2e62af1e5f9fe0de81544f3e4af0b8d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/0b9a2a0271c550ccfe9398d9be3fee655cd37437 [^]
2016-04-13 11:35hgbotCheckin
2016-04-13 11:35hgbotNote Added: 0085593
2016-04-13 11:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/0b9a2a0271c550ccfe9398d9be3fee655cd37437 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/18e42a29a65047619194ac97370ca90b22b46678 [^]
2016-04-13 12:58hgbotCheckin
2016-04-13 12:58hgbotNote Added: 0085604
2016-04-13 12:59hgbotCheckin
2016-04-13 12:59hgbotNote Added: 0085607
2016-04-13 13:00hgbotCheckin
2016-04-13 13:00hgbotNote Added: 0085608
2016-04-28 10:04marvintmReview Assigned To => marvintm
2016-04-28 10:04marvintmStatusresolved => closed
2016-04-28 10:04marvintmFixed in Version => RR16Q3
2018-06-26 11:40hgbotCheckin
2018-06-26 11:40hgbotNote Added: 0105416
2018-06-26 11:40hgbotCheckin
2018-06-26 11:40hgbotNote Added: 0105417
2018-06-26 14:15gorka_gilNote Deleted: 0105416
2018-06-26 14:15gorka_gilNote Deleted: 0105417

Notes
(0084930)
hgbot   
2016-03-14 08:44   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: ef8d62fbc2e62af1e5f9fe0de81544f3e4af0b8d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 14 13:14:24 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/ef8d62fbc2e62af1e5f9fe0de81544f3e4af0b8d [^]

Fixes issue 32379 : Changes in Best Discount Calculation

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0084937)
ranjith_qualiantech_com   
2016-03-14 09:58   
Fix is not correct, Tests in Discount Combo, By total through error in try
(0085496)
hgbot   
2016-04-07 16:26   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 0b9a2a0271c550ccfe9398d9be3fee655cd37437
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Mar 23 17:30:11 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/0b9a2a0271c550ccfe9398d9be3fee655cd37437 [^]

Fixed issue 32379: If Best Deal Case and Discount by total are installed it is
not refreshing the amounts

The problem was that the discount engine get stuck if the receipt has the flag preventApplyPromotions as true.

The solution is to change the discount engine to be better with this kinds of
flows, and delay set the preventApplyPromotions flag to false.

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0085593)
hgbot   
2016-04-13 11:35   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 18e42a29a65047619194ac97370ca90b22b46678
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Apr 11 10:22:51 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/18e42a29a65047619194ac97370ca90b22b46678 [^]

Fixed issue 32379: If Best Deal Case and Discount by total are installed it is
not refreshing the amounts

The problem was that the discount engine get stuck if the receipt has the flag preventApplyPromotions as true.

The solution is to change the discount engine to be better with this kinds of
flows, and delay set the preventApplyPromotions flag to false.

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0085604)
hgbot   
2016-04-13 12:58   
Repository: tools/automation/pi-mobile
Changeset: a47d2dc2e06efc065bd320cbb33643a9106d4d91
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Mar 30 13:02:53 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a47d2dc2e06efc065bd320cbb33643a9106d4d91 [^]

Verifies issue 32379: If Best Deal Case and Discount by total are installed it is
not refreshing the amounts

Added test I32379_BestDealRecalculateTicket.

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32379_BestDealRecalculateTicket.java
---
(0085607)
hgbot   
2016-04-13 12:59   
Repository: tools/automation/pi-mobile
Changeset: c7b4a3f5ebddf5a57eb05fe8170d8a0313855ad7
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Apr 11 09:18:26 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c7b4a3f5ebddf5a57eb05fe8170d8a0313855ad7 [^]

Related to issue 32379: If Best Deal Case and Discount by total are installed it is
not refreshing the amounts

Change discount name in I32379_BestDealRecalculateTicket test.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bestdeal/I32379_BestDealRecalculateTicket.java
---
(0085608)
hgbot   
2016-04-13 13:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5aa4c1615adf20f9d578e9f8dab4a17fcab8a6cb
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Mar 29 15:25:09 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5aa4c1615adf20f9d578e9f8dab4a17fcab8a6cb [^]

Related to issue 32379: If Best Deal Case and Discount by total are installed it is
not refreshing the amounts

A small change is necessary in discount.js file to be solve skip or prevent
apply promotions to the receipt, or while the receipt is clonning.

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---