Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032363Retail ModulesWeb POSpublic2016-02-26 13:172016-03-17 17:25
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032363: If taxes calculation fails, the receipt cannot be imported in the server side
DescriptionIf the preference "Save Deleted Ticket" is activated, and an error calculating taxes appear, if the receipt is completed the order cannot be imported and the following error goes to "Errors while importing POS data"

org.openbravo.base.exception.OBException: Error in OrderLoader:
        at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:439)
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:206)
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:163)
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:95)
        at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:41)
        at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:370)
        at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:292)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
        at java.util.concurrent.FutureTask.run(FutureTask.java:166)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:701)
Caused by: java.sql.SQLIntegrityConstraintViolationException: ORA-01400: cannot insert NULL into ("TAD"."C_ORDERLINE"."C_TAX_ID")

The reason is that when a taxes error appears and the preference "Save Deleted Ticket" is activated, the line with the error is stored locally with taxID null and this order cannot be stored because of database constraint
Steps To Reproduce1. Activate preference "Save Deleted Ticket"
2. Go to Web POS and force a taxes calculation error
3. Solve it and in the same receipt add other products and close the receipt
4. Verify the window "Errors while importing POS Data and check the error saving the order
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-26 13:17adrianromeroNew Issue
2016-02-26 13:17adrianromeroAssigned To => Retail
2016-02-26 13:17adrianromeroTriggers an Emergency Pack => No
2016-02-26 13:18adrianromeroReview Assigned To => marvintm
2016-02-26 13:18adrianromeroAssigned ToRetail => adrianromero
2016-02-26 13:18adrianromeroStatusnew => scheduled
2016-03-07 11:47hgbotCheckin
2016-03-07 11:47hgbotNote Added: 0084762
2016-03-07 11:47hgbotStatusscheduled => resolved
2016-03-07 11:47hgbotResolutionopen => fixed
2016-03-07 11:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/73e38cb7b2460bef89776aa91e653578e8eefaa4 [^]
2016-03-17 17:25marvintmStatusresolved => closed
2016-03-17 17:25marvintmFixed in Version => RR16Q2

Notes
(0084762)
hgbot   
2016-03-07 11:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 73e38cb7b2460bef89776aa91e653578e8eefaa4
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 26 13:20:07 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/73e38cb7b2460bef89776aa91e653578e8eefaa4 [^]

Fixes issue 0032363: If taxes calculation fails, the receipt cannot be imported in the server side
* Lines deleted because of taxes error are never stored

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---