Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032359Retail ModulesWeb POSpublic2016-02-26 11:242016-03-11 13:33
Reporteragete 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032359: [SERQA 750] A combo defined without any family launch a javascript error when it is selecting
DescriptionA combo defined without any family launch a javascript error when it is selecting in a receipt
Steps To Reproduce1.In backend create a new discount and promotion called "Combo test without families defined"
2. Select discount type Combo and starting date 1/2/2016, save the discount
3. In POS select the combo just created
Realize a javascript error is launch
Proposed SolutionThe discounts and promotions with no family defined are not completed so they should not be shown in POS.
Additional Information
TagsSER-QA
Relationships
related to defect 0049742 closed ranjith_qualiantech_com Retail Modules Combo promotion wrongly configured block the access to the WebPOS 
related to defect 0049979 closed radhakrishnan Retail Modules Inactive discount is downloaded when POS is connected 
related to defect 0052618 closed ranjith_qualiantech_com POS2 Pos 2: promotions wrongly configured block the access to the WebPOS 
causes defect 0033041 closed ranjith_qualiantech_com Retail Modules Combo discount without family defined in one organization also gives error message in other organizations 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-26 11:24ageteNew Issue
2016-02-26 11:24ageteAssigned To => Retail
2016-02-26 11:24ageteResolution time => 1457737200
2016-02-26 11:24ageteTriggers an Emergency Pack => No
2016-02-26 11:24ageteTag Attached: SER-QA
2016-02-26 11:28ageteSummary[SERQA ] A combo defined without any family launch a javascript error when it is selecting => [SERQA 750] A combo defined without any family launch a javascript error when it is selecting
2016-03-01 14:57OrekariaStatusnew => acknowledged
2016-03-01 15:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-03-01 15:44ranjith_qualiantech_comStatusacknowledged => scheduled
2016-03-02 15:26hgbotCheckin
2016-03-02 15:26hgbotNote Added: 0084660
2016-03-02 15:26hgbotStatusscheduled => resolved
2016-03-02 15:26hgbotResolutionopen => fixed
2016-03-02 15:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/a2731e0b424df1e023b563a72dee43089f3ba4b4 [^]
2016-03-11 13:33marvintmReview Assigned To => marvintm
2016-03-11 13:33marvintmStatusresolved => closed
2016-03-11 13:33marvintmFixed in Version => RR16Q2
2016-05-24 21:51mtaalRelationship addedcauses 0033041
2022-07-07 07:35ranjith_qualiantech_comRelationship addedrelated to 0049742
2022-08-10 07:13rafarodaRelationship addedrelated to 0049979
2023-05-31 11:10ranjith_qualiantech_comRelationship addedrelated to 0052618

Notes
(0084660)
hgbot   
2016-03-02 15:26   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: a2731e0b424df1e023b563a72dee43089f3ba4b4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Mar 02 19:55:31 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/a2731e0b424df1e023b563a72dee43089f3ba4b4 [^]

Fixes issue 32359 : Discount with type "Combo" should not be loaded if family is not defined

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/discounts/combo/master/Family.java
M web/org.openbravo.retail.discounts.combo/source/combo-popup.js
A src/org/openbravo/retail/discounts/combo/master/DiscountComboValidation.java
---