Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032333Retail ModulesWeb POSpublic2016-02-24 20:142016-02-26 11:57
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4.4Fixed in VersionRR15Q4.4 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032333: Tickets not included in cashup if cashup was done offline
DescriptionIn certain circumstances, if tickets are created while being offline, and then a cashup is done also while being offline, then the cashup may be processed before all tickets have been processed. In this case, the tickets will not be invoiced, and their payments will be missing in the cashup reconciliation.
Steps To ReproduceThis issue is very easy to reproduce in 15Q3, but it's much harder to reproduce in 15Q4 or 16Q1, although it's still theoretically possible to face it there.

The steps to reproduce are the following:
- Log in the Web POS. Go offline.
- Create five or more tickets.
- Do the cashup.
- Go back online. Log in again.
- Verify that the tickets have been synchronized, and the cashup is processed. However, all tickets except the first one will not be invoiced, and their payments will not be reconciled.
Proposed SolutionThe cause of the problem is that the synchronization tasks in the backend are not processing correctly entries which contain more than one record in the JSON. In this case, the import entry should be marked as processed only when all the records have been processed, and currently this is not the case (the entry is marked as processed as soon as the first record is processed).
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0032295RR15Q3.5 closed Retail [RR15Q3] cashups are processed before than receipts 
blocks defect 0032331 closed marvintm Tickets not included in cashup if cashup was done offline 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-24 20:14marvintmTypedefect => backport
2016-02-24 20:14marvintmTarget Version => RR15Q4.4
2016-02-25 19:58hgbotCheckin
2016-02-25 19:58hgbotNote Added: 0084530
2016-02-25 19:58hgbotStatusscheduled => resolved
2016-02-25 19:58hgbotResolutionopen => fixed
2016-02-25 19:58hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4.4/org.openbravo.mobile.core/rev/cbdb060fca93a4b60b88adfde9e7ac0144b1494b [^]
2016-02-25 20:00hgbotCheckin
2016-02-25 20:00hgbotNote Added: 0084531
2016-02-25 20:00hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR15Q4.4/org.openbravo.mobile.core/rev/cbdb060fca93a4b60b88adfde9e7ac0144b1494b [^] => http://code.openbravo.com/erp/backports/3.0PR15Q4.4/rev/6db117b0e95c377584ddac80aa28ac9f28a5ea3f [^]
2016-02-26 11:57OrekariaReview Assigned To => Orekaria
2016-02-26 11:57OrekariaStatusresolved => closed
2016-02-26 11:57OrekariaFixed in Version => RR15Q4.4
2016-02-26 12:18OrekariaRelationship addedhas duplicate 0032295

Notes
(0084530)
hgbot   
2016-02-25 19:58   
Repository: retail/backports/3.0RR15Q4.4/org.openbravo.mobile.core
Changeset: cbdb060fca93a4b60b88adfde9e7ac0144b1494b
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 25 19:58:22 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.4/org.openbravo.mobile.core/rev/cbdb060fca93a4b60b88adfde9e7ac0144b1494b [^]

Fixed issue 32333. Prevent early update to the Import Entry record:
Before this change, if a request to the DataSynchronizationProcess contained more than one record, the Import Entry record was updated after the first one instead of being updated after the last one.

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
---
(0084531)
hgbot   
2016-02-25 20:00   
Repository: erp/backports/3.0PR15Q4.4
Changeset: 6db117b0e95c377584ddac80aa28ac9f28a5ea3f
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 25 19:59:45 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.4/rev/6db117b0e95c377584ddac80aa28ac9f28a5ea3f [^]

Fixed issue 32333. Added method to check if importentry has status 'Error'

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---