Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032332Retail ModulesWeb POSpublic2016-02-24 20:142016-03-09 16:12
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032332: Tickets not included in cashup if cashup was done offline
DescriptionIn certain circumstances, if tickets are created while being offline, and then a cashup is done also while being offline, then the cashup may be processed before all tickets have been processed. In this case, the tickets will not be invoiced, and their payments will be missing in the cashup reconciliation.
Steps To ReproduceThis issue is very easy to reproduce in 15Q3, but it's much harder to reproduce in 15Q4 or 16Q1, although it's still theoretically possible to face it there.

The steps to reproduce are the following:
- Log in the Web POS. Go offline.
- Create five or more tickets.
- Do the cashup.
- Go back online. Log in again.
- Verify that the tickets have been synchronized, and the cashup is processed. However, all tickets except the first one will not be invoiced, and their payments will not be reconciled.
Proposed SolutionThe cause of the problem is that the synchronization tasks in the backend are not processing correctly entries which contain more than one record in the JSON. In this case, the import entry should be marked as processed only when all the records have been processed, and currently this is not the case (the entry is marked as processed as soon as the first record is processed).
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032331 closed marvintm Tickets not included in cashup if cashup was done offline 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-24 20:14marvintmTypedefect => backport
2016-02-24 20:14marvintmTarget Version => RR16Q1
2016-02-29 17:34hgbotCheckin
2016-02-29 17:34hgbotNote Added: 0084606
2016-02-29 17:34hgbotStatusscheduled => resolved
2016-02-29 17:34hgbotResolutionopen => fixed
2016-02-29 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/fa3cf2f87496d85df40bfcf8d6361f8196f1a64b [^]
2016-02-29 17:41hgbotCheckin
2016-02-29 17:41hgbotNote Added: 0084607
2016-02-29 17:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR16Q1/rev/fa3cf2f87496d85df40bfcf8d6361f8196f1a64b [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.mobile.core/rev/332f1b6a82610ef3fa0fda65fae92332bd2fdff0 [^]
2016-03-04 18:42OrekariaReview Assigned To => Orekaria
2016-03-04 18:42OrekariaStatusresolved => closed
2016-03-04 18:42OrekariaFixed in Version => RR16Q1
2016-03-09 16:12hgbotCheckin
2016-03-09 16:12hgbotNote Added: 0084849

Notes
(0084606)
hgbot   
2016-02-29 17:34   
Repository: erp/backports/3.0PR16Q1
Changeset: fa3cf2f87496d85df40bfcf8d6361f8196f1a64b
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Feb 29 17:34:08 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/fa3cf2f87496d85df40bfcf8d6361f8196f1a64b [^]

Fixed issue 32332. Added method to check if importentry has status 'Error'

---
M modules/org.openbravo.client.kernel/jslint/jscheck
M modules/org.openbravo.client.kernel/jslint/jslint
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0084607)
hgbot   
2016-02-29 17:41   
Repository: retail/backports/3.0RR16Q1/org.openbravo.mobile.core
Changeset: 332f1b6a82610ef3fa0fda65fae92332bd2fdff0
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Feb 29 17:40:43 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.mobile.core/rev/332f1b6a82610ef3fa0fda65fae92332bd2fdff0 [^]

Fixed issue 32332. Prevent early update to the Import Entry record:
Before this change, if a request to the DataSynchronizationProcess contained more than one record, the Import Entry record was updated after the first one instead of being updated after the last one.

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
---
(0084849)
hgbot   
2016-03-09 16:12   
Repository: erp/backports/3.0PR16Q1
Changeset: 0778229579650923353b8567993a3473da13b260
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Wed Mar 09 16:11:53 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/0778229579650923353b8567993a3473da13b260 [^]

Related to issue 32332. Removed wrong part of the diff.

---
M modules/org.openbravo.client.kernel/jslint/jscheck
M modules/org.openbravo.client.kernel/jslint/jslint
---