Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032331Retail ModulesWeb POSpublic2016-02-24 20:142016-03-21 19:07
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-05-08
Regression introduced in releaseRR15Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/111c0d56d9b2f713c88e9465824c01092bd0829e [^]
Triggers an Emergency PackNo
Summary0032331: Tickets not included in cashup if cashup was done offline
DescriptionIn certain circumstances, if tickets are created while being offline, and then a cashup is done also while being offline, then the cashup may be processed before all tickets have been processed. In this case, the tickets will not be invoiced, and their payments will be missing in the cashup reconciliation.
Steps To ReproduceThis issue is very easy to reproduce in 15Q3, but it's much harder to reproduce in 15Q4 or 16Q1, although it's still theoretically possible to face it there.

The steps to reproduce are the following:
- Log in the Web POS. Go offline.
- Create five or more tickets.
- Do the cashup.
- Go back online. Log in again.
- Verify that the tickets have been synchronized, and the cashup is processed. However, all tickets except the first one will not be invoiced, and their payments will not be reconciled.
Proposed SolutionThe cause of the problem is that the synchronization tasks in the backend are not processing correctly entries which contain more than one record in the JSON. In this case, the import entry should be marked as processed only when all the records have been processed, and currently this is not the case (the entry is marked as processed as soon as the first record is processed).
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032332RR16Q1 closed marvintm Tickets not included in cashup if cashup was done offline 
depends on backport 0032333RR15Q4.4 closed marvintm Tickets not included in cashup if cashup was done offline 
caused by feature request 0029766RR15Q3 closed mtaal Retail Operations Buffer: store all transactions in operations table before processing 
Attached Filesdiff issue32331.pi.diff (1,226) 2016-02-24 20:40
https://issues.openbravo.com/file_download.php?file_id=9099&type=bug
diff issue32331.mobilecore.diff (1,730) 2016-02-24 20:40
https://issues.openbravo.com/file_download.php?file_id=9100&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-24 20:14marvintmNew Issue
2016-02-24 20:14marvintmAssigned To => Retail
2016-02-24 20:14marvintmTriggers an Emergency Pack => No
2016-02-24 20:14marvintmAssigned ToRetail => marvintm
2016-02-24 20:14marvintmStatusnew => scheduled
2016-02-24 20:19marvintmRegression level => Production - Confirmed Stable
2016-02-24 20:19marvintmRegression date => 2015-05-08
2016-02-24 20:19marvintmRegression introduced in release => RR15Q3
2016-02-24 20:19marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/111c0d56d9b2f713c88e9465824c01092bd0829e [^]
2016-02-24 20:40dmitry_mezentsevRelationship addedcaused by 0029766
2016-02-24 20:40marvintmFile Added: issue32331.pi.diff
2016-02-24 20:40marvintmFile Added: issue32331.mobilecore.diff
2016-03-08 11:21hgbotCheckin
2016-03-08 11:21hgbotNote Added: 0084814
2016-03-08 11:21hgbotStatusscheduled => resolved
2016-03-08 11:21hgbotResolutionopen => fixed
2016-03-08 11:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1e5083005e09288f96453a38ff05026794705514 [^]
2016-03-08 11:22hgbotCheckin
2016-03-08 11:22hgbotNote Added: 0084815
2016-03-08 11:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1e5083005e09288f96453a38ff05026794705514 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aecf07933024310744d7f762337caeb43bfcb8af [^]
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085191
2016-03-21 19:07guilleaerReview Assigned To => guilleaer
2016-03-21 19:07guilleaerStatusresolved => closed
2016-03-21 19:07guilleaerFixed in Version => RR16Q2

Notes
(0084814)
hgbot   
2016-03-08 11:21   
Repository: erp/devel/pi
Changeset: 1e5083005e09288f96453a38ff05026794705514
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Tue Mar 08 11:21:24 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1e5083005e09288f96453a38ff05026794705514 [^]

Fixed issue 32331. Added method to check if importentry has status 'Error'

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
---
(0084815)
hgbot   
2016-03-08 11:22   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: aecf07933024310744d7f762337caeb43bfcb8af
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Tue Mar 08 11:22:39 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/aecf07933024310744d7f762337caeb43bfcb8af [^]

Fixed issue 32331. Prevent early update to the Import Entry record:
Before this change, if a request to the DataSynchronizationProcess contained more than one record, the Import Entry record was updated after the first one instead of being updated after the last one.

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
---
(0085191)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test