Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032316Retail ModulesWeb POSpublic2016-02-23 12:392016-03-11 13:11
Reporteryogaskarnik 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR15Q2.3 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket40326
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032316: autodismiss:false is not working in modalAction Window
Descriptionautodismiss:false is not working in modal pop up
Steps To ReproduceAfter adding the sources provided:

1.login to web pos terminal VBS-1
2.click on the button named "Click this button" which opens a modal popup
3.press esc key and observe that the modal popup closes
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 32316_reproduce_issue.diff (5,557) 2016-02-29 11:37
https://issues.openbravo.com/file_download.php?file_id=9118&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-23 12:39yogaskarnikNew Issue
2016-02-23 12:39yogaskarnikAssigned To => Retail
2016-02-23 12:39yogaskarnikFile Added: myModalPopup.js
2016-02-23 12:39yogaskarnikOBNetwork customer => Yes
2016-02-23 12:39yogaskarnikSupport ticket => 40326
2016-02-23 12:39yogaskarnikResolution time => 1456441200
2016-02-23 12:39yogaskarnikTriggers an Emergency Pack => No
2016-02-23 12:52yogaskarnikversionRR15Q3.4 => RR15Q2.3
2016-02-25 17:20OrekariaNote Added: 0084520
2016-02-25 17:20OrekariaStatusnew => feedback
2016-02-29 11:36yogaskarnikFile Deleted: myModalPopup.js
2016-02-29 11:37yogaskarnikFile Added: 32316_reproduce_issue.diff
2016-02-29 11:37yogaskarnikNote Added: 0084588
2016-02-29 11:38yogaskarnikStatusfeedback => new
2016-02-29 11:39OrekariaStatusnew => acknowledged
2016-02-29 12:08yogaskarnikSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11269#r11269
2016-03-03 08:37ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-03-03 08:37ranjith_qualiantech_comStatusacknowledged => scheduled
2016-03-03 14:37ranjith_qualiantech_comNote Added: 0084685
2016-03-03 14:37ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => yogaskarnik
2016-03-03 14:37ranjith_qualiantech_comStatusscheduled => feedback
2016-03-08 05:54yogaskarnikNote Added: 0084797
2016-03-08 05:54yogaskarnikAssigned Toyogaskarnik => ranjith_qualiantech_com
2016-03-08 05:54yogaskarnikStatusfeedback => new
2016-03-08 08:11ranjith_qualiantech_comStatusnew => scheduled
2016-03-08 12:02hgbotCheckin
2016-03-08 12:02hgbotNote Added: 0084820
2016-03-08 12:02hgbotStatusscheduled => resolved
2016-03-08 12:02hgbotResolutionopen => fixed
2016-03-08 12:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d94dd34d7b2bda219039d82f41c1ea7de82b9400 [^]
2016-03-11 13:11marvintmReview Assigned To => marvintm
2016-03-11 13:11marvintmStatusresolved => closed
2016-03-11 13:11marvintmFixed in Version => RR16Q2

Notes
(0084520)
Orekaria   
2016-02-25 17:20   
the js contains errors
provide a diff to be applied to the retail code
and instructions on how to show the popup

also, major?
(0084588)
yogaskarnik   
2016-02-29 11:37   
Added diff to reproduce the issue
(0084685)
ranjith_qualiantech_com   
2016-03-03 14:37   
Issue Steps to reproduce is working as per current functionality

autoDismiss works as follows
* if it is set as "false", popup will be closed by esc key (or) cliking popup buttons
* if it is set as "true", popup will be closed by clicking on black area (or) esc key (or) cliking popup buttons

To prevent Popup/Modal close by clicking "esc" key, we have attribute called "closeOnEscKey" in "OB.UI.Popup" kind. (By default, the value is true.).
TO prevent Popup/Modal close , we need to pass "closeOnEscKey" as "false"
(0084797)
yogaskarnik   
2016-03-08 05:54   
Yes, the popup/modal does not close if the property "closeOnEscKey" is set as "false".
(0084820)
hgbot   
2016-03-08 12:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d94dd34d7b2bda219039d82f41c1ea7de82b9400
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Mar 08 16:14:36 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d94dd34d7b2bda219039d82f41c1ea7de82b9400 [^]

Fixes issue 32316 : Adding autoDismiss condition to Popup Esc key handler event

---
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
---