Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0032275Openbravo ERPA. Platformpublic2016-02-18 14:502016-03-17 10:56
alostale 
alostale 
normalminorN/A
closedfixed 
5
 
3.0PR16Q2 
caristu
Core
No
0032275: jUnit: add capability to assert on logs
In some occasions, it is useful to create test cases to assert a concrete message is logged. Though this can be implemented by test, currently there is no a common API infrastructure to consume in order to achieve it.
Suppose you want to test that some warn message is logged after doing some process. Ideally the test would look like:

  @Test
  public void unbalancedAdminModeShouldLogWarn() {
    setTestLogAppenderLevel(Level.WARN);

    OBContext.setAdminMode(true);
    OBContext.restorePreviousMode();
    OBContext.restorePreviousMode(); // second restore is unbalanced

    assertThat(getTestLogAppender().getMessages(Level.WARN),
        hasItem(containsString("Unbalanced calls to setAdminMode")));
  }

Where 1st line sets the threshold for which messages are going to be tracked and the asset gets messages tracked since that point and checks there is a concrete one.
No tags attached.
Issue History
2016-02-18 14:50alostaleNew Issue
2016-02-18 14:50alostaleAssigned To => alostale
2016-02-18 14:50alostaleModules => Core
2016-02-18 14:50alostaleTriggers an Emergency Pack => No
2016-02-18 14:51alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11165#r11165
2016-02-18 14:51alostaleReview Assigned To => caristu
2016-02-18 14:55hgbotCheckin
2016-02-18 14:55hgbotNote Added: 0084323
2016-02-18 14:55hgbotStatusnew => resolved
2016-02-18 14:55hgbotResolutionopen => fixed
2016-02-18 14:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/06cd9c11c84e319330f31d8113426169b6da3e78 [^]
2016-02-19 08:53hgbotCheckin
2016-02-19 08:53hgbotNote Added: 0084342
2016-02-19 09:02caristuNote Added: 0084343
2016-02-19 09:02caristuStatusresolved => closed
2016-02-19 09:02caristuFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085149
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085150

Notes
(0084323)
hgbot   
2016-02-18 14:55   
Repository: erp/devel/pi
Changeset: 06cd9c11c84e319330f31d8113426169b6da3e78
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Feb 18 14:54:19 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/06cd9c11c84e319330f31d8113426169b6da3e78 [^]

fixed issue 32275: jUnit: add capability to assert on logs

  TestLogAppender can be used in test cases extending OBBaseTest to perform
  assertions on what is logged.

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
A src-test/src/org/openbravo/test/base/TestLogAppender.java
---
(0084342)
hgbot   
2016-02-19 08:53   
Repository: erp/devel/pi
Changeset: 429009e5662e75381ad4ef7b5c645ac8a5bff1d9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 19 08:52:30 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/429009e5662e75381ad4ef7b5c645ac8a5bff1d9 [^]

related to issue 32275: fixes typo

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0084343)
caristu   
2016-02-19 09:02   
Verified
(0085149)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085150)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test